Skip to contentSkip to conversation

Vhost-user early adopter feedback

DISCUSSION Benoît Canet 2 participants 3 messages Feb 18, 2015 – Feb 25, 2015 1 message not in the archive

lore
Share & tools
lore
#0 lore raw

Hello Xie,

As promized I integrated your vhost-user patchset from january in my vswitch.

I just tried it, it works pretty well.

I just had a minor bug with rte_vhost_driver_register taking ownership of the string patch pointer too late. I freed it out of habit just after registering in the caller and when ifname[IFNAMESIZ] was written the pointer was used for a new string I allocated later. Maybe an early strdup() would fix this.

The last patch of your new version is really a great idea since it will simplify a lot the socket creation and management code.

Best regards

Benoît

#1 lore raw
Quoted 10 lines · Benoît Canet

Hello Xie,

As promized I integrated your vhost-user patchset from january in my vswitch.

I just tried it, it works pretty well.

I just had a minor bug with rte_vhost_driver_register taking ownership of the string patch pointer too late. I freed it out of habit just after registering in the caller and when ifname[IFNAMESIZ] was written the pointer was used for a new string I allocated later. Maybe an early strdup() would fix this.

Thanks.
Do you mean we duplicate a string from the first parameter path, like vserver->path = strdup(path) ?
If this was the case, it was ever in my mind. We would do this if necessary.

Quoted 9 lines

The last patch of your new version is really a great idea since it will simplify a lot the socket creation and management code.

Best regards

Benoît

A message that is not in the archive (sent off-list or not yet received): C37D651A908B024F974696C65296B57B0F3A436D-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org

#3 lore raw
Quoted 7 lines · Huawei
Quoted 6 lines · Benoît Canet

Hello Xie,

As promized I integrated your vhost-user patchset from january in my vswitch.

I just tried it, it works pretty well.

Quoted 7 lines
Quoted 4 lines

I just had a minor bug with rte_vhost_driver_register taking ownership of the string patch pointer too late. I freed it out of habit just after registering in the caller and when ifname[IFNAMESIZ] was written the pointer was used for a new string I allocated later. Maybe an early strdup() would fix this.

Thanks.
Do you mean we duplicate a string from the first parameter path, like vserver->path = strdup(path) ?

Yes I was thinking about this.

Best regards

Benoît

Quoted 13 lines

If this was the case, it was ever in my mind. We would do this if necessary.

Quoted 9 lines

The last patch of your new version is really a great idea since it will simplify a lot the socket creation and management code.

Best regards

Benoît