bfa: fix bfa_cb_sfp_state_query()

PATCH New Dan Carpenter 1 participant 1 message Feb 25, 2015

Subsystems (3)

SCSI Kernel janitors Brocade BFA FC SCSI driver

lore

Share & tools

lore

Dan Carpenter

author

2015-02-25 13:12 UTC #0 lore raw

PATCH 1/1 bfa: fix bfa_cb_sfp_state_query()

There are several missing curly braces so this function doesn't work as intended.

Signed-off-by Dan Carpenter <[email protected]>

drivers/scsi/bfa/bfa_ioc.c +4 -2

index 315d6d6..59c3492 100644
@@ -3662,7 +3662,7 @@ bfa_cb_sfp_state_query(struct bfa_sfp_s *sfp)
 	bfa_trc(sfp, sfp->portspeed);
 	if (sfp->media) {
 		bfa_sfp_media_get(sfp);
-		if (sfp->state_query_cbfn)
+		if (sfp->state_query_cbfn) {
 			sfp->state_query_cbfn(sfp->state_query_cbarg,
 					sfp->status);
 			sfp->media = NULL;

@@ -3670,14 +3670,16 @@ bfa_cb_sfp_state_query(struct bfa_sfp_s *sfp)
 
 		if (sfp->portspeed) {
 			sfp->status = bfa_sfp_speed_valid(sfp, sfp->portspeed);
-			if (sfp->state_query_cbfn)
+			if (sfp->state_query_cbfn) {
 				sfp->state_query_cbfn(sfp->state_query_cbarg,
 						sfp->status);
 				sfp->portspeed = BFA_PORT_SPEED_UNKNOWN;
+			}
 		}
 
 		sfp->state_query_lock = 0;
 		sfp->state_query_cbfn = NULL;
+	}
 }
 
 /*