rocker: silence shift wrapping warning
Subsystems (4)
PATCH 2/2 rocker: silence shift wrapping warning
"val" is declared as a u64 so static checkers complain that this shift can wrap. I don't have the hardware but probably it's doesn't have over 31 ports. Still we may as well silence the warning even if it's not a real bug.
drivers/net/ethernet/rocker/rocker.c +2 -2
@@ -1257,9 +1257,9 @@ static void rocker_port_set_enable(struct rocker_port *rocker_port, bool enable)u64 val =rocker_read64 (rocker_port->rocker,PORT_PHYS_ENABLE );if (enable) - val |=1 << rocker_port->lport; + val |=1ULL << rocker_port->lport;else - val &= ~(1 << rocker_port->lport); + val &= ~(1ULL << rocker_port->lport);rocker_write64 (rocker_port->rocker,PORT_PHYS_ENABLE , val); }
Quoted 2 lines · Wed, Feb 25, 2015 at 02:36:12PM CET, [email protected] wrote:
"val" is declared as a u64 so static checkers complain that this shift can wrap. I don't have the hardware but probably it's doesn't have over
It's a QEMU hardware, you can have it easily.
Quoted 2 lines
31 ports. Still we may as well silence the warning even if it's not a real bug.
It can have up to 62 ports.
Quoted 2 lines
Signed-off-by Dan Carpenter <[email protected]>
Quoted 13 lines · Dan Carpenter
"val" is declared as a u64 so static checkers complain that this shift can wrap. I don't have the hardware but probably it's doesn't have over 31 ports. Still we may as well silence the warning even if it's not a real bug.
Signed-off-by Dan Carpenter <[email protected]>drivers/net/ethernet/rocker/rocker.c +0
-0@@ -1257,9 +1257,9 @@ static void rocker_port_set_enable(struct rocker_port *rocker_port, bool enable)u64 val =rocker_read64 (rocker_port->rocker,PORT_PHYS_ENABLE );
drivers/net/ethernet/rocker/rocker.c static void rocker_port_set_enable(struct rocker_port *rocker_port, bool enable) · line 1265
Quoted 10 lines
drivers/net/ethernet/rocker/rocker.c +2
-2if (enable) - val |=1 << rocker_port->lport; + val |=1ULL << rocker_port->lport;else - val &= ~(1 << rocker_port->lport); + val &= ~(1ULL << rocker_port->lport);rocker_write64 (rocker_port->rocker,PORT_PHYS_ENABLE , val); }
From: Dan Carpenter <[email protected]>
Date: Wed, 25 Feb 2015 16:36:12 +0300
Quoted 6 lines
"val" is declared as a u64 so static checkers complain that this shift can wrap. I don't have the hardware but probably it's doesn't have over 31 ports. Still we may as well silence the warning even if it's not a real bug.
Signed-off-by Dan Carpenter <[email protected]>
Applied.