Skip to contentSkip to conversation

rocker: add a check for NULL in rocker_probe_ports()

PATCH Applied Dan Carpenter 4 participants 4 messages Feb 25, 2015 – Feb 27, 2015

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 rocker: add a check for NULL in rocker_probe_ports()

Make sure kmalloc() succeeds.

drivers/net/ethernet/rocker/rocker.c +2 -0
index 34389b6a..713a13c 100644
@@ -4201,6 +4201,8 @@ static int rocker_probe_ports(struct rocker *rocker)
 
 	alloc_size = sizeof(struct rocker_port *) * rocker->port_count;
 	rocker->ports = kmalloc(alloc_size, GFP_KERNEL);
+	if (!rocker->ports)
+		return -ENOMEM;
 	for (i = 0; i < rocker->port_count; i++) {
 		err = rocker_probe_port(rocker, i);
 		if (err)
Acked-by on v1 1/2
#1 lore raw
Quoted 9 lines · Dan Carpenter

Make sure kmalloc() succeeds.

drivers/net/ethernet/rocker/rocker.c +0 -0
index 34389b6a..713a13c 100644

drivers/net/ethernet/rocker/rocker.c static int rocker_probe_ports(struct rocker *rocker) · line 4208

Quoted 8 lines
drivers/net/ethernet/rocker/rocker.c +2 -0
@@ -4201,6 +4201,8 @@ static int rocker_probe_ports(struct rocker *rocker)
 
        alloc_size = sizeof(struct rocker_port *) * rocker->port_count;
        rocker->ports = kmalloc(alloc_size, GFP_KERNEL);
+       if (!rocker->ports)
+               return -ENOMEM;
        for (i = 0; i < rocker->port_count; i++) {
                err = rocker_probe_port(rocker, i);
                if (err)