rocker: add a check for NULL in rocker_probe_ports()
Subsystems (4)
PATCH 1/2 rocker: add a check for NULL in rocker_probe_ports()
Make sure kmalloc() succeeds.
Signed-off-by Dan Carpenter <[email protected]>
drivers/net/ethernet/rocker/rocker.c +2 -0
@@ -4201,6 +4201,8 @@ static int rocker_probe_ports(struct rocker *rocker) alloc_size =sizeof (struct rocker_port *) * rocker->port_count; rocker->ports =kmalloc (alloc_size,GFP_KERNEL ); +if (!rocker->ports) +return -ENOMEM ;for (i =0 ; i < rocker->port_count; i++) { err =rocker_probe_port (rocker, i);if (err)
Quoted 9 lines · Dan Carpenter
Make sure
kmalloc()succeeds.Signed-off-by Dan Carpenter <[email protected]>drivers/net/ethernet/rocker/rocker.c +0
-0
drivers/net/ethernet/rocker/rocker.c static int rocker_probe_ports(struct rocker *rocker) · line 4208
Quoted 8 lines
drivers/net/ethernet/rocker/rocker.c +2
-0@@ -4201,6 +4201,8 @@ static int rocker_probe_ports(struct rocker *rocker) alloc_size =sizeof (struct rocker_port *) * rocker->port_count; rocker->ports =kmalloc (alloc_size,GFP_KERNEL ); +if (!rocker->ports) +return -ENOMEM ;for (i =0 ; i < rocker->port_count; i++) { err =rocker_probe_port (rocker, i);if (err)
Acked-by Scott Feldman <[email protected]>
Quoted 1 line · Wed, Feb 25, 2015 at 02:35:32PM CET, [email protected] wrote:
Make sure
kmalloc()succeeds.
Ough, nice catch. I see that the error path when rocker_probe_port fails is also broken - I will send follow-up fix. Thanks!
Quoted 2 lines
Signed-off-by Dan Carpenter <[email protected]>
Acked-by Jiri Pirko <[email protected]>
From: Dan Carpenter <[email protected]>
Date: Wed, 25 Feb 2015 16:35:32 +0300
Quoted 3 lines
Make sure
kmalloc()succeeds.Signed-off-by Dan Carpenter <[email protected]>
Applied.