Input: sun4i-ts: add thermal driver dependency
Subsystems (2)
PATCH v2 1/1 Input: sun4i-ts: add thermal driver dependency
From: Arnd Bergmann <[email protected]>
The sun4i-ts driver has had a dependency on the thermal code with the addition of the thermal zone sensor support, but this is not currently enforced in Kconfig, so with TOUCHSCREEN_SUN4I=y, THERMAL=m and THERMAL_OF=y we get
drivers/built-in.o: In function `sun4i_ts_remove':
:(.text+0x2376f4): undefined reference to thermal_zone_of_sensor_unregister' drivers/built-in.o: In function sun4i_ts_probe':
:(.text+0x237a94): undefined reference to thermal_zone_of_sensor_register' :(.text+0x237c00): undefined reference to thermal_zone_of_sensor_unregister'
We need the dependency on THERMAL in order to ensure that this driver becomes a loadable module if the thermal support itself is modular, while the dependency on THERMAL_OF is a runtime dependency and the driver will still build if it is missing. It is entirely possible to build sun4i-ts without THERMAL_OF just to use the hwmon sensors and/or touchscreen.
---
v2 updates the Kconfig dependencies as Dmitry pointed out, and makes the description be more specific on the failing config and why a dependency on THERMAL_OF is not required. The failing commit hash is also updated.
--- drivers/input/touchscreen/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/input/touchscreen/Kconfig +1 -0
@@ -943,6 +943,7 @@ config TOUCHSCREEN_SUN4I tristate "Allwinner sun4i resistive touchscreen controller support" depends on ARCH_SUNXI || COMPILE_TEST depends on HWMON + depends on THERMAL || !THERMAL_OF help This selects support for the resistive touchscreen controller found on Allwinner sunxi SoCs.
Signature · 1 line
2.1.4
PATCH v2 1/1 Input: sun4i-ts: add thermal driver dependency
Quoted 20 lines · Chen-Yu Tsai
From: Arnd Bergmann <[email protected]>
The sun4i-ts driver has had a dependency on the thermal code with the addition of the thermal zone sensor support, but this is not currently enforced in
Kconfig, so with TOUCHSCREEN_SUN4I=y, THERMAL=m and THERMAL_OF=y we get
drivers/built-in.o: In function `sun4i_ts_remove':
:(.text+0x2376f4): undefined reference tothermal_zone_of_sensor_unregister' drivers/built-in.o: In functionsun4i_ts_probe':
:(.text+0x237a94): undefined reference tothermal_zone_of_sensor_register' :(.text+0x237c00): undefined reference tothermal_zone_of_sensor_unregister'We need the dependency on THERMAL in order to ensure that this driver becomes a loadable module if the thermal support itself is modular, while the dependency on
THERMAL_OFis a runtime dependency and the driver will still build if it is missing. It is entirely possible to build sun4i-ts withoutTHERMAL_OFjust to use the hwmon sensors and/or touchscreen.
Quoted 4 lines
Fixes 223697107949 ("Input: sun4i-ts - add thermal zone sensor support")Signed-off-by Arnd Bergmann <[email protected]>[wens at csie.org: Fix description and Kconfig dependencies]Signed-off-by Chen-Yu Tsai <[email protected]>
Applied, thank you.
Quoted 26 lines
---
v2 updates the
Kconfigdependencies as Dmitry pointed out, and makes the description be more specific on the failing config and why a dependency onTHERMAL_OFis not required. The failing commit hash is also updated.--- drivers/input/touchscreen/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/input/touchscreen/Kconfig +1
-0@@ -943,6 +943,7 @@ config TOUCHSCREEN_SUN4I tristate "Allwinner sun4i resistive touchscreen controller support" depends on ARCH_SUNXI || COMPILE_TEST depends on HWMON + depends on THERMAL || !THERMAL_OF help This selects support for the resistive touchscreen controller found on Allwinner sunxi SoCs.Signature · 1 line
2.1.4
Signature · 1 line
Dmitry