drm: Complete moving rotation property to core
Subsystems (3)
PATCH 1/2 drm: Complete moving rotation property to core
From: Tvrtko Ursulin <[email protected]>
Commit 1da30627fc511a57c9bd23a02c97f0576379f761 "drm: Add rotation value to plane state" moved the rotation property to DRM core but only did the set property part. This does the get property part as well.
--- drivers/gpu/drm/drm_atomic.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/drm_atomic.c +2 -0
@@ -450,6 +450,8 @@ drm_atomic_plane_get_property(struct drm_plane *plane, *val = state->src_w; }else if (property == config->prop_src_h) { *val = state->src_h; + }else if (property == config->rotation_property) { + *val = state->rotation; }else if (plane->funcs->atomic_get_property) {return plane->funcs->atomic_get_property (plane, state, property, val); }else {
Signature · 6 lines
2.3.0 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
PATCH 2/2 drm/i915: Rotation property is now handled in DRM core
From: Tvrtko Ursulin <[email protected]>
So no need to have code which never gets called in the driver.
--- drivers/gpu/drm/i915/intel_atomic_plane.c | 24 ++++-------------------- 1 file changed, 4 insertions(+), 20 deletions(-)
drivers/gpu/drm/i915/intel_atomic_plane.c +4 -20
@@ -203,16 +203,8 @@ intel_plane_atomic_get_property(struct drm_plane *plane, struct drm_property *property, uint64_t *val) { - struct drm_mode_config *config = &plane->dev->mode_config; - -if (property == config->rotation_property) { - *val = state->rotation; - }else { -DRM_DEBUG_KMS ("Unknown plane property '%s'\n" , property->name); -return -EINVAL ; - } - -return 0 ; + DRM_DEBUG_KMS("Unknown plane property '%s'\n", property->name); +return -EINVAL ; }/**
@@ -233,14 +225,6 @@ intel_plane_atomic_set_property(struct drm_plane *plane, struct drm_property *property, uint64_t val) { -struct drm_mode_config *config = &plane->dev->mode_config; - -if (property == config->rotation_property) { - state->rotation = val; - }else { -DRM_DEBUG_KMS ("Unknown plane property '%s'\n" , property->name); -return -EINVAL ; - } - -return 0 ; +DRM_DEBUG_KMS ("Unknown plane property '%s'\n" , property->name); +return -EINVAL ; }
Signature · 6 lines
2.3.0 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [PATCH 2/2] drm/i915: Rotation property is now handled in DRM core
Task id: 5835 -------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
PNV 282/282 282/282
ILK -1 308/308 307/308 SNB -1 326/326 325/326 IVB 379/379 379/379 BYT 294/294 294/294 HSW 387/387 387/387 BDW -1 316/316 315/316 -------------------------------------Detailed------------------------------------- Platform Test drm-intel-nightly Series Applied *ILK igt_gem_unfence_active_buffers PASS(2) DMESG_WARN(1)PASS(1) *SNB igt_kms_pipe_crc_basic_read-crc-pipe-B-frame-sequence PASS(3) DMESG_WARN(1)PASS(1) *BDW igt_gem_gtt_hog PASS(8) DMESG_WARN(1)PASS(1)
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list [email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
For both patches:
Quoted 30 lines · Tvrtko Ursulin
From: Tvrtko Ursulin <[email protected]>
Commit
1da30627fc511a57c9bd23a02c97f0576379f761"drm: Add rotation value to plane state" moved the rotation property to DRM core but only did the set property part. This does the get property part as well.Signed-off-by Tvrtko Ursulin <[email protected]>Cc Matt Roper <[email protected]>Reviewed-by Daniel Vetter <[email protected]>--- drivers/gpu/drm/drm_atomic.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/drm_atomic.c +2
-0@@ -450,6 +450,8 @@ drm_atomic_plane_get_property(struct drm_plane *plane, *val = state->src_w; }else if (property == config->prop_src_h) { *val = state->src_h; + }else if (property == config->rotation_property) { + *val = state->rotation; }else if (plane->funcs->atomic_get_property) {return plane->funcs->atomic_get_property (plane, state, property, val); }else {Signature · 1 line
2.3.0
Signature · 9 lines
Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 3 lines · Matt Roper
For both patches:
Reviewed-by Matt Roper <[email protected]>
Both merged to drm-misc, thanks.
-Daniel
Quoted 43 lines · Tvrtko Ursulin
Quoted 30 lines
From: Tvrtko Ursulin <[email protected]>
Commit
1da30627fc511a57c9bd23a02c97f0576379f761"drm: Add rotation value to plane state" moved the rotation property to DRM core but only did the set property part. This does the get property part as well.Signed-off-by Tvrtko Ursulin <[email protected]>Cc Matt Roper <[email protected]>Reviewed-by Daniel Vetter <[email protected]>--- drivers/gpu/drm/drm_atomic.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/drm_atomic.c +2
-0@@ -450,6 +450,8 @@ drm_atomic_plane_get_property(struct drm_plane *plane, *val = state->src_w; }else if (property == config->prop_src_h) { *val = state->src_h; + }else if (property == config->rotation_property) { + *val = state->rotation; }else if (plane->funcs->atomic_get_property) {return plane->funcs->atomic_get_property (plane, state, property, val); }else {Signature · 1 line
2.3.0Signature · 9 lines
Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/dri-devel