Staging: lustre: lnet: Cleanup switch statement
PATCH 1/2 Staging: lustre: lnet: Cleanup switch statement
Signed-off-by aybuke ozdemir <[email protected]>
This patch fixes the following checkpatch error:
ERROR: switch and case should be at the same indent 859: FILE: drivers/staging/lustre/lnet/selftest/conctl.c:859:
--- drivers/staging/lustre/lnet/selftest/conctl.c | 112 +++++++++++++------------- 1 file changed, 56 insertions(+), 56 deletions(-)
drivers/staging/lustre/lnet/selftest/conctl.c +56 -56
@@ -857,62 +857,62 @@ lstcon_ioctl_entry(unsigned int cmd, struct libcfs_ioctl_data *data)memset (&console_session.ses_trans_stat,0 ,sizeof (lstcon_trans_stat_t));switch (opc) { -case LSTIO_SESSION_NEW : - rc =lst_session_new_ioctl ((lstio_session_new_args_t *)buf); -break ; -case LSTIO_SESSION_END : - rc =lst_session_end_ioctl ((lstio_session_end_args_t *)buf); -break ; -case LSTIO_SESSION_INFO : - rc =lst_session_info_ioctl ((lstio_session_info_args_t *)buf); -break ; -case LSTIO_DEBUG : - rc =lst_debug_ioctl ((lstio_debug_args_t *)buf); -break ; -case LSTIO_GROUP_ADD : - rc =lst_group_add_ioctl ((lstio_group_add_args_t *)buf); -break ; -case LSTIO_GROUP_DEL : - rc =lst_group_del_ioctl ((lstio_group_del_args_t *)buf); -break ; -case LSTIO_GROUP_UPDATE : - rc =lst_group_update_ioctl ((lstio_group_update_args_t *)buf); -break ; -case LSTIO_NODES_ADD : - rc =lst_nodes_add_ioctl ((lstio_group_nodes_args_t *)buf); -break ; -case LSTIO_GROUP_LIST : - rc =lst_group_list_ioctl ((lstio_group_list_args_t *)buf); -break ; -case LSTIO_GROUP_INFO : - rc =lst_group_info_ioctl ((lstio_group_info_args_t *)buf); -break ; -case LSTIO_BATCH_ADD : - rc =lst_batch_add_ioctl ((lstio_batch_add_args_t *)buf); -break ; -case LSTIO_BATCH_START : - rc =lst_batch_run_ioctl ((lstio_batch_run_args_t *)buf); -break ; -case LSTIO_BATCH_STOP : - rc =lst_batch_stop_ioctl ((lstio_batch_stop_args_t *)buf); -break ; -case LSTIO_BATCH_QUERY : - rc =lst_batch_query_ioctl ((lstio_batch_query_args_t *)buf); -break ; -case LSTIO_BATCH_LIST : - rc =lst_batch_list_ioctl ((lstio_batch_list_args_t *)buf); -break ; -case LSTIO_BATCH_INFO : - rc =lst_batch_info_ioctl ((lstio_batch_info_args_t *)buf); -break ; -case LSTIO_TEST_ADD : - rc =lst_test_add_ioctl ((lstio_test_args_t *)buf); -break ; -case LSTIO_STAT_QUERY : - rc =lst_stat_query_ioctl ((lstio_stat_args_t *)buf); -break ; -default : - rc = -EINVAL ; +case LSTIO_SESSION_NEW : + rc =lst_session_new_ioctl ((lstio_session_new_args_t *)buf); +break ; +case LSTIO_SESSION_END : + rc =lst_session_end_ioctl ((lstio_session_end_args_t *)buf); +break ; +case LSTIO_SESSION_INFO : + rc =lst_session_info_ioctl ((lstio_session_info_args_t *)buf); +break ; +case LSTIO_DEBUG : + rc =lst_debug_ioctl ((lstio_debug_args_t *)buf); +break ; +case LSTIO_GROUP_ADD : + rc =lst_group_add_ioctl ((lstio_group_add_args_t *)buf); +break ; +case LSTIO_GROUP_DEL : + rc =lst_group_del_ioctl ((lstio_group_del_args_t *)buf); +break ; +case LSTIO_GROUP_UPDATE : + rc =lst_group_update_ioctl ((lstio_group_update_args_t *)buf); +break ; +case LSTIO_NODES_ADD : + rc =lst_nodes_add_ioctl ((lstio_group_nodes_args_t *)buf); +break ; +case LSTIO_GROUP_LIST : + rc =lst_group_list_ioctl ((lstio_group_list_args_t *)buf); +break ; +case LSTIO_GROUP_INFO : + rc =lst_group_info_ioctl ((lstio_group_info_args_t *)buf); +break ; +case LSTIO_BATCH_ADD : + rc =lst_batch_add_ioctl ((lstio_batch_add_args_t *)buf); +break ; +case LSTIO_BATCH_START : + rc =lst_batch_run_ioctl ((lstio_batch_run_args_t *)buf); +break ; +case LSTIO_BATCH_STOP : + rc =lst_batch_stop_ioctl ((lstio_batch_stop_args_t *)buf); +break ; +case LSTIO_BATCH_QUERY : + rc =lst_batch_query_ioctl ((lstio_batch_query_args_t *)buf); +break ; +case LSTIO_BATCH_LIST : + rc =lst_batch_list_ioctl ((lstio_batch_list_args_t *)buf); +break ; +case LSTIO_BATCH_INFO : + rc =lst_batch_info_ioctl ((lstio_batch_info_args_t *)buf); +break ; +case LSTIO_TEST_ADD : + rc =lst_test_add_ioctl ((lstio_test_args_t *)buf); +break ; +case LSTIO_STAT_QUERY : + rc =lst_stat_query_ioctl ((lstio_stat_args_t *)buf); +break ; +default : + rc = -EINVAL ; } if (copy_to_user(data->ioc_pbuf2, &console_session.ses_trans_stat,
Signature · 1 line
1.9.1
PATCH 2/2 Staging: lustre: lnet: add spaces around '||'
This fixes the checkpatch.pl error in conctl.c:
ERROR: spaces required around that '||' (ctx:VxE)
Signed-off-by aybuke ozdemir <[email protected]>
--- drivers/staging/lustre/lnet/selftest/conctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/lustre/lnet/selftest/conctl.c +1 -1
@@ -203,7 +203,7 @@ lst_group_add_ioctl(lstio_group_add_args_t *args)if (args->lstio_grp_key != console_session.ses_key)return -EACCES ; -if (args->lstio_grp_namep ==NULL || +if (args->lstio_grp_namep ==NULL || args->lstio_grp_nmlen <=0 || args->lstio_grp_nmlen >LST_NAME_SIZE )return -EINVAL ;
Signature · 1 line
1.9.1
Greg KH
maintainerQuoted 8 lines · aybuke ozdemir
Signed-off-by aybuke ozdemir <[email protected]>This patch fixes the following checkpatch error:
ERROR: switch and case should be at the same indent 859: FILE:drivers/staging/lustre/lnet/selftest/conctl.c:859:--- drivers/staging/lustre/lnet/selftest/conctl.c | 112 +++++++++++++------------- 1 file changed, 56 insertions(+), 56 deletions(-)
Signed-off-by needs to be at the bottom of the changelog description.
thanks,
greg k-h