Staging: vt6655: changed C99 // comments
PATCH v2 1/1 Staging: vt6655: changed C99 // comments
// erased and replace it with /**/ used.
Error found with checkpatch.pl
---
v2:
*Some /**/ deleted.A row in a single comment line was made.Added a space between the ; and the /*.
--- drivers/staging/vt6655/rf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/vt6655/rf.c +3 -3
@@ -438,13 +438,13 @@ static bool s_bAL7230Init(struct vnt_private *priv)MACvWordRegBitsOn (dwIoBase,MAC_REG_SOFTPWRCTL ,SOFTPWRCTL_SWPE3 );/* Calibration */ -MACvTimer0MicroSDelay (dwIoBase,150 );/* 150us */ +MACvTimer0MicroSDelay (dwIoBase,150 );/* 150us */ /* TXDCOC:active, RCK:disable */ bResult &=IFRFbWriteEmbedded (priv, (0x9ABA8F00 +(BY_AL7230_REG_LEN <<3 )+IFREGCTL_REGW )); -MACvTimer0MicroSDelay (dwIoBase,30 );/* 30us */ +MACvTimer0MicroSDelay (dwIoBase,30 );/* 30us */ /* TXDCOC:disable, RCK:active */ bResult &=IFRFbWriteEmbedded (priv, (0x3ABA8F00 +(BY_AL7230_REG_LEN <<3 )+IFREGCTL_REGW )); -MACvTimer0MicroSDelay (dwIoBase,30 );/* 30us */ +MACvTimer0MicroSDelay (dwIoBase,30 );/* 30us */ /* TXDCOC:disable, RCK:disable */ bResult &=IFRFbWriteEmbedded (priv, dwAL7230InitTable[CB_AL7230_INIT_SEQ -1 ]);
Signature · 1 line
1.9.1
Quoted 7 lines · Hatice ERTÜRK
// erased and replace it with /**/ used.
Error found with checkpatch.plSigned-off-by Hatice ERTURK <[email protected]>---
v2:
*Some /**/ deleted.A row in a single comment line was made.Added a space between the ; and the /*.
Looks better. The * at the beginning of the line does not seem necessary. When you put punctuation (comma, period, etc) put at least one space after it.
You don't have to send a new version for these issues, because the text is below the line. Just remember for next time.
julia
Quoted 35 lines
--- drivers/staging/vt6655/rf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/staging/vt6655/rf.c +3
-3@@ -438,13 +438,13 @@ static bool s_bAL7230Init(struct vnt_private *priv)MACvWordRegBitsOn (dwIoBase,MAC_REG_SOFTPWRCTL ,SOFTPWRCTL_SWPE3 );/* Calibration */ -MACvTimer0MicroSDelay (dwIoBase,150 );/* 150us */ +MACvTimer0MicroSDelay (dwIoBase,150 );/* 150us */ /* TXDCOC:active, RCK:disable */ bResult &=IFRFbWriteEmbedded (priv, (0x9ABA8F00 +(BY_AL7230_REG_LEN <<3 )+IFREGCTL_REGW )); -MACvTimer0MicroSDelay (dwIoBase,30 );/* 30us */ +MACvTimer0MicroSDelay (dwIoBase,30 );/* 30us */ /* TXDCOC:disable, RCK:active */ bResult &=IFRFbWriteEmbedded (priv, (0x3ABA8F00 +(BY_AL7230_REG_LEN <<3 )+IFREGCTL_REGW )); -MACvTimer0MicroSDelay (dwIoBase,30 );/* 30us */ +MACvTimer0MicroSDelay (dwIoBase,30 );/* 30us */ /* TXDCOC:disable, RCK:disable */ bResult &=IFRFbWriteEmbedded (priv, dwAL7230InitTable[CB_AL7230_INIT_SEQ -1 ]);Signature · 8 lines
1.9.1 -- You received this message because you are subscribed to the Google Groups "outreachy-kernel" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1424472008-9544-1-git-send-email-haticeerturk27%40gmail.com. For more options, visit https://groups.google.com/d/optout.
Greg KH
maintainerQuoted 34 lines · Hatice ERT�RK
// erased and replace it with /**/ used.
Error found with checkpatch.plSigned-off-by Hatice ERTURK <[email protected]>---
v2:
*Some /**/ deleted.A row in a single comment line was made.Added a space between the ; and the /*.--- drivers/staging/vt6655/rf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/staging/vt6655/rf.c +3
-3@@ -438,13 +438,13 @@ static bool s_bAL7230Init(struct vnt_private *priv)MACvWordRegBitsOn (dwIoBase,MAC_REG_SOFTPWRCTL ,SOFTPWRCTL_SWPE3 );/* Calibration */ -MACvTimer0MicroSDelay (dwIoBase,150 );/* 150us */ +MACvTimer0MicroSDelay (dwIoBase,150 );/* 150us */ /* TXDCOC:active, RCK:disable */ bResult &=IFRFbWriteEmbedded (priv, (0x9ABA8F00 +(BY_AL7230_REG_LEN <<3 )+IFREGCTL_REGW )); -MACvTimer0MicroSDelay (dwIoBase,30 );/* 30us */ +MACvTimer0MicroSDelay (dwIoBase,30 );/* 30us */ /* TXDCOC:disable, RCK:active */ bResult &=IFRFbWriteEmbedded (priv, (0x3ABA8F00 +(BY_AL7230_REG_LEN <<3 )+IFREGCTL_REGW )); -MACvTimer0MicroSDelay (dwIoBase,30 );/* 30us */ +MACvTimer0MicroSDelay (dwIoBase,30 );/* 30us */ /* TXDCOC:disable, RCK:disable */ bResult &=IFRFbWriteEmbedded (priv, dwAL7230InitTable[CB_AL7230_INIT_SEQ -1 ]);Signature · 1 line
1.9.1
This also doesn't apply, please use my latest kernel tree.
thanks,
greg k-h