IB/ipath: remove some left over code
Subsystems (2)
PATCH 1/1 IB/ipath: remove some left over code
"ret" is always zero here after commit c4bce8032ef4 ('IB/ipath: Add new chip-specific functions to older chips, consistent init').
Signed-off-by Dan Carpenter <[email protected]>
---
I just happened to spot this dead code when I was reviewing a different static checker warning:
drivers/infiniband/hw/ipath/ipath_verbs.c:2266 show_hca()
warn: bool is not less than zero.
It looks to me that this code returns 0 on success and 1 on failure so the warning is correct. This is very strange. The documentation doesn't say anything about what the return codes mean so it is all very puzzling.
drivers/infiniband/hw/ipath/ipath_iba6110.c +0 -4
@@ -721,10 +721,6 @@ static int ipath_ht_boardname(struct ipath_devdata *dd, char *name,if (n)snprintf (name, namelen,"%s" , n); -if (ret) { -ipath_dev_err (dd,"Unsupported InfiniPath board %s!\n" , name); - goto bail; - }if (dd->ipath_majrev !=3 || (dd->ipath_minrev <2 || dd->ipath_minrev >4 )) {/*
Quoted 1 line
Subject: [patch] IB/ipath: remove some left over code
Thanks for the patch!
Acked-by Mike Marciniszyn <[email protected]>