Staging: rtl8723au: Remove warning quoted string split across lines.
PATCH 1/3 Staging: rtl8723au: Remove warning quoted string split across lines.
WARNING: quoted string split across lines
That was found by running checkpatch.
--- drivers/staging/rtl8723au/os_dep/usb_intf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8723au/os_dep/usb_intf.c +2 -2
@@ -130,8 +130,8 @@ static struct dvobj_priv *usb_dvobj_init(struct usb_interface *usb_intf)usb_endpoint_num (pendp_desc); pdvobjpriv->RtNumInPipes++; }else if (usb_endpoint_is_int_in (pendp_desc)) { -DBG_8723A ("usb_endpoint_is_int_in = %x, Interval = " -"%x\n" ,usb_endpoint_num (pendp_desc), +DBG_8723A ("usb_endpoint_is_int_in = %x" , +"Interval =%x\n" ,usb_endpoint_num (pendp_desc), pendp_desc->bInterval); pdvobjpriv->RtInPipe[pdvobjpriv->RtNumInPipes] =usb_endpoint_num (pendp_desc);
Signature · 1 line
1.8.3.2
PATCH 2/3 Staging: rtl8723au: Remove return in void function
WARNING: void function return statements are not generally useful Remove return in void function. That was found by running checkpatch.
--- drivers/staging/rtl8723au/os_dep/usb_intf.c | 2 -- 1 file changed, 2 deletions(-)
drivers/staging/rtl8723au/os_dep/usb_intf.c +0 -2
@@ -599,8 +599,6 @@ static void rtw_disconnect(struct usb_interface *pusb_intf)RT_TRACE (_module_hci_intfs_c_, _drv_err_, ("-dev_remove()\n" ));DBG_8723A ("-r871xu_dev_remove, done\n" ); - -return ; }static int __init rtw_drv_entry (void )
Signature · 1 line
1.8.3.2
Re: [Outreachy kernel] [PATCH 2/3] Staging: rtl8723au: Remove return in void function
Quoted 4 lines · Melike Yurtoglu
WARNING: void function return statements are not generally useful Remove return in void function. That was found by running checkpatch.
Signed-off-by Melike Yurtoglu <[email protected]>
PATCH 3/3 Staging: rtl8723au: Add blank line after declarations
In reply to Melike YurtogluWARNING: "Missing a blank line after declarations"
Add blank line after declarations. That was found by running checkpatch
--- drivers/staging/rtl8723au/os_dep/usb_intf.c | 1 + 1 file changed, 1 insertion(+)
drivers/staging/rtl8723au/os_dep/usb_intf.c +1 -0
@@ -237,6 +237,7 @@ void rtl8723a_usb_intf_stop(struct rtw_adapter *padapter)static void rtw_dev_unload (struct rtw_adapter *padapter) {struct submit_ctx *pack_tx_ops = &padapter->xmitpriv.ack_tx_ops; +RT_TRACE (_module_hci_intfs_c_, _drv_err_, ("+rtw_dev_unload\n" ));if (padapter->bup) {
Signature · 1 line
1.8.3.2
Re: [Outreachy kernel] [PATCH 3/3] Staging: rtl8723au: Add blank line after declarations
Quoted 13 lines · Melike Yurtoglu
WARNING: "Missing a blank line after declarations"
Add blank line after declarations. That was found by running checkpatchSigned-off-by Melike Yurtoglu <[email protected]>--- drivers/staging/rtl8723au/os_dep/usb_intf.c | 1 + 1 file changed, 1 insertion(+)drivers/staging/rtl8723au/os_dep/usb_intf.c +0
-0
drivers/staging/rtl8723au/os_dep/usb_intf.c void rtl8723a_usb_intf_stop(struct rtw_adapter *padapter) · line 243
Quoted 7 lines
drivers/staging/rtl8723au/os_dep/usb_intf.c +1
-0@@ -237,6 +237,7 @@ void rtl8723a_usb_intf_stop(struct rtw_adapter *padapter)static void rtw_dev_unload (struct rtw_adapter *padapter) {struct submit_ctx *pack_tx_ops = &padapter->xmitpriv.ack_tx_ops; +RT_TRACE (_module_hci_intfs_c_, _drv_err_, ("+rtw_dev_unload\n" ));if (padapter->bup) {
It's irrelevant to this change, but you could consider getting rit of RT_TRACE. A use like this at the beginnning or end of a function can just be dropped. A use in error handling code can be converted to netdev_err, etc, as appropriate.
julia
Quoted 13 lines · Melike Yurtoglu
WARNING: quoted string split across lines
That was found by running checkpatch.Signed-off-by Melike Yurtoglu <[email protected]>--- drivers/staging/rtl8723au/os_dep/usb_intf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/staging/rtl8723au/os_dep/usb_intf.c +0
-0
drivers/staging/rtl8723au/os_dep/usb_intf.c static struct dvobj_priv *usb_dvobj_init(struct usb_interface *usb_intf) · line 134
Quoted 7 lines
drivers/staging/rtl8723au/os_dep/usb_intf.c +2
-2@@ -130,8 +130,8 @@ static struct dvobj_priv *usb_dvobj_init(struct usb_interface *usb_intf)usb_endpoint_num (pendp_desc); pdvobjpriv->RtNumInPipes++; }else if (usb_endpoint_is_int_in (pendp_desc)) { - DBG_8723A("usb_endpoint_is_int_in = %x, Interval = " - "%x\n", usb_endpoint_num(pendp_desc), + DBG_8723A("usb_endpoint_is_int_in = %x", + "Interval =%x\n", usb_endpoint_num(pendp_desc),
DBG_8723A could be replaced by standard kernel printing functions.
julia
Quoted 13 lines
drivers/staging/rtl8723au/os_dep/usb_intf.c +0
-1pendp_desc->bInterval); pdvobjpriv->RtInPipe[pdvobjpriv->RtNumInPipes] =usb_endpoint_num (pendp_desc); --1.8.3.2
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1424937128-16981-1-git-send-email-aysemelikeyurtoglu%40gmail.com.
For more options, visit https://groups.google.com/d/optout.
Greg KH
maintainerQuoted 13 lines · Melike Yurtoglu
WARNING: quoted string split across lines
That was found by running checkpatch.Signed-off-by Melike Yurtoglu <[email protected]>--- drivers/staging/rtl8723au/os_dep/usb_intf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/staging/rtl8723au/os_dep/usb_intf.c +0
-0
drivers/staging/rtl8723au/os_dep/usb_intf.c static struct dvobj_priv *usb_dvobj_init(struct usb_interface *usb_intf) · line 134
Quoted 7 lines
drivers/staging/rtl8723au/os_dep/usb_intf.c +2
-2@@ -130,8 +130,8 @@ static struct dvobj_priv *usb_dvobj_init(struct usb_interface *usb_intf)usb_endpoint_num (pendp_desc); pdvobjpriv->RtNumInPipes++; }else if (usb_endpoint_is_int_in (pendp_desc)) { - DBG_8723A("usb_endpoint_is_int_in = %x, Interval = " - "%x\n", usb_endpoint_num(pendp_desc), + DBG_8723A("usb_endpoint_is_int_in = %x", + "Interval =%x\n", usb_endpoint_num(pendp_desc),
That change does not look correct at all, did you compile this?
thanks,
greg k-h