Staging: wlan-ng: coding style ether_addr_copy
PATCH 1/1 Staging: wlan-ng: coding style ether_addr_copy
This fixes the following issues detected by checkpatch.pl:
WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)
--- drivers/staging/wlan-ng/p80211conv.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)
drivers/staging/wlan-ng/p80211conv.c +10 -10
@@ -178,21 +178,21 @@ int skb_ether_to_p80211(wlandevice_t *wlandev, u32 ethconv,switch (wlandev->macmode) {case WLAN_MACMODE_IBSS_STA : -memcpy (p80211_hdr->a3.a1, &e_hdr.daddr,ETH_ALEN ); -memcpy (p80211_hdr->a3.a2, wlandev->netdev->dev_addr,ETH_ALEN ); -memcpy (p80211_hdr->a3.a3, wlandev->bssid,ETH_ALEN ); +ether_addr_copy (p80211_hdr->a3.a1, &e_hdr.daddr); +ether_addr_copy (p80211_hdr->a3.a2, wlandev->netdev->dev_addr); +ether_addr_copy (p80211_hdr->a3.a3, wlandev->bssid);break ;case WLAN_MACMODE_ESS_STA : fc |=cpu_to_le16 (WLAN_SET_FC_TODS (1 )); -memcpy (p80211_hdr->a3.a1, wlandev->bssid,ETH_ALEN ); -memcpy (p80211_hdr->a3.a2, wlandev->netdev->dev_addr,ETH_ALEN ); -memcpy (p80211_hdr->a3.a3, &e_hdr.daddr,ETH_ALEN ); +ether_addr_copy (p80211_hdr->a3.a1, wlandev->bssid); +ether_addr_copy (p80211_hdr->a3.a2, wlandev->netdev->dev_addr); +ether_addr_copy (p80211_hdr->a3.a3, &e_hdr.daddr);break ;case WLAN_MACMODE_ESS_AP : fc |=cpu_to_le16 (WLAN_SET_FC_FROMDS (1 )); -memcpy (p80211_hdr->a3.a1, &e_hdr.daddr,ETH_ALEN ); -memcpy (p80211_hdr->a3.a2, wlandev->bssid,ETH_ALEN ); -memcpy (p80211_hdr->a3.a3, &e_hdr.saddr,ETH_ALEN ); +ether_addr_copy (p80211_hdr->a3.a1, &e_hdr.daddr); +ether_addr_copy (p80211_hdr->a3.a2, wlandev->bssid); +ether_addr_copy (p80211_hdr->a3.a3, &e_hdr.saddr);break ;default : netdev_err(wlandev->netdev,
@@ -241,7 +241,7 @@ static void orinoco_spy_gather(wlandevice_t *wlandev, char *mac,for (i =0 ; i < wlandev->spy_number; i++) {if (!memcmp (wlandev->spy_address[i], mac,ETH_ALEN )) { -memcpy (wlandev->spy_address[i], mac,ETH_ALEN ); +ether_addr_copy (wlandev->spy_address[i], mac); wlandev->spy_stat[i].level = rxmeta->signal; wlandev->spy_stat[i].noise = rxmeta->noise; wlandev->spy_stat[i].qual =
Signature · 1 line
1.9.1
Greg KH
maintainerQuoted 4 lines · Hatice ERT�RK
This fixes the following issues detected by checkpatch.pl:
WARNING: Prefer
ether_addr_copy()overmemcpy()if the Ethernet addresses are__aligned(2)
Are they aligned? Please show some kind of proof in your commit log when you resend this.
thanks,
greg k-h
How do I show proof?
26 Şubat 2015 Perşembe 23:25:09 UTC+2 tarihinde gregkh yazdı:
Quoted 14 lines · Hatice ERTÜRK
Quoted 4 lines
This fixes the following issues detected by checkpatch.pl:
WARNING: Prefer
ether_addr_copy()overmemcpy()if the Ethernet addresses are__aligned(2)Are they aligned? Please show some kind of proof in your commit log when you resend this.
thanks,
greg k-h
Greg KH
maintainerA: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
Quoted 1 line · Hatice ERT�RK
How do I show proof?
If you don't know how to prove this, then please don't make this type of change to the kernel, as it might be wrong.
thanks,
greg k-h