Skip to contentSkip to conversation

staging: vt6656: replace memcpy by ether_addr_copy

PATCH New Aya Mahfouz 1 participant 1 message Feb 27, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 staging: vt6656: replace memcpy by ether_addr_copy

This patch fixes the following checkpatch.pl warning:

Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)

The changes were applied using the following coccinelle rule:
@@ expression e1, e2; @@
- memcpy(e1, e2, ETH_ALEN);
+ ether_addr_copy(e1, e2);

All variables defined in vnt_mac_set_key start at even offsets making the variables aligned to the u16 datatype.

---
v2: adding a missing header

 drivers/staging/vt6656/mac.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/staging/vt6656/mac.c +3 -1
index bb37e33..5dfac05 100644
@@ -30,6 +30,8 @@
  * Revision History:
  */
 
+#include <linux/etherdevice.h>
+
 #include "desc.h"
 #include "mac.h"
 #include "usbpipe.h"
@@ -126,7 +128,7 @@ void vnt_mac_set_keyentry(struct vnt_private *priv, u16 key_ctl, u32 entry_idx,
 	offset += (entry_idx * MISCFIFO_KEYENTRYSIZE);
 
 	set_key.u.write.key_ctl = cpu_to_le16(key_ctl);
-	memcpy(set_key.u.write.addr, addr, ETH_ALEN);
+	ether_addr_copy(set_key.u.write.addr, addr);
 
 	/* swap over swap[0] and swap[1] to get correct write order */
 	swap(set_key.u.swap[0], set_key.u.swap[1]);
Signature · 6 lines
1.9.3


-- 
Kind Regards,
Aya Saif El-yazal Mahfouz