Skip to contentSkip to conversation

mozjs: fix build failure due to failed X11 configure test

PATCH In review Paul Gortmaker 2 participants 4 messages Feb 27, 2015

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 mozjs: fix build failure due to failed X11 configure test

The failure intermittently shows up as follows:

ERROR: This autoconf log indicates errors, it looked at host include and/or library paths while determining system capabilities. Rerun configure task after fixing this. The path was 'poky/build/tmp/work/core2-64-poky-linux/mozjs/17.0.0-r0/build'
ERROR: Function failed: do_qa_configure
ERROR: Logfile of failure stored in: poky/build/tmp/work/core2-64-poky-linux/mozjs/17.0.0-r0/temp/log.do_configure.8047
ERROR: Task 5 (poky/meta-openembedded/meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb, do_configure) failed with exit code '1'

The configure log has:

configure:5494: checking for IceConnectionNumber in -lICE
configure:5513: x86_64-poky-linux-gcc -m64 -march=core2 -mtune=core2 -msse3 -mfpmath=sse --sysroot=poky/build/tmp/sysroots/genericx86-64 -o conftest -O2 -pipe -g -feliminate-unused-debug-types -Wl, -O1 -Wl,--hash-style=gnu -Wl,--as-needed -L/usr/lib conftest.c -lICE 1>&5
poky/build/tmp/sysroots/x86_64-linux/usr/libexec/x86_64-poky-linux/gcc/x86_64-poky-linux/4.9.1/ld: warning: library search path "/usr/lib" is unsafe for cross-compilation

Checking build/config/autoconf.mk we find:

X_CFLAGS = -I/usr/include
X_EXTRA_LIBS =
X_LIBS = -L/usr/lib

Looking at the configure script, we see these invalid values are output when the autoconf test for X11 fails. That test fails in the following fashion:

configure:4768:27: fatal error: X11/Intrinsic.h: No such file or directory

This header in turn gets put in the sysroot by our build of libxt. So we get build fails whenever mozjs is built before libxt.

Aside from the configure test, it doesn't appear that mozjs really has a hard dependency on libxt in order to compile. So we can avoid the problem by simply avoiding the configure test - and here we do that by looking for X11 in the distro features.

---

[apologies if anyone gets this 2x ; the mailing list is misconfigured and
currently operating in subscriber-only mode; someone please fix that.]

[v2: change depends on libxt to distro features solution]

[v1: http://patchwork.openembedded.org/patch/88625/ ]

 meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb | 2 ++
 1 file changed, 2 insertions(+)
meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb +2 -0
index 174f6fe0a89b..0a4cf6b03cc4 100644
@@ -27,6 +27,8 @@ EXTRA_OECONF = " \
     --libdir=${libdir} \
 "
 
+EXTRA_OECONF_X = "${@bb.utils.contains('DISTRO_FEATURES', 'x11', '--with-x', '--without-x', d)}"
+
 # mozjs requires autoreconf 2.13
 do_configure() {
     ${S}/configure ${EXTRA_OECONF}
Signature · 1 line
2.2.1
#1 lore raw
Quoted 52 lines · Paul Gortmaker

The failure intermittently shows up as follows:

ERROR: This autoconf log indicates errors, it looked at host include and/or library paths while determining system capabilities. Rerun configure task after fixing this. The path was 'poky/build/tmp/work/core2-64-poky-linux/mozjs/17.0.0-r0/build'
ERROR: Function failed: do_qa_configure
ERROR: Logfile of failure stored in: poky/build/tmp/work/core2-64-poky-linux/mozjs/17.0.0-r0/temp/log.do_configure.8047
ERROR: Task 5 (poky/meta-openembedded/meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb, do_configure) failed with exit code '1'

The configure log has:

configure:5494: checking for IceConnectionNumber in -lICE
configure:5513: x86_64-poky-linux-gcc -m64 -march=core2 -mtune=core2 -msse3 -mfpmath=sse --sysroot=poky/build/tmp/sysroots/genericx86-64 -o conftest -O2 -pipe -g -feliminate-unused-debug-types -Wl, -O1 -Wl,--hash-style=gnu -Wl,--as-needed -L/usr/lib conftest.c -lICE 1>&5
poky/build/tmp/sysroots/x86_64-linux/usr/libexec/x86_64-poky-linux/gcc/x86_64-poky-linux/4.9.1/ld: warning: library search path "/usr/lib" is unsafe for cross-compilation

Checking build/config/autoconf.mk we find:

X_CFLAGS = -I/usr/include
X_EXTRA_LIBS =
X_LIBS = -L/usr/lib

Looking at the configure script, we see these invalid values are output when the autoconf test for X11 fails. That test fails in the following fashion:

configure:4768:27: fatal error: X11/Intrinsic.h: No such file or directory

This header in turn gets put in the sysroot by our build of libxt. So we get build fails whenever mozjs is built before libxt.

Aside from the configure test, it doesn't appear that mozjs really has a hard dependency on libxt in order to compile. So we can avoid the problem by simply avoiding the configure test - and here we do that by looking for X11 in the distro features.

---

[apologies if anyone gets this 2x ; the mailing list is misconfigured and
currently operating in subscriber-only mode; someone please fix that.]

[v2: change depends on libxt to distro features solution]

[v1: http://patchwork.openembedded.org/patch/88625/ ]

 meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb | 2 ++
 1 file changed, 2 insertions(+)
meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb +0 -0
index 174f6fe0a89b..0a4cf6b03cc4 100644

meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb EXTRA_OECONF = " \ · line 30

Quoted 4 lines
meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb +1 -0
@@ -27,6 +27,8 @@ EXTRA_OECONF = " \
     --libdir=${libdir} \
 "
 
+EXTRA_OECONF_X = "${@bb.utils.contains('DISTRO_FEATURES', 'x11', '--with-x', '--without-x', d)}"

Does it need some extra dependency when enabled?

Why don't you use PACKAGECONFIG for this?

Quoted 11 lines
meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb +0 -0
 # mozjs requires autoreconf 2.13
 do_configure() {
     ${S}/configure ${EXTRA_OECONF}
Signature · 7 lines
2.2.1

-- 
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#2 lore raw
Quoted 56 lines · Martin Jansa
Quoted 55 lines · Paul Gortmaker

The failure intermittently shows up as follows:

ERROR: This autoconf log indicates errors, it looked at host include and/or library paths while determining system capabilities. Rerun configure task after fixing this. The path was 'poky/build/tmp/work/core2-64-poky-linux/mozjs/17.0.0-r0/build'
ERROR: Function failed: do_qa_configure
ERROR: Logfile of failure stored in: poky/build/tmp/work/core2-64-poky-linux/mozjs/17.0.0-r0/temp/log.do_configure.8047
ERROR: Task 5 (poky/meta-openembedded/meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb, do_configure) failed with exit code '1'

The configure log has:

configure:5494: checking for IceConnectionNumber in -lICE
configure:5513: x86_64-poky-linux-gcc -m64 -march=core2 -mtune=core2 -msse3 -mfpmath=sse --sysroot=poky/build/tmp/sysroots/genericx86-64 -o conftest -O2 -pipe -g -feliminate-unused-debug-types -Wl, -O1 -Wl,--hash-style=gnu -Wl,--as-needed -L/usr/lib conftest.c -lICE 1>&5
poky/build/tmp/sysroots/x86_64-linux/usr/libexec/x86_64-poky-linux/gcc/x86_64-poky-linux/4.9.1/ld: warning: library search path "/usr/lib" is unsafe for cross-compilation

Checking build/config/autoconf.mk we find:

X_CFLAGS = -I/usr/include
X_EXTRA_LIBS =
X_LIBS = -L/usr/lib

Looking at the configure script, we see these invalid values are output when the autoconf test for X11 fails. That test fails in the following fashion:

configure:4768:27: fatal error: X11/Intrinsic.h: No such file or directory

This header in turn gets put in the sysroot by our build of libxt. So we get build fails whenever mozjs is built before libxt.

Aside from the configure test, it doesn't appear that mozjs really has a hard dependency on libxt in order to compile. So we can avoid the problem by simply avoiding the configure test - and here we do that by looking for X11 in the distro features.

---

[apologies if anyone gets this 2x ; the mailing list is misconfigured and
currently operating in subscriber-only mode; someone please fix that.]

[v2: change depends on libxt to distro features solution]

[v1: http://patchwork.openembedded.org/patch/88625/ ]

 meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb | 2 ++
 1 file changed, 2 insertions(+)
meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb +0 -0
index 174f6fe0a89b..0a4cf6b03cc4 100644
@@ -27,6 +27,8 @@ EXTRA_OECONF = " \
     --libdir=${libdir} \
 "
 
Quoted 3 lines

meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb EXTRA_OECONF = " \ · line 30

Quoted 1 line
meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb +1 -0
+EXTRA_OECONF_X = "${@bb.utils.contains('DISTRO_FEATURES', 'x11', '--with-x', '--without-x', d)}"

Does it need some extra dependency when enabled?

Not as far as I can tell ; only the libxt thing showed up, and that only happens as a result of configure autotests.

Quoted 2 lines

Why don't you use PACKAGECONFIG for this?

I searched for existing solutions in recipes for X/no-X type problems and found this. And it follows a block of EXTRA_OECONF settings in the recipe that already exist, so I'm not sure why PACKAGECONFIG would be better/advantageous....

P.
--

Quoted 15 lines
Quoted 12 lines
meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb +0 -0
 # mozjs requires autoreconf 2.13
 do_configure() {
     ${S}/configure ${EXTRA_OECONF}
Signature · 7 lines
2.2.1

-- 
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
#3 lore raw
Quoted 65 lines · Paul Gortmaker
Quoted 56 lines · Martin Jansa
Quoted 55 lines · Paul Gortmaker

The failure intermittently shows up as follows:

ERROR: This autoconf log indicates errors, it looked at host include and/or library paths while determining system capabilities. Rerun configure task after fixing this. The path was 'poky/build/tmp/work/core2-64-poky-linux/mozjs/17.0.0-r0/build'
ERROR: Function failed: do_qa_configure
ERROR: Logfile of failure stored in: poky/build/tmp/work/core2-64-poky-linux/mozjs/17.0.0-r0/temp/log.do_configure.8047
ERROR: Task 5 (poky/meta-openembedded/meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb, do_configure) failed with exit code '1'

The configure log has:

configure:5494: checking for IceConnectionNumber in -lICE
configure:5513: x86_64-poky-linux-gcc -m64 -march=core2 -mtune=core2 -msse3 -mfpmath=sse --sysroot=poky/build/tmp/sysroots/genericx86-64 -o conftest -O2 -pipe -g -feliminate-unused-debug-types -Wl, -O1 -Wl,--hash-style=gnu -Wl,--as-needed -L/usr/lib conftest.c -lICE 1>&5
poky/build/tmp/sysroots/x86_64-linux/usr/libexec/x86_64-poky-linux/gcc/x86_64-poky-linux/4.9.1/ld: warning: library search path "/usr/lib" is unsafe for cross-compilation

Checking build/config/autoconf.mk we find:

X_CFLAGS = -I/usr/include
X_EXTRA_LIBS =
X_LIBS = -L/usr/lib

Looking at the configure script, we see these invalid values are output when the autoconf test for X11 fails. That test fails in the following fashion:

configure:4768:27: fatal error: X11/Intrinsic.h: No such file or directory

This header in turn gets put in the sysroot by our build of libxt. So we get build fails whenever mozjs is built before libxt.

Aside from the configure test, it doesn't appear that mozjs really has a hard dependency on libxt in order to compile. So we can avoid the problem by simply avoiding the configure test - and here we do that by looking for X11 in the distro features.

---

[apologies if anyone gets this 2x ; the mailing list is misconfigured and
currently operating in subscriber-only mode; someone please fix that.]

[v2: change depends on libxt to distro features solution]

[v1: http://patchwork.openembedded.org/patch/88625/ ]

 meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb | 2 ++
 1 file changed, 2 insertions(+)
meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb +0 -0
index 174f6fe0a89b..0a4cf6b03cc4 100644
@@ -27,6 +27,8 @@ EXTRA_OECONF = " \
     --libdir=${libdir} \
 "
 
Quoted 3 lines

meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb EXTRA_OECONF = " \ · line 30

Quoted 1 line
meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb +1 -0
+EXTRA_OECONF_X = "${@bb.utils.contains('DISTRO_FEATURES', 'x11', '--with-x', '--without-x', d)}"

Does it need some extra dependency when enabled?

Not as far as I can tell ; only the libxt thing showed up, and that only happens as a result of configure autotests.

Quoted 1 line
Quoted 6 lines
Quoted 1 line

Why don't you use PACKAGECONFIG for this?

I searched for existing solutions in recipes for X/no-X type problems and found this. And it follows a block of EXTRA_OECONF settings in the recipe that already exist, so I'm not sure why PACKAGECONFIG would be better/advantageous....

Because it's newer common solution for this kind of configuration and allows to easily adjust it on per-recipe basis (e.g. from distro config).

Quoted 20 lines
Quoted 15 lines
Quoted 12 lines
meta-oe/recipes-extended/mozjs/mozjs_17.0.0.bb +0 -0
 # mozjs requires autoreconf 2.13
 do_configure() {
     ${S}/configure ${EXTRA_OECONF}
Signature · 7 lines
2.2.1

-- 
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 4 lines
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]