Skip to contentSkip to conversation

Staging: rtl8188eu: Change return type of function to void

PATCH In review Vatika Harlalka 2 participants 3 messages Feb 27, 2015 – Mar 2, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: rtl8188eu: Change return type of function to void

Return is made void as the function is only called once where its return value is not used.

---
 drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/rtl8188eu/hal/bb_cfg.c +1 -2
index baebe35..0fad714 100644
@@ -398,7 +398,7 @@ static void rtl_bb_delay(struct adapter *adapt, u32 addr, u32 data)
 	}
 }
 
-static bool set_baseband_phy_config(struct adapter *adapt)
+static void set_baseband_phy_config(struct adapter *adapt)
 {
 	u32 i;
 	u32 arraylen = sizeof(array_phy_reg_1t_8188e)/sizeof(u32);
@@ -411,7 +411,6 @@ static bool set_baseband_phy_config(struct adapter *adapt)
 		if (v1 < 0xCDCDCDCD)
 			rtl_bb_delay(adapt, v1, v2);
 	}
-	return true;
 }
 
 /*  PHY_REG_PG.TXT  */
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 7 lines · Vatika Harlalka

Return is made void as the function is only called once where its return value is not used.

---
 drivers/staging/rtl8188eu/hal/bb_cfg.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

All of your patches for this driver seem to be dependant on the previous patch, and I don't know what order to apply them in.

So please resend all of them, in an ordered list of patches, so I have a chance to get them correct.

thanks,

greg k-h

#2 lore raw

I have sent a combined patchset for the patches from this driver which were not applied.
I'm sorry for the confusion caused!