Skip to contentSkip to conversation

ARM: dts: OMAP5: fix polling intervals for thermal zones

PATCH New Tero Kristo 3 participants 3 messages Feb 27, 2015 – Mar 6, 2015 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: OMAP5: fix polling intervals for thermal zones

OMAP4 has a finer counter granularity, which allows for a delay of 1000ms in the thermal zone polling intervals. OMAP5 has a different counter mechanism, which allows at maximum a 500ms timer. Adjust the cpu thermal zone polling interval accordingly.

Without this patch, the polling interval information is simply ignored, and the following thermal warnings are printed during boot (assuming thermal is enabled);

[    1.545343] ti-soc-thermal 4a0021e0.bandgap: Delay 1000 ms is not supported
[    1.552691] ti-soc-thermal 4a0021e0.bandgap: Delay 1000 ms is not supported
[    1.560029] ti-soc-thermal 4a0021e0.bandgap: Delay 1000 ms is not supported
---
 arch/arm/boot/dts/omap5-core-thermal.dtsi |    2 +-
 arch/arm/boot/dts/omap5-gpu-thermal.dtsi  |    2 +-
 arch/arm/boot/dts/omap5.dtsi              |    4 ++++
 3 files changed, 6 insertions(+), 2 deletions(-)
arch/arm/boot/dts/omap5-core-thermal.dtsi +1 -1
index 19212ac..de8a3d4 100644
@@ -13,7 +13,7 @@
 
 core_thermal: core_thermal {
 	polling-delay-passive = <250>; /* milliseconds */
-	polling-delay = <1000>; /* milliseconds */
+	polling-delay = <500>; /* milliseconds */
 
 			/* sensor       ID */
 	thermal-sensors = <&bandgap     2>;
arch/arm/boot/dts/omap5-gpu-thermal.dtsi +1 -1
index 1b87aca..bc3090f 100644
@@ -13,7 +13,7 @@
 
 gpu_thermal: gpu_thermal {
 	polling-delay-passive = <250>; /* milliseconds */
-	polling-delay = <1000>; /* milliseconds */
+	polling-delay = <500>; /* milliseconds */
 
 			/* sensor       ID */
 	thermal-sensors = <&bandgap     1>;
arch/arm/boot/dts/omap5.dtsi +4 -0
index b321fdf..fee1580 100644
@@ -1079,4 +1079,8 @@
 	};
 };
 
+&cpu_thermal {
+	polling-delay = <500>; /* milliseconds */
+};
+
 /include/ "omap54xx-clocks.dtsi"
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 ARM: dts: OMAP5: fix polling intervals for thermal zones

Quoted 9 lines · Tero Kristo

OMAP4 has a finer counter granularity, which allows for a delay of 1000ms in the thermal zone polling intervals. OMAP5 has a different counter mechanism, which allows at maximum a 500ms timer. Adjust the cpu thermal zone polling interval accordingly.

Without this patch, the polling interval information is simply ignored, and the following thermal warnings are printed during boot (assuming thermal is enabled);

Quoted 6 lines
[    1.545343] ti-soc-thermal 4a0021e0.bandgap: Delay 1000 ms is not supported
[    1.552691] ti-soc-thermal 4a0021e0.bandgap: Delay 1000 ms is not supported
[    1.560029] ti-soc-thermal 4a0021e0.bandgap: Delay 1000 ms is not supported
Quoted 52 lines
---
 arch/arm/boot/dts/omap5-core-thermal.dtsi |    2 +-
 arch/arm/boot/dts/omap5-gpu-thermal.dtsi  |    2 +-
 arch/arm/boot/dts/omap5.dtsi              |    4 ++++
 3 files changed, 6 insertions(+), 2 deletions(-)
arch/arm/boot/dts/omap5-core-thermal.dtsi +1 -1
index 19212ac..de8a3d4 100644
@@ -13,7 +13,7 @@
 
 core_thermal: core_thermal {
 	polling-delay-passive = <250>; /* milliseconds */
-	polling-delay = <1000>; /* milliseconds */
+	polling-delay = <500>; /* milliseconds */
 
 			/* sensor       ID */
 	thermal-sensors = <&bandgap     2>;
arch/arm/boot/dts/omap5-gpu-thermal.dtsi +1 -1
index 1b87aca..bc3090f 100644
@@ -13,7 +13,7 @@
 
 gpu_thermal: gpu_thermal {
 	polling-delay-passive = <250>; /* milliseconds */
-	polling-delay = <1000>; /* milliseconds */
+	polling-delay = <500>; /* milliseconds */
 
 			/* sensor       ID */
 	thermal-sensors = <&bandgap     1>;
arch/arm/boot/dts/omap5.dtsi +4 -0
index b321fdf..fee1580 100644
@@ -1079,4 +1079,8 @@
 	};
 };
 
+&cpu_thermal {
+	polling-delay = <500>; /* milliseconds */
+};
+
 /include/ "omap54xx-clocks.dtsi"
Signature · 6 lines
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150227/f7f0af19/attachment.sig>

#2 lore raw

PATCH 1/1 ARM: dts: OMAP5: fix polling intervals for thermal zones

Quoted 10 lines · Eduardo Valentin
Quoted 9 lines · Tero Kristo

OMAP4 has a finer counter granularity, which allows for a delay of 1000ms in the thermal zone polling intervals. OMAP5 has a different counter mechanism, which allows at maximum a 500ms timer. Adjust the cpu thermal zone polling interval accordingly.

Without this patch, the polling interval information is simply ignored, and the following thermal warnings are printed during boot (assuming thermal is enabled);

Quoted 8 lines
Quoted 6 lines
[    1.545343] ti-soc-thermal 4a0021e0.bandgap: Delay 1000 ms is not supported
[    1.552691] ti-soc-thermal 4a0021e0.bandgap: Delay 1000 ms is not supported
[    1.560029] ti-soc-thermal 4a0021e0.bandgap: Delay 1000 ms is not supported

Applying into omap-for-v4.0/fixes thanks.

Tony