Skip to contentSkip to conversation

Staging: Octeon USB: Fix space prohibited between function name and open parenthesis

PATCH In review Sean Darcy 2 participants 2 messages Feb 28, 2015 Staging

lore
Share & tools
lore

Sean Darcy

author
#0 lore raw

PATCH 1/1 Staging: Octeon USB: Fix space prohibited between function name and open parenthesis

This patch fixes the following checkpatch.pl warning in drivers/staging/octeon-usb/octeon-hcd.c
WARNING: space prohibited between function name and open parenthesis '('

---
 drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/octeon-usb/octeon-hcd.c +1 -1
index 1daeb31..0408a12 100644
@@ -412,7 +412,7 @@ struct octeon_hcd {
 		type c;							    \
 		while (1) {						    \
 			c.u32 = __cvmx_usb_read_csr32(usb, address);	    \
-			if (c.s.field op (value)) {			    \
+			if (c.s.field op(value)) {			    \
 				result = 0;				    \
 				break;					    \
 			} else if (cvmx_get_cycle() > done) {		    \
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 13 lines · Sean Darcy

This patch fixes the following checkpatch.pl warning in drivers/staging/octeon-usb/octeon-hcd.c
WARNING: space prohibited between function name and open parenthesis '('

---
 drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/octeon-usb/octeon-hcd.c +0 -0
index 1daeb31..0408a12 100644

drivers/staging/octeon-usb/octeon-hcd.c struct octeon_hcd { · line 415

Quoted 5 lines
drivers/staging/octeon-usb/octeon-hcd.c +1 -1
@@ -412,7 +412,7 @@ struct octeon_hcd {
 		type c;							    \
 		while (1) {						    \
 			c.u32 = __cvmx_usb_read_csr32(usb, address);	    \
-			if (c.s.field op (value)) {			    \
+			if (c.s.field op(value)) {			    \

This isn't a "real" function, and I don't think this change will build properly. Did you test it?

thanks,

greg k-h