Skip to contentSkip to conversation

clkdev: clk_add_alias don't put origin clock

PATCH In review Yoshinori Sato 2 participants 3 messages Mar 1, 2015 – Mar 3, 2015 Arm/clkdev support

lore
Share & tools
lore

Yoshinori Sato

author
#0 lore raw

PATCH 1/1 clkdev: clk_add_alias don't put origin clock

Refer to 'r' later.
So don't put in clk_add_alias.

Signed-off-by Yoshinori Sato <[email protected]>
---
 drivers/clk/clkdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/clkdev.c +1 -1
index 043fd36..fddb999 100644
@@ -318,7 +318,6 @@ int clk_add_alias(const char *alias, const char *alias_dev_name, char *id,
 		return PTR_ERR(r);
 
 	l = clkdev_alloc(r, alias, alias_dev_name);
-	clk_put(r);
 	if (!l)
 		return -ENODEV;
 	clkdev_add(l);

@@ -334,6 +333,7 @@ void clkdev_drop(struct clk_lookup *cl)
 	mutex_lock(&clocks_mutex);
 	list_del(&cl->node);
 	mutex_unlock(&clocks_mutex);
+	clk_put(cl->clk);
 	kfree(cl);
 }
 EXPORT_SYMBOL(clkdev_drop);
Signature · 1 line
2.1.4
#1 lore raw
Quoted 4 lines · Yoshinori Sato

Refer to 'r' later.
So don't put in clk_add_alias.

Signed-off-by Yoshinori Sato <[email protected]>

This isn't how I want to solve this. I'd much rather we converted clkdev to use struct clk_hw internally instead. This is something I'm looking into at the moment.

Signature · 2 lines
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
author
#2 lore raw

At Sun, 1 Mar 2015 14:51:57 +0000,

Quoted 11 lines · Russell King - ARM Linux
Quoted 4 lines · Yoshinori Sato

Refer to 'r' later.
So don't put in clk_add_alias.

Signed-off-by Yoshinori Sato <[email protected]>

This isn't how I want to solve this. I'd much rather we converted clkdev to use struct clk_hw internally instead. This is something I'm looking into at the moment.

OK.
It's checked a little more.

Thanks.

Quoted 3 lines
Signature · 2 lines
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
Signature · 2 lines
Yoshinori Sato
<[email protected]>