Staging: lustre: Fix externs should be avoided in .c

PATCH RESEND In review Haneen Mohammed 2 participants 2 messages Mar 1, 2015 – Mar 2, 2015 Staging

Share & tools

Haneen Mohammed

author

2015-03-01 23:53 UTC #0 lore raw

PATCH RESEND 1/1 Staging: lustre: Fix externs should be avoided in .c

This patch moves extern declaration to ldlm_internal.h. Remove prototype from ldlm_lockd.c and ldlm_lock.c. Issue addressed by checkpatch.pl.

Signed-off-by Haneen Mohammed <[email protected]>

---
 drivers/staging/lustre/lustre/ldlm/ldlm_internal.h | 4 ++++
 drivers/staging/lustre/lustre/ldlm/ldlm_lock.c     | 2 --
 drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c    | 2 --
 3 files changed, 4 insertions(+), 4 deletions(-)

drivers/staging/lustre/lustre/ldlm/ldlm_internal.h +4 -0

index 17271b0..5bf9488 100644
@@ -177,6 +177,10 @@ int ldlm_bl_to_thread_list(struct ldlm_namespace *ns,
 void ldlm_handle_bl_callback(struct ldlm_namespace *ns,
 			     struct ldlm_lock_desc *ld, struct ldlm_lock *lock);
 
+extern struct kmem_cache *ldlm_resource_slab;
+
+/* ldlm_lockd.c & ldlm_lock.c */
+extern struct kmem_cache *ldlm_lock_slab;
 
 /* ldlm_extent.c */
 void ldlm_extent_add_lock(struct ldlm_resource *res, struct ldlm_lock *lock);

drivers/staging/lustre/lustre/ldlm/ldlm_lock.c +0 -2

index d7fa934..84b111e 100644
@@ -151,8 +151,6 @@ char *ldlm_it2str(int it)
 }
 EXPORT_SYMBOL(ldlm_it2str);
 
-extern struct kmem_cache *ldlm_lock_slab;
-
 
 void ldlm_register_intent(struct ldlm_namespace *ns, ldlm_res_policy arg)
 {

drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c +0 -2

index 98fbd3f..e0a8157 100644
@@ -55,8 +55,6 @@ static char *ldlm_cpts;
 module_param(ldlm_cpts, charp, 0444);
 MODULE_PARM_DESC(ldlm_cpts, "CPU partitions ldlm threads should run on");
 
-extern struct kmem_cache *ldlm_resource_slab;
-extern struct kmem_cache *ldlm_lock_slab;
 static struct mutex	ldlm_ref_mutex;
 static int ldlm_refcount;

Signature · 1 line

1.9.1

Greg KH

maintainer

2015-03-02 00:56 UTC #1 lore raw

Quoted 10 lines · Haneen Mohammed

This patch moves extern declaration to ldlm_internal.h. Remove prototype from ldlm_lockd.c and ldlm_lock.c. Issue addressed by checkpatch.pl.
Signed-off-by Haneen Mohammed <[email protected]>
---
 drivers/staging/lustre/lustre/ldlm/ldlm_internal.h | 4 ++++
 drivers/staging/lustre/lustre/ldlm/ldlm_lock.c     | 2 --
 drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c    | 2 --
 3 files changed, 4 insertions(+), 4 deletions(-)

What changed here as well?

Why resend?