Skip to contentSkip to conversation

x86: svm: use kvm_fast_pio_in()

PATCH In review Joel Schopp 2 participants 3 messages Feb 28, 2015 – Mar 2, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 x86: svm: use kvm_fast_pio_in()

From: David Kaplan <[email protected]>

We can make the in instruction go faster the same way the out instruction is already.

[extracted from larger unlrelated patch, forward ported, tested]
---
 arch/x86/kvm/svm.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
arch/x86/kvm/svm.c +3 -1
index d319e0c..f8c906b 100644
@@ -1899,7 +1899,7 @@ static int io_interception(struct vcpu_svm *svm)
 	++svm->vcpu.stat.io_exits;
 	string = (io_info & SVM_IOIO_STR_MASK) != 0;
 	in = (io_info & SVM_IOIO_TYPE_MASK) != 0;
-	if (string || in)
+	if (string)
 		return emulate_instruction(vcpu, 0) == EMULATE_DONE;
 
 	port = io_info >> 16;
@@ -1907,6 +1907,8 @@ static int io_interception(struct vcpu_svm *svm)
 	svm->next_rip = svm->vmcb->control.exit_info_2;
 	skip_emulated_instruction(&svm->vcpu);
 
+	if (in)
+		return kvm_fast_pio_in(vcpu, size, port);
 	return kvm_fast_pio_out(vcpu, size, port);
 }
 
#1 lore raw

2015-02-27 18:04-0600, Joel Schopp:

Quoted 14 lines

From: David Kaplan <[email protected]>

We can make the in instruction go faster the same way the out instruction is already.

[extracted from larger unlrelated patch, forward ported, tested]
---
 arch/x86/kvm/svm.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

arch/x86/kvm/svm.c static int io_interception(struct vcpu_svm *svm) · line 1911

Quoted 5 lines
arch/x86/kvm/svm.c +2 -0
@@ -1907,6 +1907,8 @@ static int io_interception(struct vcpu_svm *svm)
 	svm->next_rip = svm->vmcb->control.exit_info_2;
 	skip_emulated_instruction(&svm->vcpu);
 
+	if (in)
+		return kvm_fast_pio_in(vcpu, size, port);

Have I missed a patch that defined kvm_fast_pio_in()?

Thanks.

#2 lore raw
Quoted 4 lines

arch/x86/kvm/svm.c static int io_interception(struct vcpu_svm *svm) · line 1911

Quoted 3 lines
arch/x86/kvm/svm.c +2 -0
+	if (in)
+		return kvm_fast_pio_in(vcpu, size, port);

Have I missed a patch that defined kvm_fast_pio_in()?

Not sure how I managed to leave out the bulk of the patch. Resending v2 momentarily.