Skip to contentSkip to conversation

perl: needs host-bison

PATCH New Gustavo Zacarias 2 participants 6 messages Mar 3, 2015 – Mar 4, 2015

lore
Share & tools
lore

Gustavo Zacarias

author
#0 lore raw

PATCH 1/1 perl: needs host-bison

It's from last bump, fixes:
http://autobuild.buildroot.net/results/1c2/1c261b09f5a4a314d5dcbc1e5811af9c7d18658a/

Signed-off-by Gustavo Zacarias <[email protected]>
---
 package/perl/perl.mk | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
package/perl/perl.mk +4 -3
index 0636aba..81e6275 100644
@@ -8,6 +8,7 @@ PERL_VERSION_MAJOR = 20
 PERL_VERSION = 5.$(PERL_VERSION_MAJOR).2
 PERL_SITE = http://www.cpan.org/src/5.0
 PERL_SOURCE = perl-$(PERL_VERSION).tar.bz2
+PERL_DEPENDENCIES = host-bison
 PERL_LICENSE = Artistic or GPLv1+
 PERL_LICENSE_FILES = Artistic Copying README
 PERL_INSTALL_STAGING = YES

@@ -88,7 +89,7 @@ define PERL_CONFIGURE_CMDS
 endef
 
 define PERL_BUILD_CMDS
-	$(MAKE1) -C $(@D) all
+	PATH=$(BR_PATH) $(MAKE1) -C $(@D) all
 endef
 
 define PERL_INSTALL_STAGING_CMDS

@@ -101,7 +102,7 @@ endef
 
 # We never want to have host-berkeleydb or host-gdbm as dependencies
 # of host-perl.
-HOST_PERL_DEPENDENCIES =
+HOST_PERL_DEPENDENCIES = host-bison
 
 HOST_PERL_CONF_OPTS = \
 	-des \

@@ -113,7 +114,7 @@ define HOST_PERL_CONFIGURE_CMDS
 endef
 
 define HOST_PERL_BUILD_CMDS
-	$(MAKE) -C $(@D)
+	PATH=$(BR_PATH) $(MAKE) -C $(@D)
 endef
 
 define HOST_PERL_INSTALL_CMDS
Signature · 1 line
2.0.5
#1 lore raw

PATCH 1/1 perl: needs host-bison

Dear Gustavo Zacarias,

package/perl/perl.mk define PERL_CONFIGURE_CMDS · line 92

Quoted 3 lines · Gustavo Zacarias

define PERL_BUILD_CMDS

package/perl/perl.mk +1 -1
-	$(MAKE1) -C $(@D) all
+	PATH=$(BR_PATH) $(MAKE1) -C $(@D) all

Use $(TARGET_MAKE_ENV) instead.

package/perl/perl.mk define HOST_PERL_CONFIGURE_CMDS · line 117

Quoted 3 lines

define HOST_PERL_BUILD_CMDS

package/perl/perl.mk +1 -1
-	$(MAKE) -C $(@D)
+	PATH=$(BR_PATH) $(MAKE) -C $(@D)

and $(HOST_MAKE_ENV).

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 perl: needs host-bison

Quoted 10 lines · Thomas Petazzoni

Dear Gustavo Zacarias,

package/perl/perl.mk define PERL_CONFIGURE_CMDS · line 92

Quoted 3 lines · Gustavo Zacarias

define PERL_BUILD_CMDS

package/perl/perl.mk +1 -1
-	$(MAKE1) -C $(@D) all
+	PATH=$(BR_PATH) $(MAKE1) -C $(@D) all

Use $(TARGET_MAKE_ENV) instead.

Quoted 5 lines

package/perl/perl.mk define HOST_PERL_CONFIGURE_CMDS · line 117

Quoted 3 lines

define HOST_PERL_BUILD_CMDS

package/perl/perl.mk +1 -1
-	$(MAKE) -C $(@D)
+	PATH=$(BR_PATH) $(MAKE) -C $(@D)

and $(HOST_MAKE_ENV).

For TARGET_MAKE_ENV maybe since it's only PATH, for HOST_MAKE_ENV it's not and it'll need extra testing to see that perl's build system doesn't fluke with the extras.
So splitting between BR_PATH and TARGET_MAKE_ENV is possible but not visually consistent.
Which begs the question: why do other packages use BR_PATH in the same way as well? (without using *_MAKE_ENV)
Regards.

#3 lore raw

PATCH 1/1 perl: needs host-bison

Dear Gustavo Zacarias,

Quoted 3 lines · Gustavo Zacarias

For TARGET_MAKE_ENV maybe since it's only PATH, for HOST_MAKE_ENV it's not and it'll need extra testing to see that perl's build system doesn't fluke with the extras.

Worth trying IMO.

Quoted 4 lines

So splitting between BR_PATH and TARGET_MAKE_ENV is possible but not visually consistent.
Which begs the question: why do other packages use BR_PATH in the same way as well? (without using *_MAKE_ENV)

Because they should be using *_MAKE_ENV :-)

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#4 lore raw

PATCH 1/1 perl: needs host-bison

Quoted 5 lines · Thomas Petazzoni
Quoted 3 lines

For TARGET_MAKE_ENV maybe since it's only PATH, for HOST_MAKE_ENV it's not and it'll need extra testing to see that perl's build system doesn't fluke with the extras.

Worth trying IMO.

Ehmm, i wouldn't want to touch much of the perl package with a 10-foot pole, it's not my thing any more.
I've just conjured a quick fix to get rid of some redness in the autobuilders (also it requires me to chroot and i don't like bare minimal chroots!).

Quoted 1 line

Because they should be using *_MAKE_ENV :-)

Fair enough.
Regards.

#5 lore raw

PATCH 1/1 perl: needs host-bison

In reply to Gustavo Zacarias

Dear Gustavo Zacarias,

Quoted 4 lines · Gustavo Zacarias

It's from last bump, fixes:
http://autobuild.buildroot.net/results/1c2/1c261b09f5a4a314d5dcbc1e5811af9c7d18658a/

Signed-off-by Gustavo Zacarias <[email protected]>

I've applied Fran?ois fix instead:
http://git.buildroot.net/buildroot/commit/?id=8a4c8deee9af6fa1a1e906c52d7d49a32434464c.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com