Skip to contentSkip to conversation

Fix barebox compilation issue with 64bit kernel

PATCH New Lahoudere Fabien 2 participants 3 messages Mar 3, 2015

lore
Share & tools
lore

Lahoudere Fabien

author
#0 lore raw

PATCH 1/1 Fix barebox compilation issue with 64bit kernel

Signed-off-by Lahoudere Fabien <[email protected]>
---
 boot/barebox/barebox.mk | 2 ++
 1 file changed, 2 insertions(+)
boot/barebox/barebox.mk +2 -0
index 0fb7cec..626ff9a 100644
@@ -41,6 +41,8 @@ endif
 
 ifeq ($(KERNEL_ARCH),i386)
 BAREBOX_ARCH = x86
+else ifeq ($(KERNEL_ARCH),x86_64)
+BAREBOX_ARCH = x86
 else ifeq ($(KERNEL_ARCH),powerpc)
 BAREBOX_ARCH = ppc
 else
Signature · 1 line
2.1.4
#1 lore raw

PATCH 1/1 Fix barebox compilation issue with 64bit kernel

Dear Lahoudere Fabien,

Quoted 1 line · Lahoudere Fabien
Signed-off-by Lahoudere Fabien <[email protected]>

This should normally be:

Signed-off-by <first name> <last name> <email>
Quoted 3 lines
---
 boot/barebox/barebox.mk | 2 ++
 1 file changed, 2 insertions(+)

This looks good but the commit log could be improved:

barebox: fix compilation on x86-64 architecture

Barebox uses KERNEL_ARCH to derive BAREBOX_ARCH, but doesn't currently handle the case of the x86-64 architecture. In this case KERNEL_ARCH is x86_64, but BAREBOX_ARCH should be x86 nonetheless.

The commit title should almost always look like:

<pkg>: <description>

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 Fix barebox compilation issue with 64bit kernel

Hello

Thank you for the correction.
I will rework my patch but I have questions:
- If I change the title, and submit a new patch, what happened to the old one in the patchwork?
- Is it necessary to prefix the new title with "PATCH v2"?

Fabien

Le 03/03/2015 14:31, Thomas Petazzoni a ?crit :

Quoted 27 lines

Dear Lahoudere Fabien,

Quoted 1 line · Lahoudere Fabien
Signed-off-by Lahoudere Fabien <[email protected]>

This should normally be:

Signed-off-by <first name> <last name> <email>
Quoted 3 lines
---
  boot/barebox/barebox.mk | 2 ++
  1 file changed, 2 insertions(+)

This looks good but the commit log could be improved:

barebox: fix compilation on x86-64 architecture

Barebox uses KERNEL_ARCH to derive BAREBOX_ARCH, but doesn't currently handle the case of the x86-64 architecture. In this case KERNEL_ARCH is x86_64, but BAREBOX_ARCH should be x86 nonetheless.

The commit title should almost always look like:

<pkg>: <description>

Thanks,

Thomas