Skip to contentSkip to conversation

parent/child hierarchy for regulator

DISCUSSION Peter Chen 3 participants 6 messages Mar 5, 2015 – Mar 6, 2015

lore
Share & tools
lore

Peter Chen

author
#0 lore raw

Hi lists,

Any good ways at code/dts to show parent/child hierarchy for regulator?

The related regulators at my platforms like below:
PMIC (SWB 5v) --> Switch Chip (GPIO Regulator) --> USB VBUS

PMIC has one 5V regulator (eg, swbst at pfuse), and it is the input for USB power switch chip, and there are two gpios at this switch chip to control if 5V is output or not, we register these two gpios as fixed regulators, currently, if regulator swbst is disabled, the gpio regulator has no way to know, and cause the vbus voltage is wrong.

Thanks in advance.

Signature · 2 lines
Best Regards,
Peter Chen
#1 lore raw

Hi Peter,

Am 05.03.2015 um 11:35 schrieb Peter Chen:

Quoted 7 lines

Hi lists,

Any good ways at code/dts to show parent/child hierarchy for regulator?

The related regulators at my platforms like below:
PMIC (SWB 5v) --> Switch Chip (GPIO Regulator) --> USB VBUS

Quoted 8 lines

PMIC has one 5V regulator (eg, swbst at pfuse), and it is the input for USB power switch chip, and there are two gpios at this switch chip to control if 5V is output or not, we register these two gpios as fixed regulators, currently, if regulator swbst is disabled, the gpio regulator has no way to know, and cause the vbus voltage is wrong.

Thanks in advance.

i don't have an answer to your question, but do you think of i.MX28 platform?

Regards
Stefan

author
#2 lore raw
Quoted 16 lines · Stefan Wahren

Hi Peter,

Am 05.03.2015 um 11:35 schrieb Peter Chen:

Quoted 13 lines

Hi lists,

Any good ways at code/dts to show parent/child hierarchy for regulator?

The related regulators at my platforms like below:
PMIC (SWB 5v) --> Switch Chip (GPIO Regulator) --> USB VBUS

PMIC has one 5V regulator (eg, swbst at pfuse), and it is the input for USB power switch chip, and there are two gpios at this switch chip to control if 5V is output or not, we register these two gpios as fixed regulators, currently, if regulator swbst is disabled, the gpio regulator has no way to know, and cause the vbus voltage is wrong.

Quoted 6 lines
Quoted 2 lines

Thanks in advance.

i don't have an answer to your question, but do you think of i.MX28 platform?

No, many Freescale i.mx6 SDB boards need to consider this problem.

Signature · 2 lines
Best Regards,
Peter Chen
#3 lore raw
In reply to Peter Chen
Quoted 1 line · Peter Chen

Any good ways at code/dts to show parent/child hierarchy for regulator?

There's plenty of examples in mainline...

Quoted 8 lines

The related regulators at my platforms like below:
PMIC (SWB 5v) --> Switch Chip (GPIO Regulator) --> USB VBUS

PMIC has one 5V regulator (eg, swbst at pfuse), and it is the input for USB power switch chip, and there are two gpios at this switch chip to control if 5V is output or not, we register these two gpios as fixed regulators, currently, if regulator swbst is disabled, the gpio regulator has no way to know, and cause the vbus voltage is wrong.

Can you please clarify why you're registering two fixed voltage
regulators for the switch chip and how you're doing that? The picture
above looks like you should just have a single regulator there and
nothing should care if the either regulator is enabled when querying the
parent for its voltage.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150305/26fbd73b/attachment.sig>

author
#4 lore raw
Quoted 6 lines · Mark Brown
Quoted 1 line · Peter Chen

Any good ways at code/dts to show parent/child hierarchy for regulator?

There's plenty of examples in mainline...

thanks, I am back to study again.

Quoted 11 lines
Quoted 8 lines

The related regulators at my platforms like below:
PMIC (SWB 5v) --> Switch Chip (GPIO Regulator) --> USB VBUS

PMIC has one 5V regulator (eg, swbst at pfuse), and it is the input for USB power switch chip, and there are two gpios at this switch chip to control if 5V is output or not, we register these two gpios as fixed regulators, currently, if regulator swbst is disabled, the gpio regulator has no way to know, and cause the vbus voltage is wrong.

Can you please clarify why you're registering two fixed voltage regulators for the switch chip and how you're doing that?

Two fixed regulators for two USB vbus, there are no relationships beween them, but both of them needs PMIC 5V (swbst at pfuse) to be enabled.

Quoted 4 lines

The picture
above looks like you should just have a single regulator there and nothing should care if the either regulator is enabled when querying the parent for its voltage.

I need to care about its parent's status, currently, the usb code does not consider parent regulator, so after below patch, the voltage of vbus is incorrect, due to parent regulator is disabled after boots up, there is no user for this parent regulator.

commit a6dcf9782f99a0d844b4d06f65cc990468424068

Author: Sean Cross <[email protected]>
Date:   Mon May 26 16:45:40 2014 +0800

regulator: pfuze100: Support SWB enable/disable

The SWB regulators have the ability to be turned on and off. Add enable/disable support for these regulators.

Signature · 2 lines
Best Regards,
Peter Chen
author
#5 lore raw
In reply to Mark Brown
Quoted 6 lines · Mark Brown
Quoted 1 line · Peter Chen

Any good ways at code/dts to show parent/child hierarchy for regulator?

There's plenty of examples in mainline...

Thanks, I get answer for adding parent regulator for fixed regulator, it is very easy, we only need to add 'vin-supply = <&parent_reg>;' at fixed's property.

Signature · 2 lines
Best Regards,
Peter Chen