ax25: remove unneeded NULL test in ax_xmit()

PATCH Applied Dan Carpenter 2 participants 2 messages Mar 5, 2015 – Mar 6, 2015

Subsystems (3)

Networking Network drivers Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2015-03-05 17:48 UTC #0 lore raw

PATCH 1/1 ax25: remove unneeded NULL test in ax_xmit()

We get a static checker warning here on devel kernels:

	drivers/net/hamradio/mkiss.c:560 ax_xmit()
	warn: variable dereferenced before check 'skb' (see line 532)

It turns out that the NULL check can be deleted.

Signed-off-by Dan Carpenter <[email protected]>

drivers/net/hamradio/mkiss.c +3 -5

index 17058c4..2ffbf13 100644
@@ -557,11 +557,9 @@ static netdev_tx_t ax_xmit(struct sk_buff *skb, struct net_device *dev)
 	}
 
 	/* We were not busy, so we are now... :-) */
-	if (skb != NULL) {
-		netif_stop_queue(dev);
-		ax_encaps(dev, skb->data, skb->len);
-		kfree_skb(skb);
-	}
+	netif_stop_queue(dev);
+	ax_encaps(dev, skb->data, skb->len);
+	kfree_skb(skb);
 
 	return NETDEV_TX_OK;
 }

David Miller

maintainer Applied

2015-03-06 06:03 UTC #1 lore raw

From: Dan Carpenter <[email protected]>
Date: Thu, 5 Mar 2015 20:48:46 +0300

Quoted 8 lines

We get a static checker warning here on devel kernels:
	drivers/net/hamradio/mkiss.c:560 ax_xmit()
	warn: variable dereferenced before check 'skb' (see line 532)
It turns out that the NULL check can be deleted.
Signed-off-by Dan Carpenter <[email protected]>

Applied, thanks Dan.