Skip to contentSkip to conversation

regulator: wm8350: remove unused variable

PATCH In review Arnd Bergmann 3 participants 3 messages Feb 26, 2015 – Mar 5, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 regulator: wm8350: remove unused variable

After the only user of the variable has been removed, we get a valid gcc warning about it:

regulator/wm8350-regulator.c:1154:17: warning: unused variable 'wm8350' [-Wunused-variable]

The obvious fix is to remove the variable as well.

Fixes 8f45acb5f9f34 ("regulator: wm8350: Pass NULL data with REGULATION_OUT and UNDER_VOLTAGE events")
drivers/regulator/wm8350-regulator.c +0 -1
index 78efead3b39f..95f6b040186e 100644
@@ -1151,7 +1151,6 @@ static const struct regulator_desc wm8350_reg[NUM_WM8350_REGULATORS] = {
 static irqreturn_t pmic_uv_handler(int irq, void *data)
 {
 	struct regulator_dev *rdev = (struct regulator_dev *)data;
-	struct wm8350 *wm8350 = rdev_get_drvdata(rdev);
 
 	mutex_lock(&rdev->mutex);
 	if (irq == WM8350_IRQ_CS1 || irq == WM8350_IRQ_CS2)
Acked-by on v1 1/1
#1 lore raw
Quoted 9 lines · Arnd Bergmann

After the only user of the variable has been removed, we get a valid gcc warning about it:

regulator/wm8350-regulator.c:1154:17: warning: unused variable 'wm8350' [-Wunused-variable]

The obvious fix is to remove the variable as well.

Fixes 8f45acb5f9f34 ("regulator: wm8350: Pass NULL data with REGULATION_OUT and UNDER_VOLTAGE events")

Mea culpa. Second ack on the same patch today...

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

maintainer
#2 lore raw
In reply to Arnd Bergmann
Quoted 2 lines · Arnd Bergmann

After the only user of the variable has been removed, we get a valid gcc warning about it:

I applied another fix for this, thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150305/748702c4/attachment.sig>