Skip to contentSkip to conversation

cmd_usb_mass_storage: Remove extra 'ums' string in the usage text

PATCH In review Fabio Estevam 6 participants 8 messages Feb 25, 2015 – Mar 6, 2015

lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/1 cmd_usb_mass_storage: Remove extra 'ums' string in the usage text

Currently the usage text for the 'ums' command looks like this:

Usage:
ums ums <USB_controller> [<devtype>] <devnum> e.g. ums 0 mmc 0

,so remove the extra 'ums' in the text.

Signed-off-by Fabio Estevam <[email protected]>
---
 common/cmd_usb_mass_storage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
common/cmd_usb_mass_storage.c +1 -1
index 2c879ea..51c3fff 100644
@@ -159,6 +159,6 @@ exit:
 
 U_BOOT_CMD(ums, 4, 1, do_usb_mass_storage,
 	"Use the UMS [User Mass Storage]",
-	"ums <USB_controller> [<devtype>] <devnum>  e.g. ums 0 mmc 0\n"
+	"<USB_controller> [<devtype>] <devnum>  e.g. ums 0 mmc 0\n"
 	"    devtype defaults to mmc"
 );
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 cmd_usb_mass_storage: Remove extra 'ums' string in the usage text

Quoted 8 lines · Fabio Estevam

Currently the usage text for the 'ums' command looks like this:

Usage:
ums ums <USB_controller> [<devtype>] <devnum> e.g. ums 0 mmc 0

,so remove the extra 'ums' in the text.

Signed-off-by Fabio Estevam <[email protected]>
Acked-by Otavio Salvador <[email protected]>
Signature · 3 lines
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
#3 lore raw

PATCH 1/1 cmd_usb_mass_storage: Remove extra 'ums' string in the usage text

In reply to Fabio Estevam
Quoted 8 lines

Currently the usage text for the 'ums' command looks like this:

Usage:
ums ums <USB_controller> [<devtype>] <devnum> e.g. ums 0 mmc 0

,so remove the extra 'ums' in the text.

Signed-off-by Fabio Estevam <[email protected]>

When fixing the ums help text, I think we also should change the "long name" from "User Mass Storage" to "USB Mass Storage".

Regards,
Soeren

#4 lore raw

PATCH 1/1 cmd_usb_mass_storage: Remove extra 'ums' string in the usage text

Hi Soeren,

Quoted 5 lines · Soeren Moch
Quoted 5 lines

Currently the usage text for the 'ums' command looks like this:

Usage:
ums ums <USB_controller> [<devtype>] <devnum> e.g. ums 0 mmc 0

Quoted 8 lines
Quoted 3 lines

,so remove the extra 'ums' in the text.

Signed-off-by Fabio Estevam <[email protected]>

When fixing the ums help text, I think we also should change the "long name" from "User Mass Storage" to "USB Mass Storage".

Maybe a separate patch for this?

Regards,

Fabio Estevam

#5 lore raw

PATCH 1/1 cmd_usb_mass_storage: Remove extra 'ums' string in the usage text

Quoted 8 lines · Fabio Estevam

Hi Soeren,

Quoted 5 lines · Soeren Moch
Quoted 5 lines

Currently the usage text for the 'ums' command looks like this:

Usage:
ums ums <USB_controller> [<devtype>] <devnum> e.g. ums 0 mmc 0

Quoted 8 lines
Quoted 6 lines
Quoted 3 lines

,so remove the extra 'ums' in the text.

Signed-off-by Fabio Estevam <[email protected]>

When fixing the ums help text, I think we also should change the "long name" from "User Mass Storage" to "USB Mass Storage".

Maybe a separate patch for this?

Separate please .

Best regards,
Marek Vasut

#6 lore raw

PATCH 1/1 cmd_usb_mass_storage: Remove extra 'ums' string in the usage text

In reply to Fabio Estevam

Hi Fabio,

Quoted 10 lines · Fabio Estevam

Hi Soeren,

Quoted 7 lines · Soeren Moch
Quoted 7 lines

Currently the usage text for the 'ums' command looks like this:

Usage:
ums ums <USB_controller> [<devtype>] <devnum> e.g. ums 0 mmc 0

,so remove the extra 'ums' in the text.

Quoted 8 lines
Quoted 5 lines
Quoted 1 line
Signed-off-by Fabio Estevam <[email protected]>

When fixing the ums help text, I think we also should change the "long name" from "User Mass Storage" to "USB Mass Storage".

Maybe a separate patch for this?

Thank you for preparing and sending the patch.

Regards,
Soeren

#7 lore raw
In reply to Fabio Estevam
Quoted 10 lines · Fabio Estevam

Currently the usage text for the 'ums' command looks like this:

Usage:
ums ums <USB_controller> [<devtype>] <devnum> e.g. ums 0 mmc 0

,so remove the extra 'ums' in the text.

Signed-off-by Fabio Estevam <[email protected]>
Acked-by Otavio Salvador <[email protected]>
Acked-by Marek Vasut <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150306/dd2894a6/attachment.sig>