regmap: regcache-rbtree: Fix present bitmap resize
Subsystems (2)
PATCH 1/1 regmap: regcache-rbtree: Fix present bitmap resize
When inserting a new register into a block at the lower end the present bitmap is currently shifted into the wrong direction. The effect of this is that the bitmap becomes corrupted and registers which are present might be reported as not present and vice versa.
Fix this by shifting left rather than right.
--- drivers/base/regmap/regcache-rbtree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/base/regmap/regcache-rbtree.c +1 -1
@@ -307,7 +307,7 @@ static int regcache_rbtree_insert_to_block(struct regmap *map,if (pos ==0 ) {memmove (blk + offset * map->cache_word_size, blk, rbnode->blklen * map->cache_word_size); -bitmap_shift_right (present, present, offset, blklen); +bitmap_shift_left (present, present, offset, blklen); }/* update the rbnode block, its size and the base register */
Signature · 1 line
1.8.0
Quoted 4 lines · Lars-Peter Clausen
When inserting a new register into a block at the lower end the present bitmap is currently shifted into the wrong direction. The effect of this is that the bitmap becomes corrupted and registers which are present might be reported as not present and vice versa.
Applied, thanks.
Quoted 10 lines · Lars-Peter Clausen
When inserting a new register into a block at the lower end the present bitmap is currently shifted into the wrong direction. The effect of this is that the bitmap becomes corrupted and registers which are present might be reported as not present and vice versa.
Fix this by shifting left rather than right.
Fixes 472fdec7380c("regmap: rbtree: Reduce number of nodes, take 2")Reported-by Daniel Baluta <[email protected]>Signed-off-by Lars-Peter Clausen <[email protected]>
Thanks Lars! I confirm that this fixes the problem :).
Daniel.