Skip to contentSkip to conversation

wine: Add gettext dependency check for host-wine

PATCH New André Hentschel 2 participants 2 messages Mar 7, 2015

lore
Share & tools
lore
#0 lore raw

PATCH v2 2/2 wine: Add gettext dependency check for host-wine

---
v2: minor fixes

 package/wine/wine.mk | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
package/wine/wine.mk +7 -2
index e931c87..9c6e2aa 100644
@@ -237,6 +237,13 @@ else
 WINE_CONF_OPTS += --without-zlib
 endif
 
+ifeq ($(BR2_PACKAGE_GETTEXT),y)
+HOST_WINE_CONF_OPTS += --with-gettext --with-gettextpo
+WINE_DEPENDENCIES += gettext
+else
+HOST_WINE_CONF_OPTS += --without-gettext --without-gettextpo
+endif
+
 # Wine needs to enable 64-bit build tools on 64-bit host
 ifeq ($(HOSTARCH),x86_64)
 HOST_WINE_CONF_OPTS += --enable-win64
@@ -274,8 +281,6 @@ HOST_WINE_CONF_OPTS += \
 	--without-curses \
 	--without-dbus \
 	--without-fontconfig \
-	--without-gettext \
-	--without-gettextpo \
 	--without-gphoto \
 	--without-glu \
 	--without-gnutls \
#1 lore raw

PATCH v2 2/2 wine: Add gettext dependency check for host-wine

Dear Andr? Hentschel,

Quoted 1 line · Andr? Hentschel

+ifeq ($(BR2_PACKAGE_GETTEXT),y)

This indicates that gettext is going to be built for the target.

Quoted 1 line

+HOST_WINE_CONF_OPTS += --with-gettext --with-gettextpo

This changes the configuration of a host package.

Conclusion: this doesn't make sense, unless a better explanation is provided to explain why such a weird thing is needed.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com