Skip to contentSkip to conversation

rdma: replace deprecated ifconfig in doc

PATCH In review Stephen Hemminger 2 participants 4 messages Mar 8, 2015 – Mar 10, 2015 1 message not in the archive

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 rdma: replace deprecated ifconfig in doc

The ifconfig command has been deprecated for many years. To encourage new users not to continue using it and learning iproute2; the ifconfig should not be used in examples.

Documentation/filesystems/nfs/nfs-rdma.txt +6 -3
@@ -187,8 +187,10 @@ Check RDMA and NFS Setup
     To further test the InfiniBand software stack, use IPoIB (this
     assumes you have two IB hosts named host1 and host2):
 
-    host1$ ifconfig ib0 a.b.c.x
-    host2$ ifconfig ib0 a.b.c.y
+    host1$ ip link set dev ib0 up
+    host1$ ip address add dev ib0 a.b.c.x
+    host2$ ip link set dev ib0 up
+    host2$ ip address add dev ib0 a.b.c.y
     host1$ ping a.b.c.y
     host2$ ping a.b.c.x
 
@@ -229,7 +231,8 @@ NFS/RDMA Setup
 
     $ modprobe ib_mthca
     $ modprobe ib_ipoib
-    $ ifconfig ib0 a.b.c.d
+    $ ip li set dev ib0 up
+    $ ip addr add dev ib0 a.b.c.d
 
     NOTE: use unique addresses for the client and server
 

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#1 lore raw

Hi,

Quoted 10 lines · Stephen Hemminger

The ifconfig command has been deprecated for many years. To encourage new users not to continue using it and learning iproute2; the ifconfig should not be used in examples.

Documentation/filesystems/nfs/nfs-rdma.txt Check RDMA and NFS Setup · line 192

Quoted 8 lines
Documentation/filesystems/nfs/nfs-rdma.txt +3 -2
@@ -187,8 +187,10 @@ Check RDMA and NFS Setup
     To further test the InfiniBand software stack, use IPoIB (this
     assumes you have two IB hosts named host1 and host2):
 
-    host1$ ifconfig ib0 a.b.c.x
-    host2$ ifconfig ib0 a.b.c.y
+    host1$ ip link set dev ib0 up
+    host1$ ip address add dev ib0 a.b.c.x
+    host2$ ip link set dev ib0 up

I don't think we need to "up" the device twice.

Documentation/filesystems/nfs/nfs-rdma.txt NFS/RDMA Setup · line 234

Quoted 10 lines
Documentation/filesystems/nfs/nfs-rdma.txt +2 -1
+    host2$ ip address add dev ib0 a.b.c.y
     host1$ ping a.b.c.y
     host2$ ping a.b.c.x
 
@@ -229,7 +231,8 @@ NFS/RDMA Setup
 
     $ modprobe ib_mthca
     $ modprobe ib_ipoib
-    $ ifconfig ib0 a.b.c.d
+    $ ip li set dev ib0 up

s/li/link ?

Documentation/filesystems/nfs/nfs-rdma.txt NFS/RDMA Setup · line 237

Quoted 3 lines
Documentation/filesystems/nfs/nfs-rdma.txt +1 -0
+    $ ip addr add dev ib0 a.b.c.d
 
     NOTE: use unique addresses for the client and server

Regards.

Signature · 9 lines
Yann Droneaud
OPTEYA



--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 16 lines · On Mon, 09 Mar 2015 13:06:30 +0100 Yann Droneaud…

Hi,

Quoted 13 lines · Stephen Hemminger

The ifconfig command has been deprecated for many years. To encourage new users not to continue using it and learning iproute2; the ifconfig should not be used in examples.

Documentation/filesystems/nfs/nfs-rdma.txt +0 -0
@@ -187,8 +187,10 @@ Check RDMA and NFS Setup
     To further test the InfiniBand software stack, use IPoIB (this
     assumes you have two IB hosts named host1 and host2):
 
Quoted 7 lines

Documentation/filesystems/nfs/nfs-rdma.txt Check RDMA and NFS Setup · line 192

Quoted 5 lines
Documentation/filesystems/nfs/nfs-rdma.txt +3 -2
-    host1$ ifconfig ib0 a.b.c.x
-    host2$ ifconfig ib0 a.b.c.y
+    host1$ ip link set dev ib0 up
+    host1$ ip address add dev ib0 a.b.c.x
+    host2$ ip link set dev ib0 up

I don't think we need to "up" the device twice.

You need to do it on each host.

Quoted 4 lines
Quoted 4 lines
Documentation/filesystems/nfs/nfs-rdma.txt +1 -0
+    host2$ ip address add dev ib0 a.b.c.y
     host1$ ping a.b.c.y
     host2$ ping a.b.c.x
 
Quoted 8 lines

Documentation/filesystems/nfs/nfs-rdma.txt NFS/RDMA Setup · line 234

Quoted 6 lines
Documentation/filesystems/nfs/nfs-rdma.txt +1 -1
@@ -229,7 +231,8 @@ NFS/RDMA Setup
 
     $ modprobe ib_mthca
     $ modprobe ib_ipoib
-    $ ifconfig ib0 a.b.c.d
+    $ ip li set dev ib0 up

s/li/link ?

ip commands support shorthand.

Quoted 6 lines

Documentation/filesystems/nfs/nfs-rdma.txt NFS/RDMA Setup · line 237

Quoted 3 lines
Documentation/filesystems/nfs/nfs-rdma.txt +1 -0
+    $ ip addr add dev ib0 a.b.c.d
 
     NOTE: use unique addresses for the client and server

Regards.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#4 lore raw

Hi,

Quoted 24 lines · Stephen Hemminger
Quoted 14 lines · On Mon, 09 Mar 2015 13:06:30 +0100 Yann Droneaud…
Quoted 13 lines · Stephen Hemminger

The ifconfig command has been deprecated for many years. To encourage new users not to continue using it and learning iproute2; the ifconfig should not be used in examples.

Documentation/filesystems/nfs/nfs-rdma.txt +0 -0
@@ -187,8 +187,10 @@ Check RDMA and NFS Setup
     To further test the InfiniBand software stack, use IPoIB (this
     assumes you have two IB hosts named host1 and host2):
 
Quoted 7 lines

Documentation/filesystems/nfs/nfs-rdma.txt Check RDMA and NFS Setup · line 192

Quoted 5 lines
Documentation/filesystems/nfs/nfs-rdma.txt +3 -2
-    host1$ ifconfig ib0 a.b.c.x
-    host2$ ifconfig ib0 a.b.c.y
+    host1$ ip link set dev ib0 up
+    host1$ ip address add dev ib0 a.b.c.x
+    host2$ ip link set dev ib0 up

I don't think we need to "up" the device twice.

Quoted 2 lines

You need to do it on each host.

Oops, missed that. Sorry.

Quoted 6 lines
Quoted 6 lines
Quoted 6 lines
Documentation/filesystems/nfs/nfs-rdma.txt +1 -0
+    host2$ ip address add dev ib0 a.b.c.y
     host1$ ping a.b.c.y
     host2$ ping a.b.c.x
 
@@ -229,7 +231,8 @@ NFS/RDMA Setup
 
Quoted 9 lines
Quoted 6 lines

Documentation/filesystems/nfs/nfs-rdma.txt NFS/RDMA Setup · line 234

Quoted 4 lines
Documentation/filesystems/nfs/nfs-rdma.txt +1 -1
     $ modprobe ib_mthca
     $ modprobe ib_ipoib
-    $ ifconfig ib0 a.b.c.d
+    $ ip li set dev ib0 up

s/li/link ?

ip commands support shorthand.

Yes, sure, but here, it's looking more like a typo. It should be consistent throughout the document.

Regards.

Signature · 8 lines
Yann Droneaud
OPTEYA


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html