Skip to contentSkip to conversation

crypto: qat - remove incorrect __exit markup

PATCH Applied Dmitry Torokhov 2 participants 2 messages Mar 9, 2015 – Mar 11, 2015 Crypto API

lore
Share & tools
lore

Dmitry Torokhov

author
#0 lore raw

PATCH 1/1 crypto: qat - remove incorrect __exit markup

PCI bus is hot-pluggable, and even if it wasn't one can still unbind the device from driver via sysfs, so we should not make driver's remove method as __exit.

Signed-off-by Dmitry Torokhov <[email protected]>
---
 drivers/crypto/qat/qat_dh895xcc/adf_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/crypto/qat/qat_dh895xcc/adf_drv.c +1 -1
index 8ffdb95..e7af9d5 100644
@@ -379,7 +379,7 @@ out_err:
 	return ret;
 }
 
-static void __exit adf_remove(struct pci_dev *pdev)
+static void adf_remove(struct pci_dev *pdev)
 {
 	struct adf_accel_dev *accel_dev = adf_devmgr_pci_to_accel_dev(pdev);
Signature · 5 lines
2.2.0.rc0.207.ga3a616c


-- 
Dmitry
maintainer Applied
#1 lore raw
Quoted 5 lines · Dmitry Torokhov

PCI bus is hot-pluggable, and even if it wasn't one can still unbind the device from driver via sysfs, so we should not make driver's remove method as __exit.

Signed-off-by Dmitry Torokhov <[email protected]>

Applied.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt