x86:pci: Change sta2x11_dma_ops stucture to use switolb_dma_supported as it's dma_supported function in sta2x11-fixup.c
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 9 lines · Nicholas Krause
This changes the structure
sta2x11_dma_opsstucture to useswitolb_dma_supportedas it's function fordma_supportedhardware verus setting this value to NULL as this should be set correctly for whendma_supportedfunction needs to be called for hardware needing this function to be supported. Otherwise hardware needing this function to be supported will either cause a kernel panic or oops due to a NULL pointer being dereferenced in the structure,sta1x11_dma_opsfor thedma_supportedfunction. Further more in order to prevent a kernel panic or oops here due to a NULL pointer being deferred here we add the function,swiotlb_dma_supportedas thedma_supportedfunction for the structure,sta2x11_dma_ops.
Pleasedontresendtotallyunstructuredandunreadablechangelogs.
You also (still) don't explain where and how this supposed crash might happen in practice. Please don't resend unless you've addressed those deficiencies.
I.e. I'm not convinced you know what you are modifying there and what effects your modifications will have.
Thanks,
Ingo
A message that is not in the archive (sent off-list or not yet received): [email protected]
Quoted 33 lines · Nicholas Krause
Quoted 30 lines · Ingo Molnar
Quoted 1 line · Nicholas Krause
This changes the structure
sta2x11_dma_opsstucture to use
switolb_dma_supportedas it'sQuoted 1 line
function for
dma_supportedhardware verus setting this value to NULLas this should be set
Quoted 1 line
correctly for when
dma_supportedfunction needs to be called forhardware needing this
Quoted 1 line
function to be supported. Otherwise hardware needing this function to
be supported will
Quoted 1 line
either cause a kernel panic or oops due to a NULL pointer being
dereferenced in the
Quoted 1 line
structure,
sta1x11_dma_opsfor thedma_supportedfunction. Furthermore in order to
Quoted 1 line
prevent a kernel panic or oops here due to a NULL pointer being
deferred here we add the
Quoted 1 line
function,
swiotlb_dma_supportedas thedma_supportedfunction for thestructure,
Quoted 1 line
sta2x11_dma_ops.Pleasedontresendtotallyunstructuredandunreadablechangelogs.
You also (still) don't explain where and how this supposed crash might happen in practice. Please don't resend unless you've addressed those deficiencies.
I.e. I'm not convinced you know what you are modifying there and what effects your modifications will have.
Quoted 6 lines
Quoted 3 lines
Thanks,
Ingo
Ingo,
I was just wondering why my patch wasn't merged yet. In addition this patch is more of a preventive measure as if there is no function pointer here either we kernel panic or oops at best if hardware needs to access a dma function for this structure . At the moment I am unaware of any actual hardware that causes this issues, however this doesn't mean it won't happen at some point. I can rewrite my change log to this reasoning if required. Nick
1)
So as a reply to my feedback complaining about the quality of your submissions, you write an unstructured mail put into a single line with no newline at all? *whoosh*
2)
So I restructured your reply, added newlines at logical boundaries of thought, added proper punctuation and capitalization, fixed typos, removed phantom spaces - to make it minimally readable:
Quoted 10 lines
I was just wondering why my patch wasn't merged yet.
In addition, this patch is more of a preventive measure, as if there is no function pointer here either we kernel panic or oops at best if hardware needs to access a DMA function for this structure.
At the moment I am unaware of any actual hardware that causes these issues, however this doesn't mean it won't happen at some point.
I can rewrite my change log to this reasoning if required.
You should have done this before expecting others to spend time on your mails.
3)
As to the technical substance of your patch: where exactly would the kernel panic or oops? Your changelog is missing actual analysis.
4)
And if you are wondering why maintainers have learned to start ignoring your trivial patches:
- Unstructured changelogs, typos, missing punctuation, missing newlines, missing capitalization, phantom spaces cause submissions to be ignored as trivially deficient.
- No real analysis is found in your patch, beyond the line that was spewed out by 'git grep -i fixme'.
- Mass mailing of borderline useless patches is a waste of time for everyone. There are thousands of trivial FIXME's in the kernel and you want to generate a commit for every single one?
The thing is, you now know how to write patches and how to upstream them. So it's time to rise beyond trivial patches: how about reading and understanding kernel code and fixing some real bugs?
5)
All in one, I'm not convinced you went beyond the 'git grep -i fixme' line in reading kernel code...
But it's up to Bjorn whether to merge your patch.
Thanks,
Ingo