Staging: lustre: Remove unneeded variable and replace its uses

Variable dotdot is only used as a function parameter and can be replaced there directly to improve code compactness.

Signed-off-by Vatika Harlalka <[email protected]>

---
 drivers/staging/lustre/lustre/llite/llite_nfs.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

drivers/staging/lustre/lustre/llite/llite_nfs.c +3 -5

index 6a67e71..b8ced3d 100644
@@ -287,7 +287,6 @@ static struct dentry *ll_get_parent(struct dentry *dchild)
 	struct ll_sb_info     *sbi;
 	struct dentry	 *result = NULL;
 	struct mdt_body       *body;
-	static const char	   dotdot[] = "..";
 	struct md_op_data     *op_data;
 	int		   rc;
 	int		      lmmsize;

@@ -303,8 +302,8 @@ static struct dentry *ll_get_parent(struct dentry *dchild)
 	if (rc != 0)
 		return ERR_PTR(rc);
 
-	op_data = ll_prep_md_op_data(NULL, dir, NULL, dotdot,
-				     strlen(dotdot), lmmsize,
+	op_data = ll_prep_md_op_data(NULL, dir, NULL, "..",
+				     2, lmmsize,
 				     LUSTRE_OPC_ANY, NULL);
 	if (IS_ERR(op_data))
 		return (void *)op_data;

@@ -321,7 +320,7 @@ static struct dentry *ll_get_parent(struct dentry *dchild)
 	CDEBUG(D_INFO, "parent for "DFID" is "DFID"\n",
 		PFID(ll_inode2fid(dir)), PFID(&body->fid1));
 
-	result = ll_iget_for_nfs(dir->i_sb, &body->fid1, NULL);
+
 
 	ptlrpc_req_finished(req);
 	return result;
--

1.9.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20150310134242.GA9593%40akanksha.
For more options, visit https://groups.google.com/d/optout.

Variable dotdot is only used as a function parameter and can be replaced there directly to improve code compactness.

Signed-off-by Vatika Harlalka <[email protected]>

---
 drivers/staging/lustre/lustre/llite/llite_nfs.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

drivers/staging/lustre/lustre/llite/llite_nfs.c +2 -3

index 6a67e71..b8ced3d 100644
@@ -287,7 +287,6 @@ static struct dentry *ll_get_parent(struct dentry *dchild)
 	struct ll_sb_info     *sbi;
 	struct dentry	 *result = NULL;
 	struct mdt_body       *body;
-	static const char	   dotdot[] = "..";
 	struct md_op_data     *op_data;
 	int		   rc;
 	int		      lmmsize;

@@ -303,8 +302,8 @@ static struct dentry *ll_get_parent(struct dentry *dchild)
 	if (rc != 0)
 		return ERR_PTR(rc);
 
-	op_data = ll_prep_md_op_data(NULL, dir, NULL, dotdot,
-				     strlen(dotdot), lmmsize,
+	op_data = ll_prep_md_op_data(NULL, dir, NULL, "..",
+				     2, lmmsize,
 				     LUSTRE_OPC_ANY, NULL);
 	if (IS_ERR(op_data))
 		return (void *)op_data;