Skip to contentSkip to conversation

ARM: shmobile: koelsch / lager regulator updates

PATCH New Geert Uytterhoeven 2 participants 6 messages Mar 9, 2015 – Mar 11, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover ARM: shmobile: koelsch / lager regulator updates

Hi Simon, Magnus,

This patch series contains two DTS updates each for r8a7791/koelsch and r8a7790/lager:
- add the missing interrupt for the da9210 regulators,
- add device nodes for the da9063 pmics.

The da9063 pmic allows the system to be restarted when the watchdog timer times out ("cat > dev/watchdog0", and wait 8 s), or when a system restart is requested ("reboot").

This series depends on "[PATCH] ARM: shmobile: R-Car Gen2: Add da9063/da9210 regulator quirk".

An earlier version of patch [2/4] has been posted before as "[PATCH 3/4]
ARM: shmobile: koelsch: Add DA9063 PMIC device node for system restart", but it caused havoc without the quirk.

This has been tested on r8a7791/koelsch.

Thanks!

Geert Uytterhoeven (4):
ARM: shmobile: koelsch dts: Add da9210 regulator interrupt
ARM: shmobile: koelsch: Add da9063 PMIC device node for system restart
ARM: shmobile: lager dts: Add da9210 regulator interrupt
ARM: shmobile: lager: Add da9063 PMIC device node for system restart

 arch/arm/boot/dts/r8a7790-lager.dts   | 18 ++++++++++++++++++
 arch/arm/boot/dts/r8a7791-koelsch.dts | 18 ++++++++++++++++++
 2 files changed, 36 insertions(+)
Signature · 12 lines
1.9.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
#1 lore raw

PATCH 1/4 ARM: shmobile: koelsch dts: Add da9210 regulator interrupt

The da9210 regulator is connected to IRQ2. Reflect this in its device node, so the driver can use it when it gains interrupt support.

---
 arch/arm/boot/dts/r8a7791-koelsch.dts | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/r8a7791-koelsch.dts +2 -0
index 75fa9852e235455c..25ce4c71939febd0 100644
@@ -587,6 +587,8 @@
 	vdd_dvfs: regulator at 68 {
 		compatible = "dlg,da9210";
 		reg = <0x68>;
+		interrupt-parent = <&irqc0>;
+		interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
 
 		regulator-min-microvolt = <1000000>;
 		regulator-max-microvolt = <1000000>;
Signature · 1 line
1.9.1
#2 lore raw

PATCH 2/4 ARM: shmobile: koelsch: Add da9063 PMIC device node for system restart

In reply to Geert Uytterhoeven

Add a device node for the da9063 PMIC, with subnodes for rtc and wdt. Regulator support is not yet included.

This allows the system to be restarted when the watchdog timer times out, or when a system restart is requested.

---
An earlier version of this patch has been posted as "[PATCH 3/4] ARM:
shmobile: koelsch: Add DA9063 PMIC device node for system restart".

Changes:
- Add missing interrupt-controller property,
- Add rtc and wdt subnodes.

---
 arch/arm/boot/dts/r8a7791-koelsch.dts | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
arch/arm/boot/dts/r8a7791-koelsch.dts +16 -0
index 25ce4c71939febd0..74c3212f1f11e47e 100644
@@ -584,6 +584,22 @@
 	status = "okay";
 	clock-frequency = <100000>;
 
+	pmic at 58 {
+		compatible = "dlg,da9063";
+		reg = <0x58>;
+		interrupt-parent = <&irqc0>;
+		interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
+		interrupt-controller;
+
+		rtc {
+			compatible = "dlg,da9063-rtc";
+		};
+
+		wdt {
+			compatible = "dlg,da9063-watchdog";
+		};
+	};
+
 	vdd_dvfs: regulator at 68 {
 		compatible = "dlg,da9210";
 		reg = <0x68>;
Signature · 1 line
1.9.1
#3 lore raw

PATCH 3/4 ARM: shmobile: lager dts: Add da9210 regulator interrupt

In reply to Geert Uytterhoeven

The da9210 regulator is connected to IRQ2. Reflect this in its device node, so the driver can use it when it gains interrupt support.

---
 arch/arm/boot/dts/r8a7790-lager.dts | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/r8a7790-lager.dts +2 -0
index 329bb994aac04084..6fa8681a431fceb8 100644
@@ -585,6 +585,8 @@
 	vdd_dvfs: regulator at 68 {
 		compatible = "dlg,da9210";
 		reg = <0x68>;
+		interrupt-parent = <&irqc0>;
+		interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
 
 		regulator-min-microvolt = <1000000>;
 		regulator-max-microvolt = <1000000>;
Signature · 1 line
1.9.1
#4 lore raw

PATCH 4/4 ARM: shmobile: lager: Add da9063 PMIC device node for system restart

In reply to Geert Uytterhoeven

Add a device node for the da9063 PMIC, with subnodes for rtc and wdt. Regulator support is not yet included.

This allows the system to be restarted when the watchdog timer times out, or when a system restart is requested.

---
 arch/arm/boot/dts/r8a7790-lager.dts | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)
arch/arm/boot/dts/r8a7790-lager.dts +16 -0
index 6fa8681a431fceb8..aaa4f258e279ccfa 100644
@@ -582,6 +582,22 @@
 	pinctrl-0 = <&iic3_pins>;
 	status = "okay";
 
+	pmic at 58 {
+		compatible = "dlg,da9063";
+		reg = <0x58>;
+		interrupt-parent = <&irqc0>;
+		interrupts = <2 IRQ_TYPE_LEVEL_LOW>;
+		interrupt-controller;
+
+		rtc {
+			compatible = "dlg,da9063-rtc";
+		};
+
+		wdt {
+			compatible = "dlg,da9063-watchdog";
+		};
+	};
+
 	vdd_dvfs: regulator at 68 {
 		compatible = "dlg,da9210";
 		reg = <0x68>;
Signature · 1 line
1.9.1
#5 lore raw

cover ARM: shmobile: koelsch / lager regulator updates

In reply to Geert Uytterhoeven
Quoted 11 lines · Geert Uytterhoeven

Hi Simon, Magnus,

This patch series contains two DTS updates each for r8a7791/koelsch and r8a7790/lager:
- add the missing interrupt for the da9210 regulators,
- add device nodes for the da9063 pmics.

The da9063 pmic allows the system to be restarted when the watchdog timer times out ("cat > dev/watchdog0", and wait 8 s), or when a system restart is requested ("reboot").

Quoted 8 lines

This series depends on "[PATCH] ARM: shmobile: R-Car Gen2: Add da9063/da9210 regulator quirk".

An earlier version of patch [2/4] has been posted before as "[PATCH 3/4]
ARM: shmobile: koelsch: Add DA9063 PMIC device node for system restart", but it caused havoc without the quirk.

This has been tested on r8a7791/koelsch.

Thanks, I have queued this up for v4.1 on top of the above mentioned patch.