Skip to contentSkip to conversation

ARM: imx6qdl-sabresd: set swbst_reg as vbus's parent reg

PATCH New Peter Chen 3 participants 6 messages Mar 6, 2015 – Mar 12, 2015

Subsystems (2)
Device tree bindings Arm i.MX and Layerscape
lore
Share & tools
lore

Peter Chen

author
#0 lore raw

PATCH 1/2 ARM: imx6qdl-sabresd: set swbst_reg as vbus's parent reg

USB vbus 5V is from PMIC SWBST, so set swbst_reg as vbus's parent reg, it fixed a bug that the voltage of vbus is incorrect due to swbst_reg is disabled after boots up.

Cc stable <[email protected]>
Signed-off-by Peter Chen <[email protected]>
---
 arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/imx6qdl-sabresd.dtsi +2 -0
index f1cd214..a626e6d 100644
@@ -35,6 +35,7 @@
 			regulator-max-microvolt = <5000000>;
 			gpio = <&gpio3 22 0>;
 			enable-active-high;
+			vin-supply = <&swbst_reg>;
 		};
 
 		reg_usb_h1_vbus: regulator at 1 {

@@ -45,6 +46,7 @@
 			regulator-max-microvolt = <5000000>;
 			gpio = <&gpio1 29 0>;
 			enable-active-high;
+			vin-supply = <&swbst_reg>;
 		};
 
 		reg_audio: regulator at 2 {
Signature · 1 line
1.9.1
author
#1 lore raw

PATCH 2/2 ARM: imx6sl-evk: set swbst_reg as vbus's parent reg

USB vbus 5V is from PMIC SWBST, so set swbst_reg as vbus's parent reg, it fixed a bug that the voltage of vbus is incorrect due to swbst_reg is disabled after boots up.

Cc stable <[email protected]>
Signed-off-by Peter Chen <[email protected]>
---
 arch/arm/boot/dts/imx6sl-evk.dts | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/imx6sl-evk.dts +2 -0
index fda4932..945887d 100644
@@ -52,6 +52,7 @@
 			regulator-max-microvolt = <5000000>;
 			gpio = <&gpio4 0 0>;
 			enable-active-high;
+			vin-supply = <&swbst_reg>;
 		};
 
 		reg_usb_otg2_vbus: regulator at 1 {

@@ -62,6 +63,7 @@
 			regulator-max-microvolt = <5000000>;
 			gpio = <&gpio4 2 0>;
 			enable-active-high;
+			vin-supply = <&swbst_reg>;
 		};
 
 		reg_aud3v: regulator at 2 {
Signature · 1 line
1.9.1
#2 lore raw

PATCH 1/2 ARM: imx6qdl-sabresd: set swbst_reg as vbus's parent reg

In reply to Peter Chen
Quoted 5 lines · Peter Chen

USB vbus 5V is from PMIC SWBST, so set swbst_reg as vbus's parent reg, it fixed a bug that the voltage of vbus is incorrect due to swbst_reg is disabled after boots up.

Cc stable <[email protected]>

It's more idiomatic to put the line in this way:

Cc stable at vger.kernel.org

Changed it and applied both patches.

Shawn

Quoted 28 lines
Signed-off-by Peter Chen <[email protected]>
---
 arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 2 ++
 1 file changed, 2 insertions(+)
arch/arm/boot/dts/imx6qdl-sabresd.dtsi +2 -0
index f1cd214..a626e6d 100644
@@ -35,6 +35,7 @@
 			regulator-max-microvolt = <5000000>;
 			gpio = <&gpio3 22 0>;
 			enable-active-high;
+			vin-supply = <&swbst_reg>;
 		};
 
 		reg_usb_h1_vbus: regulator at 1 {

@@ -45,6 +46,7 @@
 			regulator-max-microvolt = <5000000>;
 			gpio = <&gpio1 29 0>;
 			enable-active-high;
+			vin-supply = <&swbst_reg>;
 		};
 
 		reg_audio: regulator at 2 {
Signature · 1 line
1.9.1
#3 lore raw

PATCH 1/2 ARM: imx6qdl-sabresd: set swbst_reg as vbus's parent reg

Quoted 5 lines · Shawn Guo
Quoted 4 lines · Peter Chen

USB vbus 5V is from PMIC SWBST, so set swbst_reg as vbus's parent reg, it fixed a bug that the voltage of vbus is incorrect due to swbst_reg is disabled after boots up.

Quoted 7 lines
Quoted 1 line
Cc stable <[email protected]>

It's more idiomatic to put the line in this way:

Cc stable at vger.kernel.org

Changed it and applied both patches.

It really doesn't matter, my scripts try to pick up any variation of the stable@ markings in a signed-off-by: area, as there is a huge number of different ways people try to mark this, including using invalid email addresses, and typos.

So no need to be pedantic about this, I can handle it just fine.

thanks,

greg k-h

author
#4 lore raw

PATCH 1/2 ARM: imx6qdl-sabresd: set swbst_reg as vbus's parent reg

In reply to Shawn Guo
Quoted 11 lines · Shawn Guo
Quoted 5 lines · Peter Chen

USB vbus 5V is from PMIC SWBST, so set swbst_reg as vbus's parent reg, it fixed a bug that the voltage of vbus is incorrect due to swbst_reg is disabled after boots up.

Cc stable <[email protected]>

It's more idiomatic to put the line in this way:

Cc stable at vger.kernel.org

One benefit for using <[email protected]> over than stable at vger.kernel.org directly is it can add "# v3.x+" at the last of Cc tag if you want git send Cc tag.

Cc <[email protected]> #3.x+ /* git can work */
Cc stable at vger.kernel.org #3.x+ /* git can't work */
Signature · 2 lines
Best Regards,
Peter Chen
#5 lore raw

PATCH 1/2 ARM: imx6qdl-sabresd: set swbst_reg as vbus's parent reg

Quoted 13 lines · Peter Chen
Quoted 11 lines · Shawn Guo
Quoted 5 lines · Peter Chen

USB vbus 5V is from PMIC SWBST, so set swbst_reg as vbus's parent reg, it fixed a bug that the voltage of vbus is incorrect due to swbst_reg is disabled after boots up.

Cc stable <[email protected]>

It's more idiomatic to put the line in this way:

Cc stable at vger.kernel.org
Quoted 7 lines

One benefit for using <[email protected]> over than stable at vger.kernel.org directly is it can add "# v3.x+" at the last of Cc tag if you want git send Cc tag.

Cc <[email protected]> #3.x+ /* git can work */
Cc stable at vger.kernel.org #3.x+ /* git can't work */

Yeah, that's true. What I was really questioning is not < >, but the alias 'stable' right before it.

Shawn