Skip to contentSkip to conversation

serial: 8250_dw: fix 'cts-override'

PATCH In review Dmitry Torokhov 2 participants 5 messages Mar 10, 2015 – Mar 22, 2015

Subsystems (3)
TTY layer and serial drivers Intel LPSS (Low Power SubSystem) drivers Synopsys DesignWare 8250 UART driver
lore
Share & tools
lore

Dmitry Torokhov

author
#0 lore raw

PATCH 1/1 serial: 8250_dw: fix 'cts-override'

We are dealing with CTS, not DSR here (we dealt with DSR a few lines above), so set appropriate bits.

Reported-by Kevin Cernekee <[email protected]>
Signed-off-by Dmitry Torokhov <[email protected]>
---
 drivers/tty/serial/8250/8250_dw.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/tty/serial/8250/8250_dw.c +3 -3
index 2ab229d..eb0a511 100644
@@ -355,9 +355,9 @@ static int dw8250_probe_of(struct uart_port *p,
 	}
 
 	if (of_property_read_bool(np, "cts-override")) {
-		/* Always report DSR as active */
-		data->msr_mask_on |= UART_MSR_DSR;
-		data->msr_mask_off |= UART_MSR_DDSR;
+		/* Always report CTS as active */
+		data->msr_mask_on |= UART_MSR_CTS;
+		data->msr_mask_off |= UART_MSR_DCTS;
 	}
 
 	if (of_property_read_bool(np, "ri-override")) {
Signature · 5 lines
2.2.0.rc0.207.ga3a616c


-- 
Dmitry
maintainer
#1 lore raw
Quoted 8 lines · Dmitry Torokhov

We are dealing with CTS, not DSR here (we dealt with DSR a few lines above), so set appropriate bits.

Reported-by Kevin Cernekee <[email protected]>
Signed-off-by Dmitry Torokhov <[email protected]>
---
 drivers/tty/serial/8250/8250_dw.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Should this go into 4.0-final, or can it wait for 4.1-rc1? I'm guessing 4.0-final, but want to make sure.

thanks,

greg k-h

author
#2 lore raw

Hi Greg,

Quoted 4 lines · Greg Kroah-Hartman
Quoted 3 lines · Dmitry Torokhov

We are dealing with CTS, not DSR here (we dealt with DSR a few lines above), so set appropriate bits.

Quoted 8 lines
Quoted 5 lines
Reported-by Kevin Cernekee <[email protected]>
Signed-off-by Dmitry Torokhov <[email protected]>
---
 drivers/tty/serial/8250/8250_dw.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Should this go into 4.0-final, or can it wait for 4.1-rc1? I'm guessing 4.0-final, but want to make sure.

I'd like to have it in 4.0 but since there are no users of the feature in mainline yet I think it can wait.

Thanks,
Dmitry

author
#3 lore raw

Hi Greg,

Quoted 14 lines · Dmitry Torokhov

Hi Greg,

Quoted 10 lines · Greg Kroah-Hartman
Quoted 8 lines · Dmitry Torokhov

We are dealing with CTS, not DSR here (we dealt with DSR a few lines above), so set appropriate bits.

Reported-by Kevin Cernekee <[email protected]>
Signed-off-by Dmitry Torokhov <[email protected]>
---
 drivers/tty/serial/8250/8250_dw.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Quoted 6 lines
Quoted 2 lines

Should this go into 4.0-final, or can it wait for 4.1-rc1? I'm guessing 4.0-final, but want to make sure.

I'd like to have it in 4.0 but since there are no users of the feature in mainline yet I think it can wait.

Could you please pick it for 4.1?

Thanks,
Dmitry

maintainer
#4 lore raw
Quoted 17 lines · Dmitry Torokhov

Hi Greg,

Quoted 14 lines · Dmitry Torokhov

Hi Greg,

Quoted 10 lines · Greg Kroah-Hartman
Quoted 8 lines · Dmitry Torokhov

We are dealing with CTS, not DSR here (we dealt with DSR a few lines above), so set appropriate bits.

Reported-by Kevin Cernekee <[email protected]>
Signed-off-by Dmitry Torokhov <[email protected]>
---
 drivers/tty/serial/8250/8250_dw.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Quoted 8 lines
Quoted 6 lines
Quoted 2 lines

Should this go into 4.0-final, or can it wait for 4.1-rc1? I'm guessing 4.0-final, but want to make sure.

I'd like to have it in 4.0 but since there are no users of the feature in mainline yet I think it can wait.

Could you please pick it for 4.1?

Will do, thanks.

greg k-h