Skip to contentSkip to conversation

staging: sm750fb: if else block checkpath warnings

PATCH In review Ragavendra BN 2 participants 2 messages Mar 12, 2015

Subsystems (3)
Staging Framebuffer layer Staging - silicon motion SM750 frame buffer driver
lore
Share & tools
lore

Ragavendra BN

author
#0 lore raw

PATCH 1/1 staging: sm750fb: if else block checkpath warnings

Signed-off-by Ragavendra BN <[email protected]>

This patch fixes the coding style warnings found by checkpath.pl for the if else block

---
 drivers/staging/sm750fb/ddk750_chip.c |   25 ++++++++++---------------
 1 file changed, 10 insertions(+), 15 deletions(-)
drivers/staging/sm750fb/ddk750_chip.c +10 -15
index 2c12dd0..041a05a 100644
@@ -11,7 +11,8 @@ typedef struct _pllcalparam{
 pllcalparam;
 
 
-logical_chip_type_t getChipType(){
+logical_chip_type_t getChipType()
+{
 	unsigned short physicalID;
 	char physicalRev;
 	logical_chip_type_t chip;

@@ -19,22 +20,16 @@ logical_chip_type_t getChipType(){
 	physicalID = devId750;//either 0x718 or 0x750
 	physicalRev = revId750;
 
-    if (physicalID = 0x718)
-    {
-        chip = SM718;
-    }
-    else if (physicalID = 0x750)
-    {
-        chip = SM750;
+	if (physicalID = 0x718) {
+		chip = SM718;
+	} else if (physicalID = 0x750) {
+		chip = SM750;
 		/* SM750 and SM750LE are different in their revision ID only. */
-		if (physicalRev = SM750LE_REVISION_ID){
+		if (physicalRev = SM750LE_REVISION_ID)
 			chip = SM750LE;
-		}
-    }
-    else
-    {
-        chip = SM_UNKNOWN;
-    }
+	} else {
+		chip = SM_UNKNOWN;
+	}
 
 	return chip;
 }
Signature · 1 line
1.7.10.4
maintainer
#1 lore raw
Quoted 2 lines · Ragavendra BN
Signed-off-by Ragavendra BN <[email protected]>

This goes on the bottom of the changelog text.

Quoted 2 lines

This patch fixes the coding style warnings found by checkpath.pl for the if else block

It also does something else, so I have to reject this. Please be very specific as to what you are doing here.

thanks,

greg k-h