Skip to contentSkip to conversation

staging: sm750fb: braces, indents, spaces fix

PATCH In review Ragavendra BN 2 participants 2 messages Mar 13, 2015

Subsystems (3)
Staging Framebuffer layer Staging - silicon motion SM750 frame buffer driver
lore
Share & tools
lore

Ragavendra BN

author
#0 lore raw

PATCH 1/1 staging: sm750fb: braces, indents, spaces fix

Signed-off-by Ragavendra BN <[email protected]>

This patch removes the braces for the single line if statement. It fixes the indent positions correctly. It fixes the spaces appropriately making the code give no warnings by the checkpath.pl script check.

---
 drivers/staging/sm750fb/ddk750_chip.c |   22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)
drivers/staging/sm750fb/ddk750_chip.c +8 -14
index b71169e..041a05a 100644
@@ -20,22 +20,16 @@ logical_chip_type_t getChipType()
 	physicalID = devId750;//either 0x718 or 0x750
 	physicalRev = revId750;
 
-    if (physicalID = 0x718)
-    {
-        chip = SM718;
-    }
-    else if (physicalID = 0x750)
-    {
-        chip = SM750;
+	if (physicalID = 0x718) {
+		chip = SM718;
+	} else if (physicalID = 0x750) {
+		chip = SM750;
 		/* SM750 and SM750LE are different in their revision ID only. */
-		if (physicalRev = SM750LE_REVISION_ID){
+		if (physicalRev = SM750LE_REVISION_ID)
 			chip = SM750LE;
-		}
-    }
-    else
-    {
-        chip = SM_UNKNOWN;
-    }
+	} else {
+		chip = SM_UNKNOWN;
+	}
 
 	return chip;
 }
Signature · 1 line
1.7.10.4
maintainer
#1 lore raw
Quoted 6 lines · Ragavendra BN
Signed-off-by Ragavendra BN <[email protected]>

This patch removes the braces for the single line if statement. It fixes the indent positions correctly. It fixes the spaces appropriately making the code give no warnings by the checkpath.pl script check.

Signed-off-by line should come here before the ---

Quoted 1 line

---

not at the top like you are giving.
Greg has told you once, I am telling now for the second time.

regards
sudip