Skip to contentSkip to conversation

staging: sm750fb: braces, indents, spaces fix

PATCH In review Ragavendra BN 3 participants 3 messages Mar 13, 2015 – Mar 14, 2015 1 message not in the archive

Subsystems (3)
Staging Framebuffer layer Staging - silicon motion SM750 frame buffer driver
lore
Share & tools
lore

Ragavendra BN

author
#0 lore raw

PATCH 1/1 staging: sm750fb: braces, indents, spaces fix

This patch removes the braces for the single line if statement. It fixes the indent positions correctly. It fixes the spaces appropriately making the code give no warnings by the checpath.pl script check. Please accept.

Signed-off-by Ragavendra BN <[email protected]>
---
 drivers/staging/sm750fb/ddk750_chip.c |   22 ++++++++--------------
 1 file changed, 8 insertions(+), 14 deletions(-)
drivers/staging/sm750fb/ddk750_chip.c +8 -14
index b71169e..041a05a 100644
@@ -20,22 +20,16 @@ logical_chip_type_t getChipType()
 	physicalID = devId750;//either 0x718 or 0x750
 	physicalRev = revId750;
 
-    if (physicalID = 0x718)
-    {
-        chip = SM718;
-    }
-    else if (physicalID = 0x750)
-    {
-        chip = SM750;
+	if (physicalID = 0x718) {
+		chip = SM718;
+	} else if (physicalID = 0x750) {
+		chip = SM750;
 		/* SM750 and SM750LE are different in their revision ID only. */
-		if (physicalRev = SM750LE_REVISION_ID){
+		if (physicalRev = SM750LE_REVISION_ID)
 			chip = SM750LE;
-		}
-    }
-    else
-    {
-        chip = SM_UNKNOWN;
-    }
+	} else {
+		chip = SM_UNKNOWN;
+	}
 
 	return chip;
 }
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 3 lines · Ragavendra BN

This patch removes the braces for the single line if statement. It fixes the indent positions correctly. It fixes the spaces appropriately making the code give no warnings by the checpath.pl script check. Please accept.

                                            ^^^^^^^^^^^^^^

Don't put this in the changelog.

Quoted 2 lines
Signed-off-by Ragavendra BN <[email protected]>

Is your name *really* BN?

regards,
dan carpenter

A message that is not in the archive (sent off-list or not yet received): CAPBgb4=np7Bs=sMTZHpZZ1Ef7uriUDYjjz6Y7+49Vs1rOVo59w@mail.gmail.com

maintainer
#3 lore raw
Quoted 1 line · Ragavendra

BN is my initial, should it be expanded?

Yes.