Skip to contentSkip to conversation

x86/kexec: Cleanup KEXEC_VERIFY_SIG Kconfig help text

PATCH In review Borislav Petkov 3 participants 4 messages Mar 13, 2015 – Mar 16, 2015 x86

lore
Share & tools
lore

Borislav Petkov

author maintainer
#0 lore raw

PATCH 1/1 x86/kexec: Cleanup KEXEC_VERIFY_SIG Kconfig help text

From: Borislav Petkov <[email protected]>

Make it much simpler without losing the gist of what it says.

Cc Thomas Gleixner <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc "H. Peter Anvin" <[email protected]>
Cc Andrew Morton <[email protected]>
Cc Vivek Goyal <[email protected]>
---
 arch/x86/Kconfig | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)
arch/x86/Kconfig +5 -8
index 8f829ffb9003..8db84b0e5bbd 100644
@@ -1775,14 +1775,11 @@ config KEXEC_VERIFY_SIG
 	depends on KEXEC_FILE
 	---help---
 	  This option makes kernel signature verification mandatory for
-	  kexec_file_load() syscall. If kernel is signature can not be
-	  verified, kexec_file_load() will fail.
-
-	  This option enforces signature verification at generic level.
-	  One needs to enable signature verification for type of kernel
-	  image being loaded to make sure it works. For example, enable
-	  bzImage signature verification option to be able to load and
-	  verify signatures of bzImage. Otherwise kernel loading will fail.
+	  the kexec_file_load() syscall.
+
+	  In addition to that option, you need to enable signature
+	  verification for the corresponding kernel image type being
+	  loaded in order for this to work.
 
 config KEXEC_BZIMAGE_VERIFY_SIG
 	bool "Enable bzImage signature verification support"
Signature · 1 line
2.2.0.33.gc18b867
#1 lore raw
Quoted 26 lines · Borislav Petkov

From: Borislav Petkov <[email protected]>

Make it much simpler without losing the gist of what it says.

Cc Thomas Gleixner <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc "H. Peter Anvin" <[email protected]>
Cc Andrew Morton <[email protected]>
Cc Vivek Goyal <[email protected]>
---
 arch/x86/Kconfig | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)
arch/x86/Kconfig +0 -4
index 8f829ffb9003..8db84b0e5bbd 100644
@@ -1775,14 +1775,11 @@ config KEXEC_VERIFY_SIG
 	depends on KEXEC_FILE
 	---help---
 	  This option makes kernel signature verification mandatory for
-	  kexec_file_load() syscall. If kernel is signature can not be
-	  verified, kexec_file_load() will fail.
-
-	  This option enforces signature verification at generic level.

arch/x86/Kconfig config KEXEC_VERIFY_SIG · line 1783

Quoted 10 lines
arch/x86/Kconfig +5 -4
-	  One needs to enable signature verification for type of kernel
-	  image being loaded to make sure it works. For example, enable
-	  bzImage signature verification option to be able to load and
-	  verify signatures of bzImage. Otherwise kernel loading will fail.
+	  the kexec_file_load() syscall.
+
+	  In addition to that option, you need to enable signature
+	  verification for the corresponding kernel image type being
+	  loaded in order for this to work.
 

Hmm..., I find even previous text to be just fine. But as I wrote it, I might be biased. So I will leave it to others to decide.

Thanks
Vivek

author maintainer
#2 lore raw
Quoted 1 line · Vivek Goyal

Hmm..., I find even previous text to be just fine.

I'm not saying the previous text was not fine - I just made it shorter and faster to read, while retaining the information it conveys.

:)

Signature · 5 lines
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
#3 lore raw
In reply to Borislav Petkov
x86/kexec: Cleanup KEXEC_VERIFY_SIG Kconfig help text
Commit-ID:  d8eb8940417559808fdd0180a4d50f8f0281b822
Gitweb:     http://git.kernel.org/tip/d8eb8940417559808fdd0180a4d50f8f0281b822
Author:     Borislav Petkov <[email protected]>
AuthorDate: Fri, 13 Mar 2015 14:04:37 +0100
Committer:  Ingo Molnar <[email protected]>
CommitDate: Fri, 13 Mar 2015 14:21:58 +0100

x86/kexec: Cleanup KEXEC_VERIFY_SIG Kconfig help text

Fix typos and also make it simpler without losing the gist of what it says.

---
 arch/x86/Kconfig | 13 +++++--------
 1 file changed, 5 insertions(+), 8 deletions(-)
arch/x86/Kconfig +5 -8
index 78a3f67..867bc5b 100644
@@ -1742,14 +1742,11 @@ config KEXEC_VERIFY_SIG
 	depends on KEXEC_FILE
 	---help---
 	  This option makes kernel signature verification mandatory for
-	  kexec_file_load() syscall. If kernel is signature can not be
-	  verified, kexec_file_load() will fail.
-
-	  This option enforces signature verification at generic level.
-	  One needs to enable signature verification for type of kernel
-	  image being loaded to make sure it works. For example, enable
-	  bzImage signature verification option to be able to load and
-	  verify signatures of bzImage. Otherwise kernel loading will fail.
+	  the kexec_file_load() syscall.
+
+	  In addition to that option, you need to enable signature
+	  verification for the corresponding kernel image type being
+	  loaded in order for this to work.
 
 config KEXEC_BZIMAGE_VERIFY_SIG
 	bool "Enable bzImage signature verification support"