Skip to contentSkip to conversation

fftw: add compile precision option

PATCH Superseded Gwenhael Goavec-Merou 2 participants 2 messages Mar 14, 2015

v3 of 4 Superseded Latest is v4 →

lore
Share & tools
lore

Gwenhael Goavec-Merou

author
#0 lore raw

PATCH v3 1/1 fftw: add compile precision option

From: Gwenhael Goavec-Merou <[email protected]>

fftw has options to select compile precision between single, long-double and quad. These options are exclusives. This patch adds choice to select precision option.

Signed-off-by Gwenhael Goavec-Merou <[email protected]>

---
Changes v2 -> v3:
* add depends instruction for quad-precision. This option needs to have a toolchain with libquadmath enabled (only x86, x86_64 and Itanium).
Changes v1 -> v2:
* FFTW_CONFIGURE_OPTS -> FFTW_CONF_OPTS

---
 package/fftw/Config.in | 34 ++++++++++++++++++++++++++++++++++
 package/fftw/fftw.mk   |  9 +++++++++
 2 files changed, 43 insertions(+)
package/fftw/Config.in +34 -0
index 36f849f..03acb56 100644
@@ -9,3 +9,37 @@ config BR2_PACKAGE_FFTW
 	  double precision.
 
 	  http://www.fftw.org
+
+if BR2_PACKAGE_FFTW
+
+choice
+	prompt "fftw precision"
+	default BR2_PACKAGE_FFTW_PRECISION_NONE
+	help
+	  Selects fftw precision
+
+config BR2_PACKAGE_FFTW_PRECISION_NONE
+	bool "none"
+	help
+	  no compile precision selected
+
+config BR2_PACKAGE_FFTW_PRECISION_SINGLE
+	bool "single precision"
+	help
+	  compile fftw in single precision
+
+config BR2_PACKAGE_FFTW_PRECISION_LONG_DOUBLE
+	bool "long double precision"
+	help
+	  compile fftw in long-double precision
+
+config BR2_PACKAGE_FFTW_PRECISION_QUAD
+	bool "quad precision"
+	# quad-precision needs to have a gcc with libquadmath
+	depends on (BR2_i386 || BR2_x86_64) && BR2_USE_WCHAR
+	help
+	  compile fftw in quadruple precision if available
+
+endchoice
+
+endif
package/fftw/fftw.mk +9 -0
index 3b302df..80cc0dc 100644
@@ -10,4 +10,13 @@ FFTW_INSTALL_STAGING = YES
 FFTW_LICENSE = GPLv2+
 FFTW_LICENSE_FILES = COPYING
 
+ifeq ($(BR2_PACKAGE_FFTW_PRECISION_SINGLE),y)
+FFTW_CONF_OPTS = --enable-single
+endif
+ifeq ($(BR2_PACKAGE_FFTW_PRECISION_LONG_DOUBLE),y)
+FFTW_CONF_OPTS = --enable-long-double
+endif
+ifeq ($(BR2_PACKAGE_FFTW_PRECISION_QUAD),y)
+FFTW_CONF_OPTS = --enable-quad-precision
+endif
 $(eval $(autotools-package))
Signature · 1 line
2.0.5
#1 lore raw

PATCH v3 1/1 fftw: add compile precision option

Dear Gwenhael Goavec-Merou,

Quoted 3 lines · Gwenhael Goavec-Merou

Changes v2 -> v3:
* add depends instruction for quad-precision. This option needs to have a toolchain with libquadmath enabled (only x86, x86_64 and Itanium).

What did you do to fix long double precision? It also wasn't building, see my review of your PATCH v2.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com