Skip to contentSkip to conversation

Staging: lustre: Add newline after variable declarations.

PATCH In review Vatika Harlalka 2 participants 2 messages Mar 10, 2015 – Mar 15, 2015 Staging

lore
Share & tools
lore

Vatika Harlalka

author
#0 lore raw

PATCH 1/1 Staging: lustre: Add newline after variable declarations.

Added newline after variable declarations to
follow kernel code conventions.

Signed-off-by Vatika Harlalka <[email protected]>
---
 drivers/staging/lustre/lustre/llite/llite_nfs.c | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/lustre/lustre/llite/llite_nfs.c +1 -0
index 243a784..06a1212 100644
@@ -49,6 +49,7 @@
 __u32 get_uuid2int(const char *name, int len)
 {
 	__u32 key0 = 0x12a3fe2d, key1 = 0x37abe8f9;
+	
 	while (len--) {
 		__u32 key = key1 + (key0 ^ (*name++ * 7152373));
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 13 lines · Vatika Harlalka

Added newline after variable declarations to
follow kernel code conventions.

Signed-off-by Vatika Harlalka <[email protected]>
---
 drivers/staging/lustre/lustre/llite/llite_nfs.c | 1 +
 1 file changed, 1 insertion(+)
drivers/staging/lustre/lustre/llite/llite_nfs.c +0 -0
index 243a784..06a1212 100644

drivers/staging/lustre/lustre/llite/llite_nfs.c line 55

Quoted 7 lines
drivers/staging/lustre/lustre/llite/llite_nfs.c +1 -0
@@ -49,6 +49,7 @@
 __u32 get_uuid2int(const char *name, int len)
 {
 	__u32 key0 = 0x12a3fe2d, key1 = 0x37abe8f9;
+	
 	while (len--) {
 		__u32 key = key1 + (key0 ^ (*name++ * 7152373));

_ALWAYS_ run your patches through checkpatch.pl so that you don't have a maintainer tell you to run your patches through checkpatch.pl to fix the obvious issues with it :)

Hint, you fixed up one checkpatch warning, just to add another one, which isn't acceptable :(

greg k-h