Skip to contentSkip to conversation

Staging: fbtbt: Removed unneeded print messages

PATCH In review Vatika Harlalka 2 participants 2 messages Mar 13, 2015 – Mar 15, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Staging: fbtbt: Removed unneeded print messages

These print messages are removed as only indicate entry into the function or print the arguments but not any potential errors.

---
 drivers/staging/fbtft/fb_agm1264k-fl.c | 10 ----------
 1 file changed, 10 deletions(-)
drivers/staging/fbtft/fb_agm1264k-fl.c +0 -10
index acf5acb..9c41cc9 100644
@@ -75,8 +75,6 @@ static int init_display(struct fbtft_par *par)
 {
 	u8 i;
 
-	fbtft_par_dbg(DEBUG_INIT_DISPLAY, par, "%s()\n", __func__);
-
 	par->fbtftops.reset(par);
 
 	for (i = 0; i < 2; ++i) {
@@ -245,10 +243,6 @@ static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye)
 	addr_win.ys_page = ys / 8;
 	addr_win.xe = xe;
 	addr_win.ye_page = ye / 8;
-
-	fbtft_par_dbg(DEBUG_SET_ADDR_WIN, par,
-		"%s(xs=%d, ys_page=%d, xe=%d, ye_page=%d)\n", __func__,
-		addr_win.xs, addr_win.ys_page, addr_win.xe, addr_win.ye_page);
 }
 
 static void
@@ -284,7 +278,6 @@ static int write_vmem(struct fbtft_par *par, size_t offset, size_t len)
 	/* buffer to convert RGB565 -> grayscale16 -> Ditherd image 1bpp */
 	s16 *convert_buf = kmalloc(par->info->var.xres *
 		par->info->var.yres * sizeof(signed short), GFP_NOIO);
-	fbtft_par_dbg(DEBUG_WRITE_VMEM, par, "%s()\n", __func__);
 
 	/* converting to grayscale16 */
 	for (x = 0; x < par->info->var.xres; ++x)
@@ -412,9 +405,6 @@ static int write(struct fbtft_par *par, void *buf, size_t len)
 {
 	u8 i, data;
 
-	fbtft_par_dbg_hex(DEBUG_WRITE, par, par->info->device, u8, buf, len,
-		"%s(len=%d): ", __func__, len);
-
 	gpio_set_value(par->RW, 0); /* set write mode */
 
 	while (len--) {
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 8 lines · Vatika Harlalka

These print messages are removed as only indicate entry into the function or print the arguments but not any potential errors.

---
 drivers/staging/fbtft/fb_agm1264k-fl.c | 10 ----------
 1 file changed, 10 deletions(-)

This patch fails to apply to my tree :(