Skip to contentSkip to conversation

rtc: at91rm9200: double locking bug in at91_rtc_interrupt()

PATCH In review Dan Carpenter 4 participants 6 messages Mar 15, 2015 – Mar 18, 2015

Subsystems (3)
Kernel janitors Arm/Microchip (AT91) SoC support Real time clock (RTC)
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 rtc: at91rm9200: double locking bug in at91_rtc_interrupt()

There is a typo here so we deadlock.

Fixes dd1f1f391dd7 ('rtc: at91rm9200: rework wakeup and interrupt handling')
Signed-off-by Dan Carpenter <[email protected]>
drivers/rtc/rtc-at91rm9200.c +1 -1
index b4f7744..b283a1a 100644
@@ -324,7 +324,7 @@ static irqreturn_t at91_rtc_interrupt(int irq, void *dev_id)
 
 		ret = IRQ_HANDLED;
 	}
-	spin_lock(&suspended_lock);
+	spin_unlock(&suspended_lock);
 
 	return ret;
 }
Acked-by on v1 1/1
#1 lore raw

Hi Dan,

Quoted 4 lines · On Sun, 15 Mar 2015 13:48:37 +0300 Dan Carpenter <[email protected]>…

There is a typo here so we deadlock.

Fixes dd1f1f391dd7 ('rtc: at91rm9200: rework wakeup and interrupt handling')
Signed-off-by Dan Carpenter <[email protected]>
Acked-by Boris Brezillon <[email protected]>

Thanks for fixing this bug.

Alessandro, Nicolas, could you agree on who is taking this fix for the next -rc cycle ?

Best Regards,

Boris

Signature · 3 lines
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
#2 lore raw

PATCH 1/1 rtc: at91rm9200: double locking bug in at91_rtc_interrupt()

In reply to Dan Carpenter

From: Dan Carpenter <[email protected]>

There is a typo here so we deadlock.

Fixes dd1f1f391dd7 ('rtc: at91rm9200: rework wakeup and interrupt handling')
Signed-off-by Dan Carpenter <[email protected]>
Acked-by Boris Brezillon <[email protected]>
Reported-also-by David Dueck <[email protected]>
Signed-off-by Nicolas Ferre <[email protected]>

---
Hi Andrew,

Can you please take care of this fix for 4.0?
If you fee that I'd better take it myself please tell me.

Thanks, bye.

 drivers/rtc/rtc-at91rm9200.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rtc/rtc-at91rm9200.c +1 -1
index b4f7744f6751..b283a1a573b3 100644
@@ -324,7 +324,7 @@ static irqreturn_t at91_rtc_interrupt(int irq, void *dev_id)
 
 		ret = IRQ_HANDLED;
 	}
-	spin_lock(&suspended_lock);
+	spin_unlock(&suspended_lock);
 
 	return ret;
 }
Signature · 1 line
2.1.3
author
#3 lore raw
Quoted 1 line · Nicolas Ferre
Reported-also-by David Dueck <[email protected]>

The point of tags is that you collect them by doing:
git log | grep Reported-by: | sort | uniq -c | sort -rn to see if you are the winner. It gives me an unfair advantage if you get creative with David's tag.

regards,
dan carpenter

#4 lore raw
In reply to Nicolas Ferre
Quoted 9 lines · Nicolas Ferre

From: Dan Carpenter <[email protected]>

There is a typo here so we deadlock.

Fixes dd1f1f391dd7 ('rtc: at91rm9200: rework wakeup and interrupt handling')
Signed-off-by Dan Carpenter <[email protected]>
Acked-by Boris Brezillon <[email protected]>
Reported-also-by David Dueck <[email protected]>
Signed-off-by Nicolas Ferre <[email protected]>
Quoted 5 lines

---
Hi Andrew,

Can you please take care of this fix for 4.0?
If you fee that I'd better take it myself please tell me.

The commit being fixed went in through my tree, so I'll take this one if that's not a problem.

Quoted 17 lines
 drivers/rtc/rtc-at91rm9200.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rtc/rtc-at91rm9200.c +1 -1
index b4f7744f6751..b283a1a573b3 100644
@@ -324,7 +324,7 @@ static irqreturn_t at91_rtc_interrupt(int irq, void *dev_id)
 
 		ret = IRQ_HANDLED;
 	}
-	spin_lock(&suspended_lock);
+	spin_unlock(&suspended_lock);
 
 	return ret;
 }
Signature · 2 lines
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
Acked-by on v1 1/1
#5 lore raw
In reply to Dan Carpenter
Quoted 11 lines · Boris Brezillon

Hi Dan,

Quoted 4 lines · On Sun, 15 Mar 2015 13:48:37 +0300 Dan Carpenter <[email protected]>…

There is a typo here so we deadlock.

Fixes dd1f1f391dd7 ('rtc: at91rm9200: rework wakeup and interrupt handling')
Signed-off-by Dan Carpenter <[email protected]>
Acked-by Boris Brezillon <[email protected]>
Acked-by Nicolas Ferre <[email protected]>
Quoted 5 lines

Thanks for fixing this bug.

Alessandro, Nicolas, could you agree on who is taking this fix for the next -rc cycle ?

I've just collected the tags and asked to Andrew if he can take it.

Thanks for the fix and the "heads up"!

Bye,

Signature · 5 lines
Nicolas Ferre
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html