Skip to contentSkip to conversation

fastboot: Proper download gadget unregister and clear when cable is missing

PATCH New Paul Kocialkowski 2 participants 6 messages Mar 15, 2015 – Mar 22, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fastboot: Proper download gadget unregister and clear when cable is missing

---
 common/cmd_fastboot.c | 2 ++
 1 file changed, 2 insertions(+)
common/cmd_fastboot.c +2 -0
index 346ab80..7956a5b 100644
@@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
 	if (!g_dnl_board_usb_cable_connected()) {
 		puts("\rUSB cable not detected.\n" \
 		     "Command exit.\n");
+		g_dnl_unregister();
+		g_dnl_clear_detach();
 		return CMD_RET_FAILURE;
 	}
 
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 fastboot: Proper download gadget unregister and clear when cable is missing

Quoted 4 lines · Paul Kocialkowski
---
 common/cmd_fastboot.c | 2 ++
 1 file changed, 2 insertions(+)

+CC Lukasz and Steve.

common/cmd_fastboot.c static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int · line 29

Quoted 12 lines
common/cmd_fastboot.c +2 -0
index 346ab80..7956a5b 100644
@@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int
 argc, char *const argv[]) if (!g_dnl_board_usb_cable_connected()) {
 		puts("\rUSB cable not detected.\n" \
 		     "Command exit.\n");
+		g_dnl_unregister();
+		g_dnl_clear_detach();
 		return CMD_RET_FAILURE;
 	}

Best regards,
Marek Vasut

#2 lore raw

PATCH 1/1 fastboot: Proper download gadget unregister and clear when cable is missing

Hi,

Le dimanche 15 mars 2015 ? 19:12 +0100, Marek Vasut a ?crit :

Quoted 7 lines · Paul Kocialkowski
Quoted 4 lines
---
 common/cmd_fastboot.c | 2 ++
 1 file changed, 2 insertions(+)

+CC Lukasz and Steve.

Is there anything holding back that patch at this point?

Quoted 7 lines
Quoted 7 lines
common/cmd_fastboot.c +0 -0
index 346ab80..7956a5b 100644
@@ -23,6 +23,8 @@ static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int
 argc, char *const argv[]) if (!g_dnl_board_usb_cable_connected()) {
 		puts("\rUSB cable not detected.\n" \
Quoted 8 lines

common/cmd_fastboot.c static int do_fastboot(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) · line 29

Quoted 5 lines
common/cmd_fastboot.c +2 -0
 		     "Command exit.\n");
+		g_dnl_unregister();
+		g_dnl_clear_detach();
 		return CMD_RET_FAILURE;
 	}

Best regards,
Marek Vasut

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150322/c1b0d88a/attachment.sig>

#3 lore raw

PATCH 1/1 fastboot: Proper download gadget unregister and clear when cable is missing

Quoted 7 lines · Paul Kocialkowski

Hi,

Le dimanche 15 mars 2015 ? 19:12 +0100, Marek Vasut a ?crit :

Quoted 4 lines · Paul Kocialkowski
Quoted 3 lines

---

Quoted 6 lines
Quoted 4 lines
Quoted 2 lines
 common/cmd_fastboot.c | 2 ++
 1 file changed, 2 insertions(+)

+CC Lukasz and Steve.

Is there anything holding back that patch at this point?

Hi

Lukasz is the USB gadget side maintainer, so please wait for him to pick this.

Thanks

Best regards,
Marek Vasut

#4 lore raw

PATCH 1/1 fastboot: Proper download gadget unregister and clear when cable is missing

Le dimanche 22 mars 2015 ? 13:24 +0100, Marek Vasut a ?crit :

Quoted 11 lines · Paul Kocialkowski
Quoted 10 lines

Hi,

Le dimanche 15 mars 2015 ? 19:12 +0100, Marek Vasut a ?crit :

Quoted 7 lines · Paul Kocialkowski
Quoted 5 lines

---

 common/cmd_fastboot.c | 2 ++
 1 file changed, 2 insertions(+)
Quoted 8 lines
Quoted 3 lines
Quoted 1 line

+CC Lukasz and Steve.

Is there anything holding back that patch at this point?

Hi

Lukasz is the USB gadget side maintainer, so please wait for him to pick this.

Oh okay, I thought it was up to you, my mistake.

Signature · 16 lines
Paul Kocialkowski, Replicant developer

Replicant is a fully free Android distribution running on several
devices, a free software mobile operating system putting the emphasis on
freedom and privacy/security.

Website: http://www.replicant.us/
Blog: http://blog.replicant.us/
Wiki/tracker/forums: http://redmine.replicant.us/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150322/d0615c5b/attachment.sig>
#5 lore raw

PATCH 1/1 fastboot: Proper download gadget unregister and clear when cable is missing

Quoted 14 lines · Paul Kocialkowski

Le dimanche 22 mars 2015 ? 13:24 +0100, Marek Vasut a ?crit :

Quoted 13 lines · Paul Kocialkowski
Quoted 12 lines

Hi,

Le dimanche 15 mars 2015 ? 19:12 +0100, Marek Vasut a ?crit :

Quoted 8 lines · Paul Kocialkowski
Quoted 5 lines

---

 common/cmd_fastboot.c | 2 ++
 1 file changed, 2 insertions(+)

+CC Lukasz and Steve.

Quoted 8 lines
Quoted 6 lines
Quoted 1 line

Is there anything holding back that patch at this point?

Hi

Lukasz is the USB gadget side maintainer, so please wait for him to pick this.

Oh okay, I thought it was up to you, my mistake.

I can pick them in case Lukasz is inactive for too long, give it a week and ping me again in such case please.

Best regards,
Marek Vasut