Skip to contentSkip to conversation

Staging: fbtft: Split function call into two lines to improve readability

PATCH In review Vatika Harlalka 2 participants 2 messages Mar 15, 2015 – Mar 16, 2015

Subsystems (2)
Staging Fbtft Framebuffer drivers
lore
Share & tools
lore

Vatika Harlalka

author
#0 lore raw

PATCH v2 1/1 Staging: fbtft: Split function call into two lines to improve readability

Split function call to two lines improve code style and increase readability.

Signed-off-by Vatika Harlalka <[email protected]>

---
Changes in v2: Changed subject line to make it more
descriptive.

 drivers/staging/fbtft/fb_pcd8544.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/fbtft/fb_pcd8544.c +2 -1
index b13162c..0228f4f 100644
@@ -94,7 +94,8 @@ static int init_display(struct fbtft_par *par)
 
 static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye)
 {
-	fbtft_par_dbg(DEBUG_SET_ADDR_WIN, par, "%s(xs=%d, ys=%d, xe=%d, ye=%d)\n", __func__, xs, ys, xe, ye);
+	fbtft_par_dbg(DEBUG_SET_ADDR_WIN, par, "%s(xs=%d, ys=%d, xe=%d, ye=%d)\n",
+			__func__, xs, ys, xe, ye);
 
 	/* H=0 Set X address of RAM */
 	write_reg(par, 0x80); /* 7:1  1
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 16 lines · Vatika Harlalka

Split function call to two lines improve code style and increase readability.

Signed-off-by Vatika Harlalka <[email protected]>

---
Changes in v2: Changed subject line to make it more
descriptive.

 drivers/staging/fbtft/fb_pcd8544.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/staging/fbtft/fb_pcd8544.c +0 -0
index b13162c..0228f4f 100644

drivers/staging/fbtft/fb_pcd8544.c static int init_display(struct fbtft_par *par) · line 98

Quoted 6 lines
drivers/staging/fbtft/fb_pcd8544.c +2 -1
@@ -94,7 +94,8 @@ static int init_display(struct fbtft_par *par)
 
 static void set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye)
 {
-	fbtft_par_dbg(DEBUG_SET_ADDR_WIN, par, "%s(xs=%d, ys=%d, xe=%d, ye=%d)\n", __func__, xs, ys, xe, ye);
+	fbtft_par_dbg(DEBUG_SET_ADDR_WIN, par, "%s(xs=%d, ys=%d, xe=%d, ye=%d)\n",
+			__func__, xs, ys, xe, ye);

These types of "tracing" calls can all be removed, they aren't needed as we have a build-in kernel tracing function.

thanks,

greg k-h