Skip to contentSkip to conversation

wine: Add gettext dependency for host-wine

PATCH New André Hentschel 3 participants 4 messages Mar 15, 2015 – Mar 16, 2015

lore
Share & tools
lore

André Hentschel

author
#0 lore raw

PATCH v4 1/1 wine: Add gettext dependency for host-wine

Mostly based on a comment by Yann E. MORIN

Signed-off-by Andr? Hentschel <[email protected]>
Cc Yann E. MORIN <[email protected]>
---
 package/wine/wine.mk | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/wine/wine.mk +4 -2
index aa474f9..a699fff 100644
@@ -243,6 +243,10 @@ else
 WINE_CONF_OPTS += --without-zlib
 endif
 
+# host-gettext is essential for .po file support in host-wine wrc
+HOST_WINE_DEPENDENCIES += host-gettext
+HOST_WINE_CONF_OPTS += --with-gettext --with-gettextpo
+
 # Wine needs to enable 64-bit build tools on 64-bit host
 ifeq ($(HOSTARCH),x86_64)
 HOST_WINE_CONF_OPTS += --enable-win64

@@ -280,8 +284,6 @@ HOST_WINE_CONF_OPTS += \
 	--without-curses \
 	--without-dbus \
 	--without-fontconfig \
-	--without-gettext \
-	--without-gettextpo \
 	--without-gphoto \
 	--without-glu \
 	--without-gnutls \
Signature · 1 line
1.9.1
#1 lore raw

PATCH v4 1/1 wine: Add gettext dependency for host-wine

And?, All,

On 2015-03-15 12:35 +0100, Andr? Hentschel spake thusly:

Quoted 13 lines

Mostly based on a comment by Yann E. MORIN

Signed-off-by Andr? Hentschel <[email protected]>
Cc Yann E. MORIN <[email protected]>
---
 package/wine/wine.mk | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/wine/wine.mk +0 -0
index aa474f9..a699fff 100644

package/wine/wine.mk else · line 248

Quoted 6 lines
package/wine/wine.mk +3 -0
@@ -243,6 +243,10 @@ else
 WINE_CONF_OPTS += --without-zlib
 endif
 
+# host-gettext is essential for .po file support in host-wine wrc
+HOST_WINE_DEPENDENCIES += host-gettext
+HOST_WINE_CONF_OPTS += --with-gettext --with-gettextpo

How can I test that?

I mean, I have no x86 target (for now), so how can I check that this patch does produce the expected output?

Regards,
Yann E. MORIN.

Quoted 19 lines
package/wine/wine.mk +0 -2
 # Wine needs to enable 64-bit build tools on 64-bit host
 ifeq ($(HOSTARCH),x86_64)
 HOST_WINE_CONF_OPTS += --enable-win64

@@ -280,8 +284,6 @@ HOST_WINE_CONF_OPTS += \
 	--without-curses \
 	--without-dbus \
 	--without-fontconfig \
-	--without-gettext \
-	--without-gettextpo \
 	--without-gphoto \
 	--without-glu \
 	--without-gnutls \
Signature · 6 lines
1.9.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
#2 lore raw

PATCH v4 1/1 wine: Add gettext dependency for host-wine

In reply to André Hentschel

Andr?, All,

On 2015-03-15 12:35 +0100, Andr? Hentschel spake thusly:

Quoted 4 lines

Mostly based on a comment by Yann E. MORIN

Signed-off-by Andr? Hentschel <[email protected]>
Cc Yann E. MORIN <[email protected]>
Tested-by "Yann E. MORIN" <[email protected]>

[tested by running readelf on 'wrc' and checking it is now linked
with libgettextpo.so.0]

Reviewed-by "Yann E. MORIN" <[email protected]>

Regards,
Yann E. MORIN.

Quoted 35 lines
---
 package/wine/wine.mk | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
package/wine/wine.mk +4 -2
index aa474f9..a699fff 100644
@@ -243,6 +243,10 @@ else
 WINE_CONF_OPTS += --without-zlib
 endif
 
+# host-gettext is essential for .po file support in host-wine wrc
+HOST_WINE_DEPENDENCIES += host-gettext
+HOST_WINE_CONF_OPTS += --with-gettext --with-gettextpo
+
 # Wine needs to enable 64-bit build tools on 64-bit host
 ifeq ($(HOSTARCH),x86_64)
 HOST_WINE_CONF_OPTS += --enable-win64

@@ -280,8 +284,6 @@ HOST_WINE_CONF_OPTS += \
 	--without-curses \
 	--without-dbus \
 	--without-fontconfig \
-	--without-gettext \
-	--without-gettextpo \
 	--without-gphoto \
 	--without-glu \
 	--without-gnutls \
Signature · 6 lines
1.9.1

_______________________________________________
buildroot mailing list
buildroot at busybox.net
http://lists.busybox.net/mailman/listinfo/buildroot
Signature · 6 lines
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'