zsmalloc: zsmalloc documentation

Quoted 23 lines · On Thu, 5 Mar 2015 09:43:31 +0900 Minchan Kim <[email protected]> wrote:

Hello Andrew,

Quoted 11 lines · Andrew Morton

Quoted 9 lines · On Wed, 4 Mar 2015 14:01:32 +0900 Minchan Kim <[email protected]> wrote:

(quoted diff) +9 -0

+static int zs_stats_size_show(struct seq_file *s, void *v)
+{
+	int i;
+	struct zs_pool *pool = s->private;
+	struct size_class *class;
+	int objs_per_zspage;
+	unsigned long class_almost_full, class_almost_empty;
+	unsigned long obj_allocated, obj_used, pages_used;
+	unsigned long total_class_almost_full = 0, total_class_almost_empty = 0;

Quoted 8 lines

Review

Quoted 6 lines

(quoted diff) +6 -0

+	unsigned long total_objs = 0, total_used_objs = 0, total_pages = 0;
+
+	seq_printf(s, " %5s %5s %11s %12s %13s %10s %10s %16s\n",
+			"class", "size", "almost_full", "almost_empty",
+			"obj_allocated", "obj_used", "pages_used",
+			"pages_per_zspage");

Documentation?

Quoted 8 lines

It should been since [0f050d9, mm/zsmalloc: add statistics support]. Anyway, I will try it.
Where is right place to put only this statistics in Documentation?

Documentation/zsmalloc.txt?
Documentation/vm/zsmalloc.txt?
Documentation/blockdev/zram.txt?
Documentation/ABI/testing/sysfs-block-zram?

hm, this is debugfs so Documentation/ABI/testing/sysfs-block-zram isn't the right place.

akpm3:/usr/src/25> grep -rli zsmalloc Documentation akpm3:/usr/src/25>

lol.

Documentation/vm/zsmalloc.txt looks good.