Skip to contentSkip to conversation

drm/rcar-du: Avoid restarting when shutting down

PATCH New Magnus Damm 1 participant 1 message Mar 17, 2015

Subsystems (4)
DRM drivers DRM misc SuperH Arm/RISC-V/Renesas architecture
lore
Share & tools
lore

Magnus Damm

author maintainer
#0 lore raw

PATCH 1/1 drm/rcar-du: Avoid restarting when shutting down

From: Magnus Damm <[email protected]>

This is a prototype patch that removes one DU restart operation from the shutdown sequence. With this in place both the required time for mode switching is reduced and so is the amount of flicker.

Needs to be reworked to fit on top of atomic update support.

Not-Yet-Signed-off-by Magnus Damm <[email protected]>

---

 drivers/gpu/drm/rcar-du/rcar_du_crtc.c |   11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
drivers/gpu/drm/rcar-du/rcar_du_crtc.c +8 -3
@@ -187,7 +187,7 @@ void rcar_du_crtc_route_output(struct dr
 		rcdu->dpad0_source = rcrtc->index;
 }
 
-void rcar_du_crtc_update_planes(struct drm_crtc *crtc)
+static void __rcar_du_crtc_update_planes(struct drm_crtc *crtc, bool restart)
 {
 	struct rcar_du_crtc *rcrtc = to_rcar_crtc(crtc);
 	struct rcar_du_plane *planes[RCAR_DU_NUM_HW_PLANES];

@@ -247,7 +247,7 @@ void rcar_du_crtc_update_planes(struct d
 		 */
 		if (value != dptsr) {
 			rcar_du_group_write(rcrtc->group, DPTSR, dptsr);
-			if (rcrtc->group->used_crtcs)
+			if (restart && rcrtc->group->used_crtcs)
 				rcar_du_group_restart(rcrtc->group);
 		}
 	}

@@ -256,6 +256,11 @@ void rcar_du_crtc_update_planes(struct d
 			    dspr);
 }
 
+void rcar_du_crtc_update_planes(struct drm_crtc *crtc)
+{
+	__rcar_du_crtc_update_planes(crtc, true);
+}
+
 static void rcar_du_crtc_start(struct rcar_du_crtc *rcrtc)
 {
 	struct drm_crtc *crtc = &rcrtc->crtc;

@@ -314,7 +319,7 @@ static void rcar_du_crtc_stop(struct rca
 
 	mutex_lock(&rcrtc->group->planes.lock);
 	rcrtc->plane->enabled = false;
-	rcar_du_crtc_update_planes(crtc);
+	__rcar_du_crtc_update_planes(crtc, false);
 	mutex_unlock(&rcrtc->group->planes.lock);
 
 	/* Select switch sync mode. This stops display operation and configures