Skip to contentSkip to conversation

package/sysdig: New package

PATCH Superseded Angelo Compagnucci 3 participants 6 messages Mar 17, 2015

v2 of 10 Superseded Latest is v10 →

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 package/sysdig: New package

Sysdig is open source, system-level exploration:
capture system state and activity from a running Linux instance, then save, filter and analyze.

---

Changes v1 -> v2:
- Changed "depends on" with "select" for dependencies (suggested by Baruch)
- Added comment "sysdig needs a Linux kernel to be built" (suggested by Baruch)
- Upgreded to recently released 0.1.99

 package/Config.in        |  1 +
 package/sysdig/Config.in | 17 +++++++++++++++++
 package/sysdig/sysdig.mk | 22 ++++++++++++++++++++++
 3 files changed, 40 insertions(+)
 create mode 100644 package/sysdig/Config.in
 create mode 100644 package/sysdig/sysdig.mk
package/Config.in +1 -0
index e221deb..019d40b 100644
@@ -94,6 +94,7 @@ endif
 	source "package/strace/Config.in"
 	source "package/stress/Config.in"
 	source "package/sysprof/Config.in"
+	source "package/sysdig/Config.in"
 	source "package/tinymembench/Config.in"
 	source "package/trace-cmd/Config.in"
 	source "package/trinity/Config.in"
package/sysdig/Config.in new file +17 -0
new file mode 100644
index 0000000..94b088f
@@ -0,0 +1,17 @@
+comment "sysdig needs a Linux kernel to be built"
+	depends on !BR2_LINUX_KERNEL
+
+config BR2_PACKAGE_SYSDIG
+	bool "sysdig"
+	select BR2_PACKAGE_ZLIB
+	select BR2_PACKAGE_LUAJIT
+	select BR2_PACKAGE_LIBJSON
+	depends on BR2_LINUX_KERNEL
+	help
+	  Sysdig is open source, system-level exploration:
+	  capture system state and activity from a running Linux instance,
+	  then save, filter and analyze.
+	  Think of it as strace + tcpdump + lsof + awesome sauce.
+	  With a little Lua cherry on top.
+
+	  http://sysdig.org
package/sysdig/sysdig.mk new file +22 -0
new file mode 100644
index 0000000..62b9344
@@ -0,0 +1,22 @@
+#############################################################
+#
+# sysdig
+#
+#############################################################
+
+SYSDIG_VERSION = 0.1.99
+SYSDIG_SITE = $(call github,draios,sysdig,$(SYSDIG_VERSION))
+SYSDIG_LICENSE = GPLv2
+SYSDIG_LICENSE_FILES = COPYING
+SYSDIG_CONF_OPTS = -DUSE_BUNDLED_LUAJIT=OFF -DUSE_BUNDLED_ZLIB=OFF
+SYSDIG_DEPENDENCIES += zlib luajit libjson linux
+SYSDIG_SUPPORTS_IN_SOURCE_BUILD = NO
+
+define SYSDIG_INSTALL_DRIVER
+	$(MAKE) $(LINUX_MAKE_FLAGS) -C $(LINUX_DIR) M=$(@D)/driver modules
+	$(MAKE) $(LINUX_MAKE_FLAGS) -C $(LINUX_DIR) M=$(@D)/driver modules_install
+endef
+
+SYSDIG_POST_INSTALL_TARGET_HOOKS += SYSDIG_INSTALL_DRIVER
+
+$(eval $(cmake-package))
Signature · 1 line
1.9.1
#1 lore raw

PATCH v2 1/1 package/sysdig: New package

Hi Angelo,

Quoted 6 lines · Angelo Compagnucci
package/sysdig/Config.in new file +0 -0
new file mode 100644
index 0000000..94b088f

package/sysdig/Config.in line 8

Quoted 8 lines
package/sysdig/Config.in new file +8 -0
@@ -0,0 +1,17 @@
+comment "sysdig needs a Linux kernel to be built"
+	depends on !BR2_LINUX_KERNEL
+
+config BR2_PACKAGE_SYSDIG
+	bool "sysdig"
+	select BR2_PACKAGE_ZLIB
+	select BR2_PACKAGE_LUAJIT
+	select BR2_PACKAGE_LIBJSON

This packages also needs to depend on all the dependencies of these packages. Please read the whole section under
http://nightly.buildroot.org/manual.html#depends-on-vs-select.

package/sysdig/Config.in line 17

Quoted 9 lines
package/sysdig/Config.in new file +9 -0
+	depends on BR2_LINUX_KERNEL
+	help
+	  Sysdig is open source, system-level exploration:
+	  capture system state and activity from a running Linux instance,
+	  then save, filter and analyze.
+	  Think of it as strace + tcpdump + lsof + awesome sauce.
+	  With a little Lua cherry on top.
+
+	  http://sysdig.org

A dependencies comment is still missing here
(http://nightly.buildroot.org/manual.html#_dependencies_on_a_linux_kernel_built_by_buildroot).

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#2 lore raw

PATCH v2 1/1 package/sysdig: New package

Hi Baruch,

2015-03-17 12:23 GMT+01:00 Baruch Siach <[email protected]>:

Quoted 13 lines

Hi Angelo,

Quoted 10 lines · Angelo Compagnucci
package/sysdig/Config.in new file +4 -0
new file mode 100644
index 0000000..94b088f
@@ -0,0 +1,17 @@
+comment "sysdig needs a Linux kernel to be built"
+     depends on !BR2_LINUX_KERNEL
+
+config BR2_PACKAGE_SYSDIG
Quoted 8 lines

package/sysdig/Config.in line 8

Quoted 4 lines
package/sysdig/Config.in new file +4 -0
+     bool "sysdig"
+     select BR2_PACKAGE_ZLIB
+     select BR2_PACKAGE_LUAJIT
+     select BR2_PACKAGE_LIBJSON

This packages also needs to depend on all the dependencies of these packages. Please read the whole section under
http://nightly.buildroot.org/manual.html#depends-on-vs-select.

Now I understand because Thomas Petazzoni suggests to use depends on insted of select!

Quoted 11 lines

package/sysdig/Config.in line 17

Quoted 10 lines
package/sysdig/Config.in new file +9 -0
+     depends on BR2_LINUX_KERNEL
+     help
+       Sysdig is open source, system-level exploration:
+       capture system state and activity from a running Linux instance,
+       then save, filter and analyze.
+       Think of it as strace + tcpdump + lsof + awesome sauce.
+       With a little Lua cherry on top.
+
+       http://sysdig.org
Quoted 2 lines

A dependencies comment is still missing here
(http://nightly.buildroot.org/manual.html#_dependencies_on_a_linux_kernel_built_by_buildroot).

The comment is there:

@@ -0,0 +1,17 @@
+comment "sysdig needs a Linux kernel to be built"
+ depends on !BR2_LINUX_KERNEL

Sincerely, Angelo

Quoted 7 lines

baruch

--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

Signature · 1 line
Profile: http://it.linkedin.com/in/compagnucciangelo
#3 lore raw

PATCH v2 1/1 package/sysdig: New package

Hi Angelo,

Quoted 18 lines · Angelo Compagnucci

2015-03-17 12:23 GMT+01:00 Baruch Siach <[email protected]>:

Quoted 11 lines · Angelo Compagnucci

package/sysdig/Config.in line 17

Quoted 9 lines
package/sysdig/Config.in new file +9 -0
+     depends on BR2_LINUX_KERNEL
+     help
+       Sysdig is open source, system-level exploration:
+       capture system state and activity from a running Linux instance,
+       then save, filter and analyze.
+       Think of it as strace + tcpdump + lsof + awesome sauce.
+       With a little Lua cherry on top.
+
+       http://sysdig.org
Quoted 2 lines

A dependencies comment is still missing here
(http://nightly.buildroot.org/manual.html#_dependencies_on_a_linux_kernel_built_by_buildroot).

The comment is there:

package/sysdig/Config.in line 2

Quoted 2 lines
package/sysdig/Config.in new file +2 -0
@@ -0,0 +1,17 @@
+comment "sysdig needs a Linux kernel to be built"
+ depends on !BR2_LINUX_KERNEL

You are right, I missed that. It's just that I'm used to see these comments below the main 'config' section. Putting the comment above is also fine, though. Don't forget to update this comment when adding indirect dependencies.

baruch

Signature · 3 lines
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
#4 lore raw

PATCH v2 1/1 package/sysdig: New package

Dear Baruch Siach,

2015-03-17 12:48 GMT+01:00 Baruch Siach <[email protected]>:

Quoted 20 lines

Hi Angelo,

Quoted 17 lines · Angelo Compagnucci

2015-03-17 12:23 GMT+01:00 Baruch Siach <[email protected]>:

Quoted 11 lines · Angelo Compagnucci

package/sysdig/Config.in line 17

Quoted 9 lines
package/sysdig/Config.in new file +9 -0
+     depends on BR2_LINUX_KERNEL
+     help
+       Sysdig is open source, system-level exploration:
+       capture system state and activity from a running Linux instance,
+       then save, filter and analyze.
+       Think of it as strace + tcpdump + lsof + awesome sauce.
+       With a little Lua cherry on top.
+
+       http://sysdig.org
Quoted 2 lines

A dependencies comment is still missing here
(http://nightly.buildroot.org/manual.html#_dependencies_on_a_linux_kernel_built_by_buildroot).

The comment is there:

Quoted 7 lines

package/sysdig/Config.in line 2

Quoted 3 lines
package/sysdig/Config.in new file +2 -0
@@ -0,0 +1,17 @@
+comment "sysdig needs a Linux kernel to be built"
+ depends on !BR2_LINUX_KERNEL

You are right, I missed that. It's just that I'm used to see these comments below the main 'config' section. Putting the comment above is also fine, though. Don't forget to update this comment when adding indirect dependencies.

I think that if I use select, the dependencies of this package will explode. I think I can use select for simple, non problematic packages, and use depends on for others.

I'll submit a patch in minutes!

Sincerely, Angelo

Quoted 7 lines

baruch

--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

Signature · 1 line
Profile: http://it.linkedin.com/in/compagnucciangelo
#5 lore raw

PATCH v2 1/1 package/sysdig: New package

Dear Angelo Compagnucci,

Quoted 7 lines · Angelo Compagnucci
Quoted 3 lines

You are right, I missed that. It's just that I'm used to see these comments below the main 'config' section. Putting the comment above is also fine, though. Don't forget to update this comment when adding indirect dependencies.

I think that if I use select, the dependencies of this package will explode. I think I can use select for simple, non problematic packages, and use depends on for others.

No. Please follow what Baruch said: use 'select' for BR2_PACKAGE_ZLIB, BR2_PACKAGE_LUAJIT and BR2_PACKAGE_LIBJSON, and a 'depends on' for BR2_LINUX_KERNEL.

Also, are you sure sysdig only works with LuaJIT, or does it also work with the "normal" Lua interpreter?

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com