Skip to contentSkip to conversation

package/sysdig: New package

PATCH Superseded Angelo Compagnucci 3 participants 4 messages Mar 17, 2015 – Mar 20, 2015

v4 of 10 Superseded Latest is v10 →

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 package/sysdig: New package

Sysdig is open source, system-level exploration:
capture system state and activity from a running Linux instance, then save, filter and analyze.

---
Changes v3 -> v4:
- Changed "depends on" to "select" and fixed selected packages dependencies.
- moved "comment" section to the bottom

Changes v2 -> v3:
- Changed "depends on" and "select" to simplify package

Changes v1 -> v2:
- Changed "depends on" with "select" for dependencies (suggested by Baruch)
- Added comment "sysdig needs a Linux kernel to be built" (suggested by Baruch)
- Upgreded to recently released 0.1.99

 package/Config.in        |  1 +
 package/sysdig/Config.in | 22 ++++++++++++++++++++++
 package/sysdig/sysdig.mk | 22 ++++++++++++++++++++++
 3 files changed, 45 insertions(+)
 create mode 100644 package/sysdig/Config.in
 create mode 100644 package/sysdig/sysdig.mk
package/Config.in +1 -0
index e221deb..019d40b 100644
@@ -94,6 +94,7 @@ endif
 	source "package/strace/Config.in"
 	source "package/stress/Config.in"
 	source "package/sysprof/Config.in"
+	source "package/sysdig/Config.in"
 	source "package/tinymembench/Config.in"
 	source "package/trace-cmd/Config.in"
 	source "package/trinity/Config.in"
package/sysdig/Config.in new file +22 -0
new file mode 100644
index 0000000..52c3703
@@ -0,0 +1,22 @@
+config BR2_PACKAGE_SYSDIG
+	bool "sysdig"
+	select BR2_PACKAGE_ZLIB
+	select BR2_PACKAGE_LUAJIT
+	select BR2_PACKAGE_LIBJSON
+	depends on BR2_LINUX_KERNEL
+	depends on BR2_INSTALL_LIBSTDCPP #Libjson
+	depends on BR2_i386 || (BR2_x86_64 && BR2_HOSTARCH='x86_64') \
+		|| BR2_powerpc || BR2_arm || BR2_armeb \
+		|| ((BR2_mips || BR2_mipsel) && !BR2_MIPS_SOFT_FLOAT) #Luajit
+	help
+	  Sysdig is open source, system-level exploration:
+	  capture system state and activity from a running Linux instance,
+	  then save, filter and analyze.
+	  Think of it as strace + tcpdump + lsof + awesome sauce.
+	  With a little Lua cherry on top.
+
+	  http://sysdig.org
+
+comment "sysdig needs a toolchain w/ C++ and a Linux kernel to be built"
+	depends on !BR2_LINUX_KERNEL
+	depends on !BR2_INSTALL_LIBSTDCPP
package/sysdig/sysdig.mk new file +22 -0
new file mode 100644
index 0000000..1bed0c0
@@ -0,0 +1,22 @@
+#############################################################
+#
+# sysdig
+#
+#############################################################
+
+SYSDIG_VERSION = 0.1.99
+SYSDIG_SITE = $(call github,draios,sysdig,$(SYSDIG_VERSION))
+SYSDIG_LICENSE = GPLv2
+SYSDIG_LICENSE_FILES = COPYING
+SYSDIG_CONF_OPTS = -DUSE_BUNDLED_LUAJIT=OFF -DUSE_BUNDLED_ZLIB=OFF
+SYSDIG_DEPENDENCIES += zlib luajit libjson linux
+SYSDIG_SUPPORTS_IN_SOURCE_BUILD = NO
+
+define SYSDIG_INSTALL_DRIVER
+	$(MAKE) $(LINUX_MAKE_FLAGS) -C $(LINUX_DIR) M=$(@D)/driver modules
+	$(MAKE) $(LINUX_MAKE_FLAGS) -C $(LINUX_DIR) M=$(@D)/driver modules_install
+endef
+
+SYSDIG_POST_INSTALL_TARGET_HOOKS += SYSDIG_INSTALL_DRIVER
+
+$(eval $(cmake-package))
Signature · 1 line
1.9.1
#1 lore raw

PATCH v4 1/1 package/sysdig: New package

Dear Angelo Compagnucci,

package/sysdig/Config.in line 4

Quoted 10 lines · Angelo Compagnucci
package/sysdig/Config.in new file +4 -0
new file mode 100644
index 0000000..52c3703
@@ -0,0 +1,22 @@
+config BR2_PACKAGE_SYSDIG
+	bool "sysdig"
+	select BR2_PACKAGE_ZLIB
+	select BR2_PACKAGE_LUAJIT

Unless I missed it, you did not reply to my question: is LuaJIT mandatory, or can sysdig use the normal Lua interpreter as well?

package/sysdig/Config.in line 7

Quoted 3 lines
package/sysdig/Config.in new file +3 -0
+	select BR2_PACKAGE_LIBJSON
+	depends on BR2_LINUX_KERNEL
+	depends on BR2_INSTALL_LIBSTDCPP #Libjson

Nitpick: # libjson

(i.e space after #, and lowercase package name)

package/sysdig/Config.in line 10

Quoted 3 lines
package/sysdig/Config.in new file +3 -0
+	depends on BR2_i386 || (BR2_x86_64 && BR2_HOSTARCH='x86_64') \
+		|| BR2_powerpc || BR2_arm || BR2_armeb \
+		|| ((BR2_mips || BR2_mipsel) && !BR2_MIPS_SOFT_FLOAT) #Luajit

Please introduce a BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS hidden option in luajit/Config.in, and use it in both luajit/Config.in and here. See what Samuel did with the BR2_PACKAGE_CMAKE_ARCH_SUPPORTS option today.

package/sysdig/Config.in line 22

Quoted 3 lines
package/sysdig/Config.in new file +3 -0
+comment "sysdig needs a toolchain w/ C++ and a Linux kernel to be built"
+	depends on !BR2_LINUX_KERNEL
+	depends on !BR2_INSTALL_LIBSTDCPP

depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS

package/sysdig/Config.in line 19

Quoted 6 lines
package/sysdig/Config.in new file +6 -0
+SYSDIG_VERSION = 0.1.99
+SYSDIG_SITE = $(call github,draios,sysdig,$(SYSDIG_VERSION))
+SYSDIG_LICENSE = GPLv2
+SYSDIG_LICENSE_FILES = COPYING
+SYSDIG_CONF_OPTS = -DUSE_BUNDLED_LUAJIT=OFF -DUSE_BUNDLED_ZLIB=OFF
+SYSDIG_DEPENDENCIES += zlib luajit libjson linux

Replace += by = here.

Thanks!

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#2 lore raw

PATCH v4 1/1 package/sysdig: New package

Dear Thomas Petazzoni,

Quoted 2 lines

Unless I missed it, you did not reply to my question: is LuaJIT mandatory, or can sysdig use the normal Lua interpreter as well?

Sorry, you are right. Unfortunately sysdig depend on Luajit, you can find more info here [1].

Quoted 8 lines

package/sysdig/Config.in line 7

Quoted 4 lines
package/sysdig/Config.in new file +3 -0
+     select BR2_PACKAGE_LIBJSON
+     depends on BR2_LINUX_KERNEL
+     depends on BR2_INSTALL_LIBSTDCPP #Libjson

Nitpick: # libjson

(i.e space after #, and lowercase package name)

Ok!

Quoted 8 lines

package/sysdig/Config.in line 10

Quoted 4 lines
package/sysdig/Config.in new file +3 -0
+     depends on BR2_i386 || (BR2_x86_64 && BR2_HOSTARCH='x86_64') \
+             || BR2_powerpc || BR2_arm || BR2_armeb \
+             || ((BR2_mips || BR2_mipsel) && !BR2_MIPS_SOFT_FLOAT) #Luajit

Please introduce a BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS hidden option in luajit/Config.in, and use it in both luajit/Config.in and here. See what Samuel did with the BR2_PACKAGE_CMAKE_ARCH_SUPPORTS option today.

Ok!

Quoted 7 lines

package/sysdig/Config.in line 22

Quoted 4 lines
package/sysdig/Config.in new file +3 -0
+comment "sysdig needs a toolchain w/ C++ and a Linux kernel to be built"
+     depends on !BR2_LINUX_KERNEL
+     depends on !BR2_INSTALL_LIBSTDCPP

depends on BR2_PACKAGE_LUAJIT_ARCH_SUPPORTS

Quoted 8 lines

package/sysdig/sysdig.mk line 12

Quoted 6 lines
package/sysdig/sysdig.mk new file +6 -0
+SYSDIG_VERSION = 0.1.99
+SYSDIG_SITE = $(call github,draios,sysdig,$(SYSDIG_VERSION))
+SYSDIG_LICENSE = GPLv2
+SYSDIG_LICENSE_FILES = COPYING
+SYSDIG_CONF_OPTS = -DUSE_BUNDLED_LUAJIT=OFF -DUSE_BUNDLED_ZLIB=OFF
+SYSDIG_DEPENDENCIES += zlib luajit libjson linux

Replace += by = here.

Ok!

Quoted 2 lines

Thanks!

Thank you too!

Sincerely, Angelo

Quoted 6 lines

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[1] http://www.sysdig.org/wiki/how-to-install-sysdig-from-the-source-code/

Signature · 1 line
Profile: http://it.linkedin.com/in/compagnucciangelo
#3 lore raw

PATCH v4 1/1 package/sysdig: New package

In reply to Angelo Compagnucci

Hi Angelo,

Quoted 72 lines

Sysdig is open source, system-level exploration:
capture system state and activity from a running Linux instance, then save, filter and analyze.

---
Changes v3 -> v4:
- Changed "depends on" to "select" and fixed selected packages dependencies.
- moved "comment" section to the bottom

Changes v2 -> v3:
- Changed "depends on" and "select" to simplify package

Changes v1 -> v2:
- Changed "depends on" with "select" for dependencies (suggested by Baruch)
- Added comment "sysdig needs a Linux kernel to be built" (suggested by Baruch)
- Upgreded to recently released 0.1.99

  package/Config.in        |  1 +
  package/sysdig/Config.in | 22 ++++++++++++++++++++++
  package/sysdig/sysdig.mk | 22 ++++++++++++++++++++++
  3 files changed, 45 insertions(+)

create mode 100644 package/sysdig/Config.in
create mode 100644 package/sysdig/sysdig.mk

package/Config.in +1 -0
index e221deb..019d40b 100644
@@ -94,6 +94,7 @@ endif
  	source "package/strace/Config.in"
  	source "package/stress/Config.in"
  	source "package/sysprof/Config.in"
+	source "package/sysdig/Config.in"
  	source "package/tinymembench/Config.in"
  	source "package/trace-cmd/Config.in"
  	source "package/trinity/Config.in"
package/sysdig/Config.in new file +22 -0
new file mode 100644
index 0000000..52c3703
@@ -0,0 +1,22 @@
+config BR2_PACKAGE_SYSDIG
+	bool "sysdig"
+	select BR2_PACKAGE_ZLIB
+	select BR2_PACKAGE_LUAJIT
+	select BR2_PACKAGE_LIBJSON
+	depends on BR2_LINUX_KERNEL
+	depends on BR2_INSTALL_LIBSTDCPP #Libjson
+	depends on BR2_i386 || (BR2_x86_64 && BR2_HOSTARCH='x86_64') \
+		|| BR2_powerpc || BR2_arm || BR2_armeb \
+		|| ((BR2_mips || BR2_mipsel) && !BR2_MIPS_SOFT_FLOAT) #Luajit
+	help
+	  Sysdig is open source, system-level exploration:
+	  capture system state and activity from a running Linux instance,
+	  then save, filter and analyze.
+	  Think of it as strace + tcpdump + lsof + awesome sauce.
+	  With a little Lua cherry on top.
+
+	  http://sysdig.org
+
+comment "sysdig needs a toolchain w/ C++ and a Linux kernel to be built"
+	depends on !BR2_LINUX_KERNEL
+	depends on !BR2_INSTALL_LIBSTDCPP
package/sysdig/sysdig.mk new file +0 -0
new file mode 100644
index 0000000..1bed0c0

package/sysdig/sysdig.mk line 1

Quoted 1 line
package/sysdig/sysdig.mk new file +1 -0
@@ -0,0 +1,22 @@
+#############################################################

This and ...

package/sysdig/sysdig.mk line 5

Quoted 4 lines
package/sysdig/sysdig.mk new file +4 -0
+#
+# sysdig
+#
+#############################################################

... that separator should consist of 80 #'es.

Regards,
Jerzy

Quoted 17 lines
package/sysdig/sysdig.mk new file +17 -0
+
+SYSDIG_VERSION = 0.1.99
+SYSDIG_SITE = $(call github,draios,sysdig,$(SYSDIG_VERSION))
+SYSDIG_LICENSE = GPLv2
+SYSDIG_LICENSE_FILES = COPYING
+SYSDIG_CONF_OPTS = -DUSE_BUNDLED_LUAJIT=OFF -DUSE_BUNDLED_ZLIB=OFF
+SYSDIG_DEPENDENCIES += zlib luajit libjson linux
+SYSDIG_SUPPORTS_IN_SOURCE_BUILD = NO
+
+define SYSDIG_INSTALL_DRIVER
+	$(MAKE) $(LINUX_MAKE_FLAGS) -C $(LINUX_DIR) M=$(@D)/driver modules
+	$(MAKE) $(LINUX_MAKE_FLAGS) -C $(LINUX_DIR) M=$(@D)/driver modules_install
+endef
+
+SYSDIG_POST_INSTALL_TARGET_HOOKS += SYSDIG_INSTALL_DRIVER
+
+$(eval $(cmake-package))