Skip to contentSkip to conversation

postgresql: uses fork(), needs mmu

PATCH New Peter Seiderer 2 participants 2 messages Mar 17, 2015

lore
Share & tools
lore

Peter Seiderer

author
#0 lore raw

PATCH v2 1/1 postgresql: uses fork(), needs mmu

Additional revert 'postgresql: enable bfin compile' ([2]) which is now useless (Blackfin is a noMMU architecture).

Fixes ([1]):
postmaster/fork_process.o: In function `_fork_process':
fork_process.c:(.text+0x22): undefined reference to `_fork'

[1] http://autobuild.buildroot.org/results/c9c/c9c93156fe64e89f35627aa592c47d8c5181ed7d
[2] http://git.buildroot.net/buildroot/commit/?id=6f177dac73a289db28772fb3e20347aba5cd5e67

Signed-off-by Peter Seiderer <[email protected]>

---
Changes v1 --> v2:
- additional revert 'postgresql: enable bfin compile' (suggested by Thomas Petazzoni)

---
 package/postgresql/Config.in     | 1 +
 package/postgresql/postgresql.mk | 7 +------
 2 files changed, 2 insertions(+), 6 deletions(-)
package/postgresql/Config.in +1 -0
index 519b2a1..4c53703 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_POSTGRESQL
 	bool "postgresql"
+	depends on BR2_USE_MMU # fork()
 	help
 	  PostgreSQL is a powerful, open source object-relational
 	  database system.
package/postgresql/postgresql.mk +1 -6
index d426093..7dc3f0b 100644
@@ -13,11 +13,6 @@ POSTGRESQL_LICENSE_FILES = COPYRIGHT
 POSTGRESQL_INSTALL_STAGING = YES
 POSTGRESQL_CONFIG_SCRIPTS = pg_config
 
-# In most cases, postgresql configure script is able to guess the
-# platform, except for noMMU platforms that use the 'uclinux' host
-# qualifier, as is the case on Blackfin
-POSTGRESQL_CONF_OPTS = --with-template=linux
-
 ifeq ($(BR2_TOOLCHAIN_USES_UCLIBC),y)
 # overwrite IPV6 detection
 ifeq ($(BR2_INET_IPV6),y)

@@ -36,7 +31,7 @@ ifneq ($(BR2_TOOLCHAIN_HAS_THREADS),y)
 	POSTGRESQL_CONF_OPTS += --disable-thread-safety
 endif
 
-ifeq ($(BR2_bfin)$(BR2_microblazeel)$(BR2_microblazebe)$(BR2_nios2)$(BR2_xtensa),y)
+ifeq ($(BR2_microblazeel)$(BR2_microblazebe)$(BR2_nios2)$(BR2_xtensa),y)
 	POSTGRESQL_CONF_OPTS += --disable-spinlocks
 endif
Signature · 1 line
2.1.4
#1 lore raw

PATCH v2 1/1 postgresql: uses fork(), needs mmu

Dear Peter Seiderer,

Quoted 11 lines · Peter Seiderer

Additional revert 'postgresql: enable bfin compile' ([2]) which is now useless (Blackfin is a noMMU architecture).

Fixes ([1]):
postmaster/fork_process.o: In function `_fork_process':
fork_process.c:(.text+0x22): undefined reference to `_fork'

[1] http://autobuild.buildroot.org/results/c9c/c9c93156fe64e89f35627aa592c47d8c5181ed7d
[2] http://git.buildroot.net/buildroot/commit/?id=6f177dac73a289db28772fb3e20347aba5cd5e67

Signed-off-by Peter Seiderer <[email protected]>

Thanks, but you forgot to propagate the BR2_USE_MMU dependency to the packages that select BR2_PACKAGE_POSTGRESQL and that don't already depend on BR2_USE_MMU. I've done that and applied.

Thanks,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com